Face-to-face (plugin)

OK, I looked over the code briefly....

It looks like duration is stored as a decimal hour (stange, no? why introduce a decimal when the number of minutes is an integer value) so this finds the decimal component of duration and compues the minutes
$minutes = round(($duration - floor($duration)) * 60);
and this is obviously the hours
$hours = floor($duration);
and then I lose my way with

if (1 == $hours) {
$string = get_string('onehour', 'facetoface');
} elseif ($hours > 1) {
$string = get_string('xhours', 'facetoface', $hours);
}
// Insert separator between hours and minutes
if ($string != '') {
$string .= ' ';
}
if (1 == $minutes) {
$string .= get_string('oneminute', 'facetoface');
} elseif ($minutes > 0) {
$string .= get_string('xminutes', 'facetoface', $minutes);
}

because there is no test for $hours<0 though you are storing duration as an hour decimal (i.e. half and hour would be .5)

But if the message is coming out as 20 hours (when the duration is actually 20 minutes) it suggests to me the code can't address meetings less than 1 hour, which seems consistent with the php which seems to address periods of 1 hr or greater

So wouldn't it make more sense to store duration as minutesand parsing the minutes into hours and minutes create a string that said
'Duration:'$hours' hour(s) and '$minute' minute(s)'
or even changed the minute or hour to plural depending if the respective variable was >1 (or save on the code at the cost to the db by saving duration as two separate fields of hours and minutes - LOL) ?

Or you could just use : as the separator between $hours and $minutes instead of a space.....

Hi Marc,

The duration field is actually separate from the start and end time. This is done because some sessions can be over multiple days.

When adding/editing a session, the number that is entered is in hours with fractional numbers allowed (see the contextual help next to that field).

Then it is stored in the database as a number of minutes.

Finally, it's displayed to users (on the signup page for example) in a nicer human-readable way: 1 hour 30 minutes.

Cheers,
Francois