Git commits in Moodle 3.9.0 by Tim Hunt

commit 89c8a076b28e05f77717b09e62af24db58221865
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 19 May 2020 05:55:50 +0800
Tag:    v3.9.0-beta

MDL-68733 quiz editing: behat test for altering random question tags

commit c689726d3fb67da478d63cd23a7c4060a4dfe6cc
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 19 May 2020 04:50:43 +0800
Tag:    v3.9.0-beta

MDL-68733 question behat: question tag generator and use in quiz test

commit c3dd5ccc408ed70cbfcf6006fe56919b0a610799
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 19 May 2020 00:31:43 +0800
Tag:    v3.9.0-beta

MDL-68760 timezones: add string for new timezone America/Nuuk

commit 8f406297e041e500ee787ba2bff9f96186a3939c
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 18 May 2020 23:51:17 +0800
Tag:    v3.9.0-beta

MDL-68760 string tests: make test_timezone_lang_strings message helpful

commit 4a45b7112ca9089e5988070d7635221589c6588d
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 18 May 2020 20:09:24 +0800
Tag:    v3.9.0-beta

MDL-68757 questions: don't do output in low-level functions

commit 89ee18c0e175e7e431665ffcae5d89eae9331d1a
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 15 May 2020 20:11:43 +0800
Tag:    v3.9.0-beta

MDL-62487 quiz manual grading: implement suggestions from int review

commit f883c681ff14ab85ee6f9216d89046f090119bb7
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sat, 09 May 2020 16:49:38 +0800
Tag:    v3.9.0-beta

MDL-68645 output: Make module generators fail if they init the output

commit 1ed243c2fef999dd23b5c36fe62171ad6392a493
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 06 May 2020 16:14:49 +0800
Tag:    v3.9.0-beta

MDL-68402 accesslib: fix coding style of loops

commit bee903193be3ad923360a008dbd1b65c98f86655
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 06 May 2020 14:46:09 +0800
Tag:    v3.9.0-beta

MDL-68615 questions: more increment idnumber cases found by our tester

commit 1d47cb2168ccf870934c5d71f5c89bf25c451c89
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 05 May 2020 22:43:57 +0800
Tag:    v3.9.0-beta

MDL-68615 questions: fix fiendish default idnumber edge case

commit 33d4f4b0b9ea2bd71be4ddbeeb5b0e3b7e3af7a3
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 29 Apr 2020 05:42:32 +0800
Tag:    v3.9.0-beta

MDL-47750 Atto: allow pasting of images

commit 848a29cf5126e889932a4f58a8c0227d3a5b7ef2
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sun, 26 Apr 2020 21:20:30 +0800
Tag:    v3.9.0-beta

MDL-57680 form autocomplete: extend Behat tests

commit be612e5f68c2f29df1e6bb0d91f8ec493c886959
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sun, 26 Apr 2020 20:02:12 +0800
Tag:    v3.9.0-beta

MDL-57680 form autocomplete: fix triggering change event

commit 588b86fd4928ef4acef3b66ed23e30cece364ff3
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sat, 25 Apr 2020 21:39:27 +0800
Tag:    v3.9.0-beta

MDL-57680 form autocomplete: let singleselects be cleared.

commit 64207dab65b0e1e403a982b7a0f7a0693ef68858
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 24 Apr 2020 23:12:04 +0800
Tag:    v3.9.0-beta

MDL-67183 questions: get_question & get_behaviour only init if required

commit 9cbbb779ebde83edda9ad7f5618b88f2ce5e21f8
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 24 Apr 2020 23:11:51 +0800
Tag:    v3.9.0-beta

MDL-67183 question engine: allow lazy-init of question_attempts

commit 07d90238c68840444eb147516b3ffc3441bfc410
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 23 Apr 2020 04:04:09 +0800
Tag:    v3.9.0-beta

MDL-57240 quiz: don't show useless links on overdue attempt summary page

commit 1736c599251403df6ad5002cfccee20ba4a8ad85
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 15 Apr 2020 05:29:17 +0800
Tag:    v3.9.0-beta

MDL-68402 accesslib: Modernise coding style in the functions changed

commit 0d3bdb94bc9ba47be88d3a1025d0d30b06cbf98e
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 15 Apr 2020 00:06:13 +0800
Tag:    v3.9.0-beta

MDL-68402 accesslib: fix get_with_capability_join logic

commit 9205d263d680f5590d8d8ede13c751d10599f5ac
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 08 Apr 2020 00:21:54 +0800
Tag:    v3.9.0-beta

MDL-68256 task admin UI: Grrrr! browsers

commit 3d96227305723cebad08704d2ce646934556cf4a
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 06 Apr 2020 00:49:41 +0800
Tag:    v3.9.0-beta

MDL-68338 qformat_gift: support idnumbers and tags

commit a196cf5ac1ebf1d88c2161eddf2966e05fb4d69e
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sun, 05 Apr 2020 20:27:17 +0800
Tag:    v3.9.0-beta

MDL-66259 qtypes: Add missing comment on get_random_guess_score

commit 82df13aeaddff4f93266ed3286ccd121e80a7765
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sun, 05 Apr 2020 20:23:29 +0800
Tag:    v3.9.0-beta

MDL-66259 qtype_numerical: remove no-longer relevant todo I noticed

commit a0f89443051ccaa217803ed84eefc6559c409fb0
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 02 Apr 2020 16:22:56 +0800
Tag:    v3.9.0-beta

MDL-68300 question bank: merge duplicate Duplicate Behat tests

commit 7459856d26f0c57bc40cd338e73db9a379988766
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 31 Mar 2020 17:33:18 +0800
Tag:    v3.9.0-beta

MDL-68300 questions: un-break duplicating questions without idnumbers

commit 9874e7cdd0a4ed95859ea6ec019ad291203e6225
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 30 Mar 2020 04:28:48 +0800
Tag:    v3.9.0-beta

MDL-66259 qtype_truefalse: unit test of loading questions from the DB

commit 5c3f700ac747ab47411f790087b7794cff35f2b9
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 30 Mar 2020 04:22:48 +0800
Tag:    v3.9.0-beta

MDL-66259 quiz responses: fix unrealistic test setup

commit 2bfb8d4a3d41c08314cda392754c37995148d27f
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 30 Mar 2020 00:03:31 +0800
Tag:    v3.9.0-beta

MDL-63812 qtype_gapselect: fix questions with non-consecutive gap nos

commit fdbff6cecbc5566b6eea0138c2956b0866163a21
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sun, 29 Mar 2020 23:40:58 +0800
Tag:    v3.9.0-beta

MDL-63812 qtype_gapselect: test data generator to standard qtype pattern

commit b20541805f9a58eef5c9e3d8a5dfac999dd9c9e6
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sun, 29 Mar 2020 06:49:43 +0800
Tag:    v3.9.0-beta

MDL-62487 quiz manual grading: store options as user preferences

commit e37acc67735f9f1da8682b00b1eff2e11e9d091c
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sun, 29 Mar 2020 06:12:30 +0800
Tag:    v3.9.0-beta

MDL-62487 quiz manual grading: clean coding style and add PHPdocs

commit dbf72bb40fb6a44a66f5d6e35cb54473135b5517
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 27 Mar 2020 21:29:40 +0800
Tag:    v3.9.0-beta

MDL-68277 qtype_essay: answer area in reviews should be right size

commit 9bf4d19930075270449c4f8980f8d472f10811d9
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 27 Mar 2020 03:49:32 +0800
Tag:    v3.9.0-beta

MDL-67895 task admin: show defaults when editing a task

commit 6fdc0f8796f9fbcd01a479480837b69d5bff6ca4
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 27 Mar 2020 00:59:26 +0800
Tag:    v3.9.0-beta

MDL-68256 task admin: usability improvements

commit fa7431ce502193e9406ba3a244cb30e87b256261
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 26 Mar 2020 01:16:44 +0800
Tag:    v3.9.0-beta

MDL-68252 question tags: fix tag editing for missingtype questions

commit 89692520e8ed04099249f707364cb8e64119c3d8
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 26 Mar 2020 01:15:51 +0800
Tag:    v3.9.0-beta

MDL-68252 question bank: for 'missingtype' questions, hide actions

commit 19f221961e8f1d0b960be8f8d9f6d4d440039439
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 24 Mar 2020 22:20:45 +0800
Tag:    v3.9.0-beta

MDL-68233 renderers/block: fix reported coding style issues

commit 1dcd0d349977b90a6dd1748af5f330a3c55b6b00
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 24 Mar 2020 21:32:22 +0800
Tag:    v3.9.0-beta

MDL-68233 renderers/block: remove illegal uses of $PAGE and $OUTPUT

commit 4b03530ca8799083812241c9a9b9782d87dcc653
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 18 Mar 2020 07:18:08 +0800
Tag:    v3.9.0-beta

MDL-68191 CSS minification: apply upstream performance/accuracy fix

commit fb37a2d49d4a501813a2c03a00c936de267feead
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 13 Mar 2020 22:14:25 +0800
Tag:    v3.9.0-beta

MDL-52319 install: Fix some coding style issues

commit f3d77f0c9edd6ed4a89b41b36a442af1c87d33e7
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 13 Mar 2020 21:57:43 +0800
Tag:    v3.9.0-beta

MDL-52319 upgrade: Also run environment checks if plugins need upgrades

commit 511801eaa97d6f308b0a697e0b09bbeeb82c191b
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 12 Mar 2020 04:40:51 +0800
Tag:    v3.9.0-beta

MDL-68153 qbank: question of unknown type should not cause fatal error

commit 9440b54f8a379dd8568b1b81b8a38b12d9eb167b
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 11 Mar 2020 20:28:39 +0800
Tag:    v3.9.0-beta

MDL-68149 qtype_match: correctly distinguish 0 and 0.0 answers

commit b060e7495c11e07bec4960bb342f9f9edcd7b2dd
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 11 Mar 2020 19:01:56 +0800
Tag:    v3.9.0-beta

MDL-68149 qtype_match: Updatey tests to follow make_question() pattern

commit 1b6b554118525f2eeb3664abc2c1a15973c91b18
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 20 Feb 2020 01:01:31 +0800
Tag:    v3.9.0-beta

MDL-67981 questions: avoid errors deleting contextless questions

commit 887daf932cac2554982f4dc9bcb49db2da9ded5a
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 14 Feb 2020 00:09:33 +0800
Tag:    v3.9.0-beta

MDL-67947 questions: questions_in_use should ask all components

commit 35e1470e065c22de61e47f637fe0bc0b3ade131f
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 12 Feb 2020 22:26:16 +0800
Tag:    v3.9.0-beta

MDL-67878 grunt: make it works on Windows

commit ae5d5f2085a44351ef31bdf42104f2895b7c9e0b
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 12 Feb 2020 17:58:47 +0800
Tag:    v3.9.0-beta

MDL-67876 forms: not all field types need validation JS

commit f2393804bf57f4e3ef9d20dcfa7c3e3935d76be5
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 12 Feb 2020 01:31:05 +0800
Tag:    v3.9.0-beta

MDL-67934 questions: give a sensible default idnumber when duplicating

commit a5b56c4da5530e75f8f1054a955c0c9754e6d1e7
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 05 Feb 2020 20:18:17 +0800
Tag:    v3.9.0-beta

MDL-67876 forms: scroll to any invalid element if form cannot submit

commit 007d13f1472b6055ab0e149ac593b6becd0eb5fb
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 04 Feb 2020 02:53:06 +0800
Tag:    v3.9.0-beta

MDL-67857 formchangechecker: support form submits that dont save

commit 2569fb5d2cb61f765071246d9776bb48f14a45df
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 31 Jan 2020 01:24:23 +0800
Tag:    v3.9.0-beta

MDL-67842 questions: Cannot remove the idnumber from a question

commit a33e0b4d8448e6d6f80190310427bec73af83126
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 30 Jan 2020 02:34:39 +0800
Tag:    v3.9.0-beta

MDL-67830 quiz: notice in grade details redirect script

commit 1aacbb72d3a2bf12821a3c8756abf5e27be22fe3
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 30 Jan 2020 02:14:58 +0800
Tag:    v3.9.0-beta

MDL-67832 quiz: fix lots of PHPdoc in attemptlib.php

commit 1d674587837dab094c81d8baaca59f67358465f5
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 21 Jan 2020 00:15:55 +0800
Tag:    v3.9.0-beta

MDL-64531 course: course_delete_module shouldn't output during AJAX

commit 76a49e4a1e160cf241277fe0a8cf88f00f8aa261
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 10 Jan 2020 04:19:43 +0800
Tag:    v3.9.0-beta

MDL-67653 questions: prevent the flag flickering as the page loads

commit 74f3415483fac60f4fcb8763bf1e3940d8c3446f
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 07 Jan 2020 21:59:39 +0800
Tag:    v3.9.0-beta

MDL-67631 quiz editing: add random dialogue should offer all numbers

commit 550599e001de37073e3e04e8ca9fd08d7ac692c4
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 07 Nov 2019 06:17:23 +0800
Tag:    v3.9.0-beta

MDL-67155 quiz: first attempt_step should record the student's userid

commit 45c4d4aa8c7e7fcc3d042c65aa93263dbfb22356
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 10 Oct 2019 19:32:09 +0800
Tag:    v3.9.0-beta

MDL-46123 accesslib: improve get_component_string

commit 285c703685a6d89cf73e6900df8168dc6a1f511b
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 26 Apr 2019 03:57:44 +0800
Tag:    v3.9.0-beta

MDL-48024 behat: allow plugins to have data generators

commit 87554981f0ec10cc076bfa345cfd13c5c37a39e0
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 28 Jul 2014 22:01:23 +0800
Tag:    v3.9.0-beta

MDL-46542 formslib: duration field option for which units to show