Git commits in Moodle 3.7.x by Tim Hunt

commit 82258882da0b8902d379501928f5676915edcfff
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 19 May 2020 05:55:50 +0800
Tag:    v3.7.7

MDL-68733 quiz editing: behat test for altering random question tags

commit db233ce7e2166c80a60d0898c57ac2056136ca71
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 19 May 2020 04:50:43 +0800
Tag:    v3.7.7

MDL-68733 question behat: question tag generator and use in quiz test

commit 045d650ae3ebddd98ef7490c1506ccb0f3921895
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 19 May 2020 00:31:43 +0800
Tag:    v3.7.7

MDL-68760 timezones: add string for new timezone America/Nuuk

commit 890e60c709e5f79dbea06e49b0a520e8e3a76259
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 18 May 2020 23:51:17 +0800
Tag:    v3.7.7

MDL-68760 string tests: make test_timezone_lang_strings message helpful

commit 55ba3eece2323aff38ef556d091eb12d69a57ee1
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 06 May 2020 16:14:49 +0800
Tag:    v3.7.6

MDL-68402 accesslib: fix coding style of loops

commit e43a539e100b36d670d392b6a30c3eb0f294db34
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sun, 26 Apr 2020 21:20:30 +0800
Tag:    v3.7.6

MDL-57680 form autocomplete: extend Behat tests

commit 80474ee9e886fdbef8261120f66706b92713a977
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sun, 26 Apr 2020 20:02:12 +0800
Tag:    v3.7.6

MDL-57680 form autocomplete: fix triggering change event

commit cce1fe41a6f24253b196836b4db9d720e9220858
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sat, 25 Apr 2020 21:39:27 +0800
Tag:    v3.7.6

MDL-57680 form autocomplete: let singleselects be cleared.

commit fb990d26d4e2033de0c5d9725139d40817ec2b34
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 15 Apr 2020 05:29:17 +0800
Tag:    v3.7.6

MDL-68402 accesslib: Modernise coding style in the functions changed

commit 96dbdc2ad99a882796b54829c1179810f22ddca3
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 15 Apr 2020 00:06:13 +0800
Tag:    v3.7.6

MDL-68402 accesslib: fix get_with_capability_join logic

commit 6536a3ff9ba04c8da345b9f8a5fad57cc6c084a7
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 27 Mar 2020 21:29:40 +0800
Tag:    v3.7.6

MDL-68277 qtype_essay: answer area in reviews should be right size

commit 8475b74d0c5d66252ea1fe9c31b4479d64bc26cb
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 13 Mar 2020 22:14:25 +0800
Tag:    v3.7.6

MDL-52319 install: Fix some coding style issues

commit f246d308312d8bd2de6dcac5158dbb02b6a7a88c
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 13 Mar 2020 21:57:43 +0800
Tag:    v3.7.6

MDL-52319 upgrade: Also run environment checks if plugins need upgrades

commit 631b1f77f0c77a846facc1ef9a7d1333be9f3e87
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 11 Mar 2020 20:28:39 +0800
Tag:    v3.7.6

MDL-68149 qtype_match: correctly distinguish 0 and 0.0 answers

commit ec67d8b676a47aa331961da2d5f1900b4210b745
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 11 Mar 2020 19:01:56 +0800
Tag:    v3.7.6

MDL-68149 qtype_match: Updatey tests to follow make_question() pattern

commit 0c90bc8cd34ecd57c8dc9c681530d275ff96cd0f
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 20 Feb 2020 01:01:31 +0800
Tag:    v3.7.6

MDL-67981 questions: avoid errors deleting contextless questions

commit 2a912052bc577504cd8338c31b2844387d831c06
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 14 Feb 2020 00:09:33 +0800
Tag:    v3.7.5

MDL-67947 questions: questions_in_use should ask all components

commit 603e31b820aab3ffa43046ed22c83271db8743c0
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 12 Feb 2020 17:58:47 +0800
Tag:    v3.7.5

MDL-67876 forms: not all field types need validation JS

commit 4a0abc17d46e4fc96798b848619b359d71dd8ccb
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 05 Feb 2020 20:18:17 +0800
Tag:    v3.7.5

MDL-67876 forms: scroll to any invalid element if form cannot submit

commit a8e2b5cea1bf9bc7b2fd3bb22d9d206cb8a82315
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 31 Jan 2020 01:24:23 +0800
Tag:    v3.7.5

MDL-67842 questions: Cannot remove the idnumber from a question

commit bfff57b297e482295dfea63a8dad292ceedb21f7
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 30 Jan 2020 02:34:39 +0800
Tag:    v3.7.5

MDL-67830 quiz: notice in grade details redirect script

commit 7fda2e9bac7d64b865c482040c61c24d0374034b
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 30 Jan 2020 02:14:58 +0800
Tag:    v3.7.5

MDL-67832 quiz: fix lots of PHPdoc in attemptlib.php

commit d00045e8f5ef85cc90529945f59ccc78d3980d6d
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 21 Jan 2020 00:15:55 +0800
Tag:    v3.7.5

MDL-64531 course: course_delete_module shouldn't output during AJAX

commit 6cb1f99459a93c973ee17ab975a4394751d46dc0
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 10 Jan 2020 04:19:43 +0800
Tag:    v3.7.5

MDL-67653 questions: prevent the flag flickering as the page loads

commit 8e506aa53c3467b0903d3e21868f4145b5c145a5
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 21 Oct 2019 18:18:12 +0800
Tag:    v3.7.3

MDL-66980 question bank: fix load_many_for_cache missing record check

commit 90766fb12b298d6d7f06af3ff64f8ddb44da8b5a
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 18 Oct 2019 00:36:23 +0800
Tag:    v3.7.3

MDL-66946 quiz reports: incorrectly show teachers sometimes

commit 2903b1ae22b5bdd9b75bab9930137a9d0f423718
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 14 Oct 2019 22:27:09 +0800
Tag:    v3.7.3

MDL-66796 question bank: fix more bugs with category editing

commit d9dc216897318d130fb68f65c4fe28e3bf7bdcd4
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sat, 05 Oct 2019 20:50:43 +0800
Tag:    v3.7.3

MDL-66559 behat: Documentation for component selectors

commit f5fbfb4d6b609148f27fd4096421fb034fc29e95
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 03 Oct 2019 19:55:59 +0800
Tag:    v3.7.3

MDL-66835 behat: steps for setting/checking fields in containers

commit ff76a9d590f2d146aa93b27bc224ed65eb701506
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 02 Oct 2019 22:58:04 +0800
Tag:    v3.7.3

MDL-66821 question behat: new step for acting on questions in the bank

commit 5fa3dccf4b5f893572acbe3841f3b826b0ff6166
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 01 Oct 2019 23:43:22 +0800
Tag:    v3.7.3

MDL-66815 behat: question category generator must find right parent id

commit 01d1ae9a5bf72be4dc7ed216b99ec910371e3a2a
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 01 Oct 2019 01:21:18 +0800
Tag:    v3.7.3

MDL-66801 questions: XML import/export should include category idnumbers

commit 1fa5fe21048b1b7d5a1f187655618d10875159f3
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 30 Sep 2019 20:13:06 +0800
Tag:    v3.7.3

MDL-66796 question bank: 0 is a valid question category idnumber

commit 2366f12757d513f3594a1f8101c580d96d5191ff
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 25 Sep 2019 00:45:52 +0800
Tag:    v3.7.3

MDL-66764 quiz: redo question should not repeat random questions

commit f5f5bfbdf7be366963312542fb10c6c95fa556fb
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 23 Sep 2019 19:14:11 +0800
Tag:    v3.7.3

MDL-66750 formslib selects: handle size attribute properly

commit 40ed8aa97afebaf159fbe8251e8c69e4dabd17fb
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 16 Sep 2019 21:35:18 +0800
Tag:    v3.7.3

MDL-66685 questions: should able to save an empty question usage

commit 87cc8008f42300b6e50b0466d96ddb8b4463d36b
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 10 Sep 2019 19:11:27 +0800
Tag:    v3.7.3

MDL-66641 quiz stats: discriminativeefficiency is already out of 100

commit df143c2923960915f4745d20b510423fefe8d101
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 06 Sep 2019 01:00:39 +0800
Tag:    v3.7.3

MDL-66335 behat: new step to log in and go straight to a particular page

commit 87252eae2cb8edacc2e31f518ff4491c122be141
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 07 Aug 2019 22:18:45 +0800
Tag:    v3.7.3

MDL-66335 quiz behat: using the new generic navigation steps

commit 621e8888e553be555502dac5134a4e6456bc2495
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 07 Aug 2019 22:18:14 +0800
Tag:    v3.7.3

MDL-66335 behat: generic step for navigating direct to specific pages

commit b652d2afc7d0326396411a4df525e7a0f62ef283
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 06 Aug 2019 00:11:56 +0800
Tag:    v3.7.3

MDL-66328 groups: overview page can require lots of memory

commit 0101cefdca47aa74a697e306ef28d53dd21377ce
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 31 Jul 2019 23:18:16 +0800
Tag:    v3.7.2

MDL-33884 question export: raise memory limit

commit 6e5e4cc208484bb76fceac5dbaebeb37f5a89628
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 19 Jun 2019 00:14:37 +0800
Tag:    v3.7.1

MDL-57884 quiz: autosave should not send the value of submit buttons

commit 8d4f41b4730959d7ed258538320bf3f9352b7556
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sat, 15 Jun 2019 01:30:52 +0800
Tag:    v3.7.2

MDL-57239 qbehaviour_interactive: fix Try again button when reviewing

commit 55929d8a49980a9dc1ec8eb8de3058fad75fdf58
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 07 Jun 2019 02:41:34 +0800
Tag:    v3.7.1

MDL-65864 question engine: fix re-saving a new usage

commit 15d5c9a276b42c8a9f5e265cef7ab33ad0875bb4
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 29 May 2019 20:38:41 +0800
Tag:    v3.7.1

MDL-65731 quiz manual grading: fix ambiguous order by idnumber

commit a586240cc0aef05d8c81997588e599ddf2edebe0
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 17 May 2019 22:35:54 +0800
Tag:    v3.7.1

MDL-55197 filter_multilang: handle 'en' as parent lang better

commit d2680dbb27610a7525e5932c67e274b78d3422e6
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 17 May 2019 22:18:06 +0800
Tag:    v3.7.1

MDL-55197 filter_multilang: move preg_callback fn into class

commit 09558248e801f998e7a4873e32045b4f90d9d724
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 17 May 2019 19:22:19 +0800
Tag:    v3.7.1

MDL-65636 filter_multilang: add some basic unit tests

commit 265296a26e0400faa733b3f849029191c0d45ed0
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 26 Apr 2019 03:57:44 +0800
Tag:    v3.7.4

MDL-48024 behat: allow plugins to have data generators

commit d1ac356a8b9f05e21c3731e2bde0289cda4332ca
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 15 Apr 2019 23:50:46 +0800
Tag:    v3.7.0-beta

MDL-60418 Behat: Fix broken docs links in Behat code.

commit 7d2c7fed744938bd8eb1eb81bcc376f156322ab6
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 08 Apr 2019 19:19:13 +0800
Tag:    v3.7.0-beta

MDL-65296 questions:  field should be declared

commit ab2474726d4ddea0862291f2470a2cf6fcf4354a
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 03 Apr 2019 18:51:14 +0800
Tag:    v3.7.0-beta

MDL-65260 users policies: allow username in Show user identity

commit 6c91e515b0ea852a2c439982730489ebf99f191f
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 02 Apr 2019 22:16:03 +0800
Tag:    v3.7.0-beta

MDL-65245 question_attempt: fix PHPdoc and other PHPstorm warnings

commit be492e2a8f2eed8e044b2099cbfd043f9f755f66
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 02 Apr 2019 21:12:45 +0800
Tag:    v3.7.0-beta

MDL-65245 question engine: response vars should always be PHP strings

commit 05ea7ab19ec4cf88c2fc6c4b00e11628c3d1c95e
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 29 Mar 2019 22:39:27 +0800
Tag:    v3.7.0-beta

MDL-65222 questions: explain question walkthrough tests

commit f1ffd134d3167e462dca9bb7c9db545fed8a42fe
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 29 Mar 2019 21:37:30 +0800
Tag:    v3.7.0-beta

MDL-65029 questions: change question div id to acutally be unique

commit a0536c410a8c62ba3758ce88e7ad719f20b64001
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 01 Mar 2019 19:12:40 +0800
Tag:    v3.7.0-beta

MDL-64981 dml tests: pgsql_native_recordset_testcase port number

commit 822b4abb1e3382d86e6c618f50daa5b912b7ac53
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 08 Feb 2019 23:52:44 +0800
Tag:    v3.7.0-beta

MDL-64242 qtype_essay: more efficient query in restore code

commit a73fa10678e1f7b3005a5c10c3592d19b466b40a
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 21 Jan 2019 21:17:56 +0800
Tag:    v3.7.0-beta

MDL-64521 grouplib: reduce memory use in groups_get_all_groups

commit d387f50fcdd8ede4433d344ee4b588837a875b4a
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sat, 19 Jan 2019 02:00:42 +0800
Tag:    v3.7.0-beta

MDL-64590 questions: wrong comments shown in the state history table

commit bd8774d55e5c3180019388d4834afa87184a9523
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 18 Jan 2019 23:58:11 +0800
Tag:    v3.7.0-beta

MDL-64591 User tours: don't show during redirects & other bad times

commit cdfee883aaa414379e8ef57a4bb38097da977c17
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Sat, 12 Jan 2019 02:35:05 +0800
Tag:    v3.7.0-beta

MDL-63870 quiz: new preview should abandon, not finish, current attempt

commit d434dd7ae74c3d789d59b33e3a3b65c8dac8138a
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 09 Jan 2019 02:20:56 +0800
Tag:    v3.7.0-beta

MDL-64479 dd-qtypes: fix questions with non-consecutive groups

commit e5153d93c058f5f2987d48123987bfca726b9939
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Wed, 19 Dec 2018 21:49:25 +0800
Tag:    v3.7.0-beta

MDL-64393 drag-drop qtypes: be more robust when page layout changes

commit b195523758b0df27cb2c53b9bf65449677d73c09
Author: Tim Hunt <t.j.hunt@open.ac.uk>
Date:   Tue, 18 Dec 2018 11:53:31 +0800
Tag:    v3.7.0-beta

MDL-63809 question bank: ensure question_has_capability_on can be called

commit a44065edaa6b94b0d4a97e95974135ad9c2a1486
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 14 Dec 2018 00:04:28 +0800
Tag:    v3.7.0-beta

MDL-61441 accesslib: get_users_by_capability groups perf improvement

commit 2fbd8e9ec0dd0662f076feb48150fb9a3f8bd153
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 07 Dec 2018 03:27:29 +0800
Tag:    v3.7.0-beta

MDL-63260 qtype_random: orphaned random questions should be deleted

commit d6388d0acf3938108bbb60ea530cf6f6b3a88b03
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Thu, 06 Dec 2018 01:04:05 +0800
Tag:    v3.7.0-beta

MDL-64332 questions: idnumber should not prevent easy duplication

commit a3796190a60e9fd93366d095a470b097bf2918e7
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 30 Nov 2018 20:33:54 +0800
Tag:    v3.7.0-beta

MDL-64286 qtype_gapselect: removed unneeded line of code

commit c942cad763899e02b570761db36ef0f271cdf8d7
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 27 Nov 2018 01:09:17 +0800
Tag:    v3.7.0-beta

MDL-64465 qtypes: fix incorrect context passed to format_string

commit 614077863bcb3c46d067661363829a37762fe141
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 26 Nov 2018 20:52:09 +0800
Tag:    v3.7.0-beta

MDL-63459 qtype_calculatedmulti: fix incorrect hint object type

commit 1e8374c37018eb74d1709aa4c2da630de85b8b77
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 26 Nov 2018 20:49:47 +0800
Tag:    v3.7.0-beta

MDL-63459 qtype_calculatedmulti: unit test should test this qtype

commit 096a5b9949af4a51beb3eb913c9ffa2bc17271d5
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Fri, 23 Nov 2018 23:49:31 +0800
Tag:    v3.7.0-beta

MDL-64464 drag-drop qtypes: allow <span lang=".."> id draggables

commit ab1272a0da3e741918fc407896e927095a5bf118
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Mon, 05 Nov 2018 20:44:03 +0800
Tag:    v3.7.0-beta

MDL-46783 accesslib: add tests for MDL-63772 and MDL-63818

commit 939218c2b66b514d945357d349124654563c83f9
Author: Tim Hunt <T.J.Hunt@open.ac.uk>
Date:   Tue, 30 Oct 2018 20:00:12 +0800
Tag:    v3.7.0-beta

MDL-46783 permissions: let some moodle/ caps be overriden in all mods