Git commits in Moodle 2.5.x by Mark Nelson

commit 9941015719002dc4579d1a7d118ce8190644fdc0
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 09 Apr 2014 15:00:25 +0800
Tag:    v2.5.6

MDL-42462 mod_feedback: added $OUTPUT to list of global variables used to avoid error

commit 0343f4081b8c1d2ba3de9a12c29071b819352aac
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 31 Dec 2013 06:20:06 +0800
Tag:    v2.5.5

MDL-43332 core_grades: automated basic grade viewing functionality performed in MDLQA-317

commit c90c329d570b5d8e6b2ddd066ca58a390c8d2f83
Author: Mark Nelson <markn@moodle.com>
Date:   Sat, 30 Nov 2013 06:25:45 +0800
Tag:    v2.5.4

MDL-43140 mnet: display header after redirects to avoid warning

commit 6d5aa15b8d6edb1d2c57a66151722d0c650da947
Author: Mark Nelson <markn@moodle.com>
Date:   Sat, 30 Nov 2013 06:12:09 +0800
Tag:    v2.5.4

MDL-43142 mnet: fixed typo in variable passed to get_string

commit 44a9508cb9111c03ee2f85b757ae0ba2c9ad0e32
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 27 Nov 2013 13:26:03 +0800
Tag:    v2.5.4

MDL-42885 tool_uploaduser: removed misleading debugging message

commit 68cc921a375c1c95cc41ddfb7262d9e8eaa79598
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 14 Nov 2013 09:25:48 +0800
Tag:    v2.5.4

MDL-42547 tool_uploaduser: trim values before uploading users

commit 38ad8f35da93c19074e924323ad6ca2f1e7a89cd
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 31 Oct 2013 16:06:42 +0800
Tag:    v2.5.3

MDL-42566 mod_data: introduced check to ensure the picture supplied is valid

commit 89f71167f10dc3bdb80ce3b46d7e90f07e09ff3b
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 30 Oct 2013 17:24:48 +0800
Tag:    v2.5.3

MDL-42613 core_group: removed unnecessary table row when there is no group description or picture

commit 49875e3a890f20ecec8fcf461ac6db9324c1db05
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 25 Oct 2013 18:04:45 +0800
Tag:    v2.5.4

MDL-42276 core_group: added behat tests to automate group actions

commit a57462fab529c1fb114216096b1975280ee16a14
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 22 Oct 2013 16:04:19 +0800
Tag:    v2.5.3

MDL-42465 mod_chat: instantiated message object before declaring properties

commit 4b83e704b14b3ce316f302225bd8c56b74c8b8c4
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 22 Oct 2013 12:04:06 +0800
Tag:    v2.5.3

MDL-35146 mod_wiki: fixed variable typo and altered code to conform to Moodle guidelines

commit f329d60c38905bbdec1c10491d1dc864df9b392e
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 21 Oct 2013 12:19:54 +0800
Tag:    v2.5.3

MDL-42429 mod_lesson: removed unnecessary conditional check

commit 3c78a1c3813aedc26fc9b50d4206087a089940bd
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 18 Oct 2013 11:38:08 +0800
Tag:    v2.5.3

MDL-42421 auth: removed incorrect statement in upgrade.txt

commit fae00b43fe90fd5b26c021e87ac2acb5d27b2903
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 16 Oct 2013 11:20:40 +0800
Tag:    v2.5.3

MDL-42377 backup: fixed incorrect debugging message

commit 5f931bb78d3ac94fa098c77d4524f2f49fbcc01f
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 14 Oct 2013 17:21:47 +0800
Tag:    v2.5.3

MDL-42201 backup: introduced new automatic backup state

commit 8580fba15689d319a3e5c0478b2de54e2e55ae20
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 07 Oct 2013 17:25:44 +0800
Tag:    v2.5.3

MDL-37181 backup: stopped setting the status of unscheduled backups to skipped

commit e26f1e83a1ef9bc06b03dd7885e984ec23e4c128
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 26 Sep 2013 11:57:21 +0800
Tag:    v2.5.3

MDL-41995 calendar: changed the page layout for the export page

commit 33a42df4ad525719487815311764b250d119d536
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 06 Sep 2013 12:40:15 +0800
Tag:    v2.5.3

MDL-41417 course: allow the use of duplicated idnumbers if they existed before fix

commit 60abf0f6bdcd87872b73e1ea2be34a9c8f7e0db2
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 05 Sep 2013 00:37:51 +0800
Tag:    v2.5.2

MDL-40924 badges: added a print_error call to prevent PHP notices when no badges are found

commit 848c33eb87a0cfccf636359771f7ad1bf4e176f0
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 22 Aug 2013 17:12:30 +0800
Tag:    v2.5.2

MDL-41387 tags: changed character case in string used when deleting a course

commit 58e8778421ff9406802a3d8b119cff57d9aa00d3
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 22 Aug 2013 16:23:26 +0800
Tag:    v2.5.2

MDL-36126 backup: ensure the backup_logs message does not exceed the maximum allowed length in the DB

commit 23ad39f773ebac088cf6ef7c7030414ca72f3721
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 07 Aug 2013 11:14:48 +0800
Tag:    v2.5.2

MDL-40662 block_course_overview: added addinstance capability string

commit ea6b3ac108ef45d9d27321a9672666d1ce26b4ee
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 06 Aug 2013 11:38:10 +0800
Tag:    v2.5.2

MDL-27953 auth: documented the newly introduced function can_be_manually_set() in upgrade.txt

commit 4a546bf04ce10f387af15db252622b5107b1ea3d
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 30 Jul 2013 15:10:38 +0800
Tag:    v2.5.2

MDL-40662 block_course_overview: added addinstance capability to remove debugging message due to system context being used on the 'Default My home page'

commit db69373d40938e93d31989874f32a83cc01bf5b9
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 29 Jul 2013 19:12:38 +0800
Tag:    v2.5.2

MDL-38758 mod_forum: fixed issue where pass by reference removal caused an undefined variable error

commit 8a868abe2220f5464f575c0dc10117fb16c1f1f4
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 29 Jul 2013 15:33:21 +0800
Tag:    v2.5.2

MDL-27953 auth: allowed the LDAP plugin to be manually assigned to uploaded users

commit e94b6c678d187bddfe75ace07b463af1f5ce1f0d
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 22 Jul 2013 18:12:48 +0800
Tag:    v2.5.2

MDL-40816 backup: code cleanup on the manage backups form

commit ed31b623bcdd45d0e1d0b8267663e3995bc7df21
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 22 Jul 2013 17:42:42 +0800
Tag:    v2.5.2

MDL-40816 backup: added missing setType calls to the manage backups form

commit 5a21d336f35069eabf4ce18bd35075852d43227c
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 04 Jun 2013 18:19:30 +0800
Tag:    v2.5.1

MDL-40010 notes: passing an object rather than an id to avoid debugging message

commit 49acbbad2ffb56c30d0f73a25316c8226af87c26
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 04 Jun 2013 17:59:24 +0800
Tag:    v2.5.1

MDL-40009 notes: corrected the form element names passed to setType

commit f31670ef40530f8049d990106e2446bc03be5247
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 04 Jun 2013 11:55:48 +0800
Tag:    v2.5.1

MDL-40008 forms: fixed ordering of the calendar icon and enable checkbox for the date selector element

commit edc4670b4cd9768beb53f63801b29afa8c0ff918
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 09 May 2013 17:08:24 +0800
Tag:    v2.5.0

MDL-39581 forms: prevent calendar popup from changing multiple date elements

commit 34e338a458b742dd9a5321be431cee06cdd6b699
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 07 May 2013 17:31:14 +0800
Tag:    v2.5.0-rc1

MDL-39545 mod_assign: prevent notice from displaying when course module id does not exist

commit 63d2081ee78ce29ee74c2ec184ed3c6673bd19a4
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 07 May 2013 12:59:58 +0800
Tag:    v2.5.0-rc1

MDL-39535 grade: only display grade errors once

commit 33bea465bdd51fe16077ae8068887bbbfa43db6a
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 06 May 2013 13:51:00 +0800
Tag:    v2.5.0-rc1

MDL-39470 cache: added missing component to get_string call

commit e019dcccdf5d5d75ffc41e775c4932a364ad1da7
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 02 May 2013 13:44:09 +0800
Tag:    v2.5.0-rc1

MDL-39463 forms: use the date selectors 'optional' parameter rather than creating additional logic

commit 34f9862edf302f209b112808fffde0a89248f6b0
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 02 May 2013 13:19:40 +0800
Tag:    v2.5.0-rc1

MDL-39187 forms: fixed issue where calendar pop-up did not display when a date selector form element was added to a group

commit 34e29871181fba6585294aee03c93a2d96a39eb3
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 24 Apr 2013 12:57:33 +0800
Tag:    v2.5.0-rc1

MDL-39303 mod_forum: prevent user from submitting when post threshold reached

commit eaa8f5ad539911a4e72c031ec074054e662118df
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 24 Apr 2013 12:24:20 +0800
Tag:    v2.5.0-rc1

MDL-39192 mod_forum: do not need to check the posting threshold when editing a post

commit f5ad424b1196adde46e19b5c6def29af8a148b40
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 17 Apr 2013 16:40:27 +0800
Tag:    v2.5.0-rc1

MDL-39182 mod_forum: display the post threshold warning message in a more noticeable area

commit 4a8a72656d35b9cb358973afbbd9c130164a7b05
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 17 Apr 2013 14:52:48 +0800
Tag:    v2.5.0-rc1

MDL-39185 mod_forum: declare new object before creating member variables to prevent Strict Standards warning

commit 12cb45f19903b858e64c777e1e21f61437c09746
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 15 Apr 2013 15:28:28 +0800
Tag:    v2.5.0-rc1

MDL-39047 forms: set the z-index of the calendar pop-up so that it renders above the filemanager

commit 1711361042817bec43fb57173146347b91b0c451
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 10 Apr 2013 11:18:17 +0800
Tag:    v2.5.0-rc1

MDL-26649 forms: ensure that both necessary variables are set before altering calendar image

commit c517765430343665b766e752b0fe97b846f0f8dd
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 05 Apr 2013 17:10:43 +0800
Tag:    v2.5.0-beta

MDL-35073 badges: passed the session key in the enable access URL

commit f40df210ab1d41402ba77677663ca3eabd6b98ae
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 04 Apr 2013 15:33:16 +0800
Tag:    v2.5.0-rc1

MDL-26649 forms: added a calendar icon that will display the calendar pop-up when clicked rather than the select boxes triggering the event

commit 5fb496743f1c24369356eafec390ba9147202ede
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 26 Feb 2013 11:54:11 +0800
Tag:    v2.5.0-beta

MDL-31557 install: removing PREVIOUS and NEXT attributes from install.xml for newly introduced index

commit 8076010d3791c323b565a5b5b1c73c6262a9df89
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 11 Feb 2013 11:51:41 +0800
Tag:    v2.5.0-beta

MDL-37953 mod_forum: using named parameters to build SQL statement

commit 9a9cb74118ca0b99e511d560e1c0e56406ac49b2
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 05 Feb 2013 15:19:42 +0800
Tag:    v2.5.0-beta

MDL-37654 core_course: ensure exceptions return static error codes for debugging purposes

commit 17222a4a25a3243f8e8da69997986ab751a09ec1
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 05 Feb 2013 11:57:03 +0800
Tag:    v2.5.0-beta

MDL-37854 phpunit: replaced occurrence of non-existent function assertFail

commit df7d171fc35bda038f7456e592b34762f72f9ad8
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 04 Feb 2013 11:09:56 +0800
Tag:    v2.5.0-beta

MDL-37518 blocks: described the introduction of the myaddinstance capability in upgrade.txt

commit 93cc145f885bdcb19845966025b70e49c9ea16c4
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 23 Jan 2013 15:48:50 +0800
Tag:    v2.5.0-beta

MDL-37082 core_course: include details of deprecation in the upgrade.txt file

commit 18aaeef0b676d993a2a501b39c89dfa73f031757
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 23 Jan 2013 14:25:02 +0800
Tag:    v2.5.0-beta

MDL-37082 mod_assign: removed reference to deprecated delete_course_module function in the unit tests

commit d44862568241972641ea4288abe9d7e0d1152860
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 18 Jan 2013 14:14:40 +0800
Tag:    v2.5.0-beta

MDL-37414 blocks: re-added the ability to add some blocks to the My Moodle

commit e06bfd3df3b04c9b390b1fd4e4d768661e61cf75
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 15 Jan 2013 18:15:14 +0800
Tag:    v2.5.0-beta

MDL-35924 filemanager: added label for the input field when creating a new folder

commit 7e5be0744cd92994001110096b51fd7aa89911db
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 15 Jan 2013 17:03:00 +0800
Tag:    v2.5.0-beta

MDL-36104 mod_assign: added hidden labels to the feedback input fields

commit 26741e3e2f3f4950c555ed64833cc45e043d2ad2
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 15 Jan 2013 14:09:50 +0800
Tag:    v2.5.0-beta

MDL-37275 webservices: ensure a webservice function is chosen before attempting to add to service

commit 941294ef435aee715edb5b87be1615bff897dc49
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 10 Jan 2013 17:15:51 +0800
Tag:    v2.5.0-beta

MDL-36741 mod_forum: fixed the function forum_rss_newstuff that was using count_records_sql incorrectly as well as generating RSS content when no data exists

commit faf3016f353d1083767605fc713d9f9832c7d9d9
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 10 Jan 2013 13:32:33 +0800
Tag:    v2.5.0-beta

MDL-37247 mod_forum: removing unnecessary variable in the get_forums web service

commit 0c246ae5d9f5338f943c74fcd4dde5a7e0d6ca43
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 10 Jan 2013 12:43:39 +0800
Tag:    v2.5.0-beta

MDL-37247 mod_forum: perform conditional checks before returning forums via web service

commit 9e222bac613d8f5a2c2833023d56fc68a0fdd73f
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 04 Jan 2013 15:23:12 +0800
Tag:    v2.5.0-beta

MDL-37359 groups: fixing typo in the web service function create_groupings_parameters

commit a9a0cb691c5eb812f9427d44af07140defc54b8a
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 04 Jan 2013 11:49:51 +0800
Tag:    v2.5.0-beta

MDL-30102 mod_forum: adding webservice function to allow for the retrieval of forum discussions

commit 79949c1ba3289b15bfa2fb45d1275cd9fa36cc8a
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 12 Dec 2012 13:08:03 +0800
Tag:    v2.5.0-beta

MDL-30098 core_course: adding webservice functions to allow the deletion of module instances

commit 2b9fe87dcad443f799e6f19ab59209ea6792a5b4
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 12 Dec 2012 13:08:03 +0800
Tag:    v2.5.0-beta

MDL-37247 mod_forum: adding webservice function to allow for the retrieval of forum instances

commit a347aee32ea14f05ea7572b97684a52c90120556
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 10 Dec 2012 17:33:09 +0800
Tag:    v2.5.0-beta

MDL-37082 core_course: create new course_delete_module function that handles the whole deletion process

commit bfe20414c0669b8e89153d11323ebdaa30eb1430
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 29 Nov 2012 14:12:58 +0800
Tag:    v2.5.0-beta

MDL-36455 blocks: removed ability to add blocks to the My Moodle page that did not make sense in that context

commit 5fe65fd4382f1f3975c46902a6c380abdf7a2f70
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 23 Nov 2012 16:58:35 +0800
Tag:    v2.5.0-beta

MDL-36741 mod_forum: fixed SQL that was generated when either timed posts or groups were enabled

commit c2aad61661b37d2b753f5fa22958a8bacfa1169a
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 21 Nov 2012 16:54:58 +0800
Tag:    v2.5.0-beta

MDL-35954 javascript: prevent JS from being triggered on select box by clicking on already selected option

commit cba235594a0ab4e5aa2583ff58845aa1424d8dea
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 20 Nov 2012 16:28:52 +0800
Tag:    v2.5.0-beta

MDL-29334 mod_data: if site-wide presets created in <= 1.9 exist convert them to 2.x