Git commits in Moodle 1.9.x by Piers Harding

commit 35332cda8e97cd2ae3e36d5227756f176e0f135c
Author: Piers Harding <piers@ompka.net>
Date:   Fri, 09 Jul 2010 02:15:10 +0800
Tag:    v1.9.10

MDL-19442 - fix type cast of values for gradebook calculations

commit b6ec0e79401db7af755e16d1ba60a0360d8744b2
Author: Piers Harding <piers@ompka.net>
Date:   Mon, 28 Jun 2010 06:13:47 +0800
Tag:    v1.9.10

MDL-21761 - fix the statefulness of saving dataelements in scorm api 1.2

commit b34b5c7b498caf6ca908dcf62f651b5e0ad116fe
Author: Piers Harding <piers@ompka.net>
Date:   Wed, 10 Feb 2010 01:50:52 +0800
Tag:    v1.9.8

MDL-18202 - fix incorrect substitutions of '_'.

commit 753d8d6b8f80d4784bace8710012a1ccfba768c9
Author: piers <piers>
Date:   Tue, 03 Mar 2009 08:21:26 +0900
Tag:    v1.9.5

MDL-18412 - fixed incorrect config var name. thanks Anthony.  backport 1.9.

commit 6323f16bcebf37581da70c2fc6ae3816f3ca201f
Author: piers <piers>
Date:   Fri, 27 Feb 2009 00:52:56 +0900
Tag:    v1.9.5

MDL-18148 - AICC compliance fixes from Martin Holden.

commit 33edb1d07987879a36cfa5f701973aa9f22e2c77
Author: piers <piers>
Date:   Thu, 26 Feb 2009 08:06:35 +0900
Tag:    v1.9.5

MDL-18212 - switch to addslashes_js - thanks Tim.  Backport 1.9.

commit fd50629bd08080e1f3a945e66430a039a2730d09
Author: piers <piers>
Date:   Thu, 05 Feb 2009 03:59:53 +0900
Tag:    v1.9.5

MDL-17832 - consistent adding and removing of slashes for track data. backport 1.9.

commit 59fc418b730eb3994bbd54705455e89a96b13de5
Author: piers <piers>
Date:   Thu, 05 Feb 2009 03:40:09 +0900
Tag:    v1.9.5

MDL-18023 - add type check to check against default to avoid 0 error. backport 1.9.

commit fc85b7977f548102205b7cc757727c6dd1420932
Author: piers <piers>
Date:   Tue, 03 Feb 2009 07:09:29 +0900
Tag:    v1.9.5

MDL-17498 - fix grading output for submissions.

commit 5893fbd8e1fe6290f28dd5f48982d501a916c0e1
Author: piers <piers>
Date:   Thu, 29 Jan 2009 03:16:18 +0900
Tag:    v1.9.5

MDL-16184 - patch to correct the calculation of first, and last access to a SCORM attempt. backport to 1.9. + missing php tag in debug.

commit e6dcae98fabc73ce972302f0343f1160221052d7
Author: piers <piers>
Date:   Thu, 29 Jan 2009 03:14:57 +0900
Tag:    v1.9.5

MDL-17821 - fix incorrect data validation regexs for 2004. thanks Peter Chamberlin. backport to 1.9.

commit 7eea186ea0be6a681d7ec4c2aa685c0441bf9d86
Author: piers <piers>
Date:   Wed, 10 Dec 2008 07:03:01 +0900
Tag:    v1.9.4

MDL-17572 - remove php short tags. backport to 1.9.

commit 374b0f29cdc1024371948e527cbb1b53a9052681
Author: piers <piers>
Date:   Mon, 08 Dec 2008 07:15:24 +0900
Tag:    v1.9.4

MDL-17115 - SCORM onload API checking. Hunt for the API. backport 1.9.

commit 383570242d589e3aaea7708338e7aef8aa23e373
Author: piers <piers>
Date:   Thu, 04 Dec 2008 12:26:24 +0900
Tag:    v1.9.4

MDL-17310 - Fixup an issue with relative directory paths. Thanks Jonathan. backport 1.9.

commit b645325d9898855c9abc507efa83e39dc18ac523
Author: piers <piers>
Date:   Wed, 03 Dec 2008 14:59:11 +0900
Tag:    v1.9.4

MDL-17498 - fix postgres compatibility on recent activity block integration, correct recent activity links to trigger actual assignments.  Lots of whitespace fixing.

commit d45250b5314741db2ec7407a84c0ff37e73607b5
Author: piers <piers>
Date:   Sun, 30 Nov 2008 02:56:43 +0900
Tag:    v1.9.4

MDL-16651 - add in delete attempt capability - thanks Dan/Tim. backport 1.9.

commit 4df7f4237e71c02c11682978cfb6093dec1863c2
Author: piers <piers>
Date:   Mon, 24 Nov 2008 06:41:40 +0900
Tag:    v1.9.4

MDL-17310 - take the opportunity to change the scorm defaults to a highest grade orientation. backport to 1.9.

commit 9e7f70ddab30c956821ae8822603d6c151426d9d
Author: piers <piers>
Date:   Fri, 14 Nov 2008 09:14:49 +0900
Tag:    v1.9.4

MDL-16810 - Allow site configuration of scorm settings. Thanks Jason Hardin.  Backport 1.9.

commit b40bf0bf5880a841a562c63f1fe4b49ed44fda3f
Author: piers <piers>
Date:   Fri, 14 Nov 2008 09:06:22 +0900
Tag:    v1.9.4

MDL-16949 - fix wrong addition of times in SCORM API, thanks Xabi Martin. backport 1.9.

commit 2bb6c9fbe492cea5fe95ec72a5082d09e0366c64
Author: piers <piers>
Date:   Mon, 10 Nov 2008 07:39:20 +0900
Tag:    v1.9.4

MDL-17178 - fix grade update so that it happens both when the lesson status, and the score changes. Backport to 1.9. Fix bad debug statement in code (sorry).

commit 172e3b12a2a2a49d1508976fcf7d85723c2f6099
Author: piers <piers>
Date:   Mon, 10 Nov 2008 07:33:12 +0900
Tag:    v1.9.4

MDL-17178 - fix grade update so that it happens both when the lesson status, and the score changes. Backport to 1.9.

commit fc89ab243345fa0ea37d2da516346c3ceabbad6d
Author: piers <piers>
Date:   Sat, 01 Nov 2008 07:59:17 +0900
Tag:    v1.9.4

MDL-7068 - SCORM 2004 compliance - fix mod/scorm to handle core data elements correctly - now passes test DMI.  backport 1.9.

commit 10610a60bc71df5d0dbb104fc8fb9c9422aba7bd
Author: piers <piers>
Date:   Thu, 30 Oct 2008 01:15:03 +0900
Tag:    v1.9.4

MDL-17052 - remove use of $_POST. backport to 1.9.

commit 8dab4c6a9e703f1512e740b475b470a955d479af
Author: piers <piers>
Date:   Tue, 14 Oct 2008 12:42:06 +0800
Tag:    v1.9.3

MDL-16810 - fix typo on function name. thanks to Jason Hardin.  Backport to 1.9.

commit 705154d96f47406caaf7e8032eb1ee5ecf009268
Author: piers <piers>
Date:   Fri, 26 Sep 2008 08:35:10 +0800
Tag:    v1.9.3

MDL-7068 - SCORM 2004 compliance.  Handle cmi.interactions hydration (scorm 1.2 to as well).  Backport to 1.9 - rerun compliance test.

commit 372c1dd2d7a647b60f70e49e4340ffa63341b634
Author: piers <piers>
Date:   Wed, 17 Sep 2008 10:11:46 +0800
Tag:    v1.9.3

MDL-7097 - API debug. Add ability to manually poke the SCORM API for 1.2 and 2004. backport 1.9.

commit e1a609c888ded5edad0499293f4f6c20bbba90ba
Author: piers <piers>
Date:   Tue, 09 Sep 2008 03:50:24 +0800
Tag:    v1.9.3

MDL-11734 - cmi.comments_from_learner not read - write.  revamp the handling of array style elements. Backport to 1.9.

commit c1d74923f8cb55c067398d8dda6a8e60b5bdae0a
Author: piers <piers>
Date:   Mon, 08 Sep 2008 08:34:12 +0800
Tag:    v1.9.3

MDL-16299 - Javascript error during scorm player load.  SCOID should not be populated - TOC figures this out. Backport to 1.9.

commit d6e017d51347f1b194dddc234e3a81b3894608cd
Author: piers <piers>
Date:   Wed, 03 Sep 2008 08:41:14 +0800
Tag:    v1.9.3

MDL-16299 - Javascript error during scorm player load.  Ensure SCOID is always populated.  Backport 1.9.

commit 3318cc4ecfd863101552fe1f2729a8eca01eda11
Author: piers <piers>
Date:   Fri, 29 Aug 2008 12:13:35 +0800
Tag:    v1.9.3

MDL-14492 - Provide feedback to user about redirect delay in loadsco.php.  Add sanity checking for scorm_resize() as it tries to set -ve heights if user specifies a small area. Thanks francois.  backport 1.9.

commit bc6931c744c4f179cd37a779292aeee6812d8cf7
Author: piers <piers>
Date:   Thu, 28 Aug 2008 07:27:07 +0800
Tag:    v1.9.3

MDL-4746 - Course 01 of the ADL SCORM 1.2 test suite fails on point 4.  only set browsed status if the SCO hasn't set a status.  Backport 1.9.

commit c12b948bf2f7cd4946d0350864b132862049feb6
Author: piers <piers>
Date:   Wed, 27 Aug 2008 12:06:31 +0800
Tag:    v1.9.3

MDL-4746 - Course 01 of the ADL SCORM 1.2 test suite fails on point 4.  gramatical error - thanks Dan. Backport 1.9.

commit 65edfe910a5fcdfcfe138c9f8a9285fb1c13d50f
Author: piers <piers>
Date:   Wed, 27 Aug 2008 10:50:08 +0800
Tag:    v1.9.3

MDL-4746 - Course 01 of the ADL SCORM 1.2 test suite fails on point 4.  Fix cmi.comments, and mastery_score checking.  Backport to 1.9.

commit def69699442e4eecd93be7356a5dc9f912ceaa43
Author: piers <piers>
Date:   Mon, 25 Aug 2008 07:03:40 +0800
Tag:    v1.9.3

MDL-15881 - Probable bug: Not able to update SCORM.  Backport 1.9.

commit 7e51170aec645608710b3b84773327598fd2fba5
Author: piers <piers>
Date:   Mon, 25 Aug 2008 05:13:02 +0800
Tag:    v1.9.3

MDL-16111 - SCORM grade not updated in Grader Report.  Include grading by learning objects if status is complete.  Backport to 1.9.

commit 5a3e0c81e76e8fd5002ddda3210c04b078b749b5
Author: piers <piers>
Date:   Fri, 22 Aug 2008 11:21:52 +0800
Tag:    v1.9.3

MDL-16111 - SCORM grade not updated in Grader Report. Make sure that lastattempt does not exceed maxattempts.  Backport 1.9.

commit cf42577a41f7b44912ff84ab521ddf91bef063d3
Author: piers <piers>
Date:   Fri, 22 Aug 2008 09:38:37 +0800
Tag:    v1.9.3

MDL-13431 - SCORM results not transferring to Gradebook.  SCORM API debugging tool - add reference to SCORM, and SCO identifier. backport 1.9.

commit cd74712f303ec478ab538c81c61f56232db989dc
Author: piers <piers>
Date:   Thu, 21 Aug 2008 16:30:58 +0800
Tag:    v1.9.3

MDL-13431 - SCORM results not transferring to Gradebook.  SCORM API debugging tool. Backport to 1.9.  remove add_to_log.

commit c11ccc62f3dd25338b7e46952e10307f20acdc56
Author: piers <piers>
Date:   Thu, 21 Aug 2008 11:16:11 +0800
Tag:    v1.9.3

MDL-16111 - SCORM grade not updated in Grader Report. Thanks John Macklin. Backport 1.9.

commit 2753d9448fe0cb343f4cb0dd33c2ec32f56d24a9
Author: piers <piers>
Date:   Thu, 21 Aug 2008 08:39:57 +0800
Tag:    v1.9.3

MDL-13431 - SCORM results not transferring to Gradebook.  SCORM API debugging tool. Backport to 1.9.

commit 881e78daa2b9aeb5e812abf322d8832f48a7a3b7
Author: piers <piers>
Date:   Thu, 21 Aug 2008 08:36:12 +0800
Tag:    v1.9.3

file debug.js.php was added on branch MOODLE_19_STABLE on 2008-08-21 00:39:57 +0000

commit 604c88975caedc58d5cecdc58c7a7e5a026748bd
Author: piers <piers>
Date:   Thu, 21 Aug 2008 07:31:37 +0800
Tag:    v1.9.3

MDL-13431 - SCORM results not transferring to Gradebook.  Add logging mechanism so that launched URI can be traced. Backport 1.9.

commit ff915d60568ae0fb2d9c56dbaeda0e0ee0500cb3
Author: piers <piers>
Date:   Thu, 21 Aug 2008 07:06:37 +0800
Tag:    v1.9.3

MDL-15859  [PATCH] Fixes for tests of '' on Oracle. Backport 1.9.

commit 88ba1fda5e7e90b75356169a8d1afd8ef5bf8202
Author: piers <piers>
Date:   Thu, 21 Aug 2008 06:32:19 +0800
Tag:    v1.9.3

MDL-13431 - SCORM results not transferring to Gradebook.  Add logging mechanism so that SCORM API interaction with Moodle can be traced.  Backport 1.9.

commit 27fb07f87b95906f227ba0a7aaec5aaad46bc8bf
Author: piers <piers>
Date:   Thu, 21 Aug 2008 06:29:33 +0800
Tag:    v1.9.3

MDL-13431 - SCORM results not transferring to Gradebook.  Use the correct method for getting the course object.  Backport 1.9.

commit c073b133a41b1db1a8a4af2da5842bf88cc3ca85
Author: piers <piers>
Date:   Fri, 15 Aug 2008 09:09:26 +0800
Tag:    v1.9.3

MDL-13904 Scorm structure isn't respected after an update of the package.  Incorrectly named table in a delete. backport 1.9.

commit 45477f2cc04e3ca04c2831478b4de3c1f300cd84
Author: piers <piers>
Date:   Fri, 15 Aug 2008 08:18:11 +0800
Tag:    v1.9.3

MDL-16055 PHP warning when creating new scorm activity.  backport 1.9.

commit 4c15e91188241a29e9092486a1c50aa8fdd6c570
Author: piers <piers>
Date:   Thu, 14 Aug 2008 06:47:33 +0800
Tag:    v1.9.3

MDL-13904 Scorm structure isn't respected after an update of the package.  This is a large change to the handling of SCORM package update - all SCOes are issued with a new id, and all references to the old ones are deleted.  The scorm_scoes_track data is preserved by being reattached to the new SCO ids (unless they have been deleted).  backport to 1.9.

commit 8b074482155ad3a02de27bc689e57cd02adb5c88
Author: piers <piers>
Date:   Thu, 14 Aug 2008 06:40:24 +0800
Tag:    v1.9.3

MDL-11188 SCORM module does not respect "prerequisites" like it used to. MDL-12342 & signs in CDATA sections are imported as &amp;.  This is a rewrite of the prerequisite handling. backport to 1.9.

commit b79105c4a2afd1a9d290f69f465381153ea97880
Author: piers <piers>
Date:   Thu, 14 Aug 2008 06:28:03 +0800
Tag:    v1.9.3

MDL-14492 Provide feedback to user about redirect delay in loadsco.php.  Add lang text for please wait.  backport 1.9.

commit c0b72b725ccc4232b0d3d802c2b091007c9f30bc
Author: piers <piers>
Date:   Mon, 11 Aug 2008 06:33:49 +0800
Tag:    v1.9.3

MDL-14492 Provide feedback to user about redirect delay in loadsco.php.   backport to 1.9.

commit d86a0382dedc99d53e940bead83a2d61c1342d38
Author: piers <piers>
Date:   Thu, 07 Aug 2008 07:52:27 +0800
Tag:    v1.9.3

MDL-10425 and MDL-12872 Firefox bugs String() handling on replace. enhanced rege xfor CMI data types. MDL-8193  Incorrect handling of quotes in SetValue processing - recoded so that it escapes all values passed from tracks. backport to 1.9.

commit ec88010b2ee7e8e7a8577d540cbe6387f3451a30
Author: piers <piers>
Date:   Wed, 06 Aug 2008 13:06:00 +0800
Tag:    v1.9.3

MDL-15950 MDL-15640 MDL-15943  - SCORM player.php not inserting footer, Showing SCORM participation report. (thanks Urs Hunkler and Mitsuhiro Yoshida). Warning are displayed in a SCORM activity (thanks Dan). Backport to 1.9.

commit e0aa018ccfde8e439021cedc32922baebee24f6d
Author: piers <piers>
Date:   Mon, 04 Aug 2008 06:17:16 +0800
Tag:    v1.9.3

MDL-14457 SCORM module creating extra windows when opening module in a new window. Backport to 1.9 (thanks Jo Matthews).

commit 5b3e0dd9638ab77758b9a4b4dbafd829d865bfe1
Author: piers <piers>
Date:   Fri, 01 Aug 2008 12:30:45 +0800
Tag:    v1.9.3

MDL-14902 Missing column 'whatgrade' in prefix_scorm table.  Is a DB patch  (thanks Hans de Zwart). backport 1.9.

commit 2e11eb2feddf9ab419d729ad1d9adee51486dd6e
Author: piers <piers>
Date:   Fri, 01 Aug 2008 06:31:04 +0800
Tag:    v1.9.3

MDL-15899 JavaScript error In IE7 when opening SCORM content in a new window.  Fix spaces in popup name for fussy IE. backported to 1.9.

commit 251b51c94800baf77a9a6e0e3696f464950599ec
Author: piers <piers>
Date:   Tue, 29 Jul 2008 09:25:20 +0800
Tag:    v1.9.3

MDL-9378 New visualisation for SCORM - modify CSS class names to make them more specific. sorry to commit so close to review day, just fixing a regression - 1.9.

commit 8334db6c52d11a5695c18b168688a325d4bb2d50
Author: piers <piers>
Date:   Tue, 29 Jul 2008 06:42:57 +0800
Tag:    v1.9.3

MDL-11892 JavaScript error on SCORM tree list - bapckport to 1.9 for AICC.

commit 58afb04bc73227a5a16cf3ab3e9a6794b97fee95
Author: piers <piers>
Date:   Mon, 28 Jul 2008 08:44:49 +0800
Tag:    v1.9.3

MDL-9378 New visualisation for SCORM - back ported to 1.9.

commit 17b03a93104b56ffc1e3cf38161e1e8625fa1eb4
Author: piers <piers>
Date:   Mon, 28 Jul 2008 05:23:26 +0800
Tag:    v1.9.3

MDL-11137 Unable to locate API error - add check for empty array from DB interface (ksort complains) - backport to 1.9.

commit 8fdfb20a90dd7d1b13bcee992cf4cf5305c43ba2
Author: piers <piers>
Date:   Fri, 25 Jul 2008 10:32:38 +0800
Tag:    v1.9.3

MDL-11137 Unable to locate API error - remove comment code with bad characters. backport to 1.9.

commit bf3fc937f64a0a28a38e85804c7c0b0b4bc057b8
Author: piers <piers>
Date:   Fri, 25 Jul 2008 09:48:36 +0800
Tag:    v1.9.3

MDL-11137 Unable to locate API error - force a sort order on the cmi elements, and ensure correct type comparison when determining whether we have seen this objective id before.  affects aicc, 1.2 and 1.3. propagate to 1.9.

commit 61e8fd6d8a39638c00be4414e96ee494c49d139b
Author: piers <piers>
Date:   Thu, 24 Jul 2008 09:40:35 +0800
Tag:    v1.9.3

MDL-9077 switch from client to server side validation for reference field as client side not supported for this type (file upload name) - propogate to 1.9.

commit 340d23ab2ff4954858e8877108c82c9f9d414fb3
Author: piers <piers>
Date:   Thu, 24 Jul 2008 09:16:12 +0800
Tag:    v1.9.3

MDL-7323 AICC Import does not handle Core_Vendor + remove tabs and ambiguous else - propogated to 1.9.

commit db376fdb425ba7e3d38c97ddeb473ecf9ee96393
Author: piers <piers>
Date:   Fri, 18 Jul 2008 14:27:12 +0800
Tag:    v1.9.3

MDL-11892 Propogate Fixes for 'calls to expand javascript' to SCORM 1.2, and 1.3 code.