Git commits in Moodle 1.9.2 by jamiesensei

commit dcb16152f31e69cb43d336e22dd1b02dda381f74
Author: jamiesensei <jamiesensei>
Date:   Fri, 04 Jul 2008 17:48:01 +0800
Tag:    v1.9.2

MDL-15530 "The Group menu in Quiz Module no longer works as before: all students are displayed regardless of what group is chosen" 'all attempts' mode for report is now disabled when a group is selected.

commit 696d84554d0fa29eb6d1e6ebb38793dfaa4de22c
Author: jamiesensei <jamiesensei>
Date:   Tue, 01 Jul 2008 19:39:09 +0800
Tag:    v1.9.2

MDL-15490 "Create a new Quiz: warning message in Result tab" problem was when there were no students in a course - fixed.

commit 78eabcc29d599c5280d32b4c1240ae8d18d96174
Author: jamiesensei <jamiesensei>
Date:   Mon, 30 Jun 2008 19:52:47 +0800
Tag:    v1.9.2

MDL-15198 "non-standard sql in reportlib.php" fixed this with new sql that does not require a limit clause.

commit ac625ae9227146dc18fc6533f1825b68f32c8876
Author: jamiesensei <jamiesensei>
Date:   Tue, 24 Jun 2008 20:31:28 +0800
Tag:    v1.9.2

MDL-15309 "Switch role to student, take quiz, can't delete attempt" switching default of overview report to show all attempts whether or not the attempt is for a currently enrolled student.

commit f32aa45ef46e935b5f5a316acc6abadb43347236
Author: jamiesensei <jamiesensei>
Date:   Tue, 24 Jun 2008 20:18:16 +0800
Tag:    v1.9.2

MDL-15378 "Quizz: sql error if not student in the group" now have extra logic to not display the table if there are no students at all or in current group - still displaying form and graph were appropriate.

commit 29e3105632bf213a6971a68f1cc6f51dab872fc7
Author: jamiesensei <jamiesensei>
Date:   Sun, 22 Jun 2008 21:01:39 +0800
Tag:    v1.9.2

Fixing typo introduced in 1.282.2.14 version of this file.

commit 1c215c8bced34f0add7ce82a2b9a5cb27bf3da6b
Author: jamiesensei <jamiesensei>
Date:   Thu, 19 Jun 2008 23:19:17 +0800
Tag:    v1.9.2

MDL-15165 "Essay quiz Manual grading "these are no attempts to show" when there are actually attempts" - not resolved. But while reviewing the query I found a LIMIT clause in sql that I've replace with params to the get_records_sql function. Also made the logic in attempt_sql method more robust.

commit e05eb943d0857b36adfa5d6d5209558b27f8df67
Author: jamiesensei <jamiesensei>
Date:   Thu, 19 Jun 2008 20:31:28 +0800
Tag:    v1.9.2

MDL-15264 "Bar graph image missed when group with no attempts selected" added a query to check for sure that there are some grades there to display in the graph. Also now displaying grades for all groups a user has permission to view - but only if that is up to 4 groups and only if there are less than 500 grades total.

commit 1be3ce4510f40f4451d36ca2d8b70611f2d15301
Author: jamiesensei <jamiesensei>
Date:   Fri, 13 Jun 2008 20:46:54 +0800
Tag:    v1.9.2

MDL-15224 "Overview results in quiz module export to excel and txt fail"  Fixed.

commit f5d47e36f18137ee83eef6714a1617149ce0b7a2
Author: jamiesensei <jamiesensei>
Date:   Tue, 10 Jun 2008 15:45:22 +0800
Tag:    v1.9.2

MDL-14821 "Quiz: report overview page is not XHTML compliant" wrapped hidden form params in div with style 'display:none'.

commit 012de02b6458f46924d0c663b4cdcc8a342097df
Author: jamiesensei <jamiesensei>
Date:   Sat, 07 Jun 2008 20:58:34 +0800
Tag:    v1.9.2

MDL-14821 "Quiz: report overview page is not XHTML compliant" gave the fieldsets in the form different names to avoid html id attribute conflict.

commit a92741f2d27ef8f6f605820a801203df0b422f65
Author: jamiesensei <jamiesensei>
Date:   Fri, 06 Jun 2008 20:24:17 +0800
Tag:    v1.9.2

MDL-15092 "Quiz overview report won't display if there are more than 29 questions" Small fixes in logic to do with sorting.

commit 6713e60db7c2cf1368b7a64f090d36137aee278e
Author: jamiesensei <jamiesensei>
Date:   Fri, 06 Jun 2008 19:08:58 +0800
Tag:    v1.9.2

MDL-15150 "Quiz Report broken in course without students" added warning message if there are no students in course yet.

commit 5b598e9e5db15ab53efee2425904890026194367
Author: jamiesensei <jamiesensei>
Date:   Thu, 05 Jun 2008 19:12:58 +0800
Tag:    v1.9.2

MDL-14223 "Add a column for the user's idnumber, controllable by a site-wide setting" adding idnumber to the list of columns that is 'suppressed' ie that is only printed once when the same data is repeated in consecutive rows.

commit 5bc700de54fc7d2d154a5b052de96a6624d6f5ec
Author: jamiesensei <jamiesensei>
Date:   Thu, 05 Jun 2008 14:12:26 +0800
Tag:    v1.9.2

MDL-15092 "Quiz overview report won't display if there are more than 29 questions" fixed this by going back to the old way of fetching data for display in the table. However still use table JOINs when user wants to sort by question grade. The user can sort by a maximum of two columns at once so the JOINs will not exceed the limit.

commit b536544e34b12ad941c46db0b1b1d12f4a943953
Author: jamiesensei <jamiesensei>
Date:   Fri, 30 May 2008 20:22:20 +0800
Tag:    v1.9.2

MDL-15047 "Quiz overview report download is broken - patch" fixed.

commit 49814438b9fbe744301c92616c7026852a88c12e
Author: jamiesensei <jamiesensei>
Date:   Thu, 29 May 2008 22:31:30 +0800
Tag:    v1.9.2

MDL-15011 "grading report : allow user to select to grade next 10 ungraded attempts" added a new link and options to the grading report page to display only the next 10 ungraded attempts to grade. Also some fixes for faulty sql for ungraded option which was not respecting the users groups selection.

commit e86d81b3ca90d0b4189fb2a8a395cd2469bcd3e6
Author: jamiesensei <jamiesensei>
Date:   Mon, 26 May 2008 22:24:51 +0800
Tag:    v1.9.2

MDL-15002 "grading report : notice from quiz_num_attempt_summary about how many total attempts there are on the quiz and how many in this group would make UI clearer" added call to function and fixed centering of notice on overview and grading report by adding a clear:left to stop the centering being affected by the groups menu.

commit cec3911dd44d57547201205f94e519e7dcf0141e
Author: jamiesensei <jamiesensei>
Date:   Mon, 26 May 2008 21:23:14 +0800
Tag:    v1.9.2

MDL-12824 "Essay type of quiz questions needs to color mark which students have been graded and which have NOT"

commit 9607206c715311a7edb43bd4400c323b1fd458e0
Author: jamiesensei <jamiesensei>
Date:   Mon, 26 May 2008 20:06:19 +0800
Tag:    v1.9.2

MDL-12824 "Essay type of quiz questions needs to color mark which students have been graded and which have NOT"

commit 4c3332efffb37aa9319463723b6eb41ee2e60bf8
Author: jamiesensei <jamiesensei>
Date:   Mon, 26 May 2008 19:47:00 +0800
Tag:    v1.9.2

MDL-15000 "Moodle url method remove_params doesn't actually remove anything" Fixed.

commit 89bc941b70d37eea2cee4a2c6046ad6508b5001b
Author: jamiesensei <jamiesensei>
Date:   Mon, 26 May 2008 17:01:30 +0800
Tag:    v1.9.2

MDL-14988 "tables have been hardcoded with a prefix of "mdl" - causing an error." Ooops!

commit 7e8b311075f1366b8105830dac54bb64ab4c8cf6
Author: jamiesensei <jamiesensei>
Date:   Sun, 25 May 2008 19:46:12 +0800
Tag:    v1.9.2

MDL-5241 "When manually grading, identity questions by their number within the quiz as well as by question name" Ooops. Accidentally introduced a bug during refactoring and reworking of UI code. I added gradeall links to the table whether or not there were attempts to grade, have fixed this now.

commit 3a83ce8b5dc7d23e5b27ed4dc4afd126eedbfaac
Author: jamiesensei <jamiesensei>
Date:   Sun, 25 May 2008 19:35:29 +0800
Tag:    v1.9.2

MDL-5241 "When manually grading, identity questions by their number within the quiz as well as by question name"

commit 30146912789ab9165ebd066d4f1d3ed200908ef4
Author: jamiesensei <jamiesensei>
Date:   Fri, 23 May 2008 21:00:47 +0800
Tag:    v1.9.2

MDL-12547 "allow manual quiz grading to sort by groups" added code to select which group to grade.

commit 57fb427c9be0467915ec4cc7f6c9d1acdc9ceb52
Author: jamiesensei <jamiesensei>
Date:   Thu, 22 May 2008 17:18:03 +0800
Tag:    v1.9.2

MDL-14943 "moodle_url : need way to add extra params when outputting params as hidden fields for forms" added new optional param to method hidden_params_out

commit 34ccb459a67275777132abc4b28ae872f1d5908a
Author: jamiesensei <jamiesensei>
Date:   Fri, 16 May 2008 22:44:05 +0800
Tag:    v1.9.2

MDL-14844 "Quiz Report: Bar Graph doesn't displayed maximum grade" Reverting accidentally committed changes to this file which where committed as part of the fix for MDL-14844

commit fdc1036f0eaf0bcdcfef61dec20b39df38577e8d
Author: jamiesensei <jamiesensei>
Date:   Fri, 16 May 2008 22:39:02 +0800
Tag:    v1.9.2

MDL-14844 "Quiz Report: Bar Graph doesn't displayed maximum grade" Now using php ceil function to round up $bands as in some cases it could be a non integer.

commit 01676c49a3f1ae22c7a0e157c44ce1f1660e04bd
Author: jamiesensei <jamiesensei>
Date:   Thu, 15 May 2008 21:55:49 +0800
Tag:    v1.9.2

MDL-14852 "improve sql in overview report for fetching question grades" moved all querying for question grades into main attempts sql query. AND MDL-14200 "Add group and course averages" some fixes for functionality to display question grades averages. Grade averages are not displayed when grading method is set to Average - as this cannot be done in sql and would be expensive to do in memory.

commit 05289910b7a63c93764009bad39ee12e2122fbb0
Author: jamiesensei <jamiesensei>
Date:   Thu, 15 May 2008 20:52:56 +0800
Tag:    v1.9.2

MDL-14200 "Add group and course averages" fix for bug introduced in this patch. We are now using a seperate sql command to get the feedback text as we need to get it for the average rows too. Since it is not part of the sql to fetch attempt data we can't sort on Feedback anymore so removed the option from the table. Sorting by feedbacktext is not really useful anyway, users are more likely to want to sort by grade.

commit 574682636428d4b2668ade9bc61e576b8bbff790
Author: jamiesensei <jamiesensei>
Date:   Thu, 15 May 2008 20:25:04 +0800
Tag:    v1.9.2

MDL-14200 "Add group and course averages" added extra rows to the end of the table in quiz overview report also MDL-14187 "Improve tablelib - improve api and add functionality to download table contents in a variety of formats - XLS, ODS and CSV" implemented the first of my proposals for improving tablelib. Added a extra method to use keyed arrays to add a row to a table. Seems obvious that this is an improvement to tablelib and it is an addition to the API so won't affect existing code.

commit 316d595389e0f4cf1e64103b1aac385e0f19a887
Author: jamiesensei <jamiesensei>
Date:   Thu, 15 May 2008 18:40:58 +0800
Tag:    v1.9.2

MDL-14844 "Quiz Report: Bar Graph doesn't displayed maximum grade" added perfect grade to last  'band' on graph.