Git commits in Moodle 1.9.0 by tjhunt

commit f1543152662ae38ae19e8fde7f595271ad134788
Author: tjhunt <tjhunt>
Date:   Sat, 01 Mar 2008 01:22:13 +0900
Tag:    v1.9.0

MDL-13738 - Invalid context developer debug notice in manual grading.

commit 078c8b402ba24917736cd35df74d59754a5bad9f
Author: tjhunt <tjhunt>
Date:   Fri, 29 Feb 2008 07:44:10 +0900
Tag:    v1.9.0

MDL-12776 - Quiz email notification and separate groups mode - student not in group -> all teachers get email

I have changed it so that if the quiz is set to groups mode, and if the student is not in a group, then only teachers with 'accessallgroups' get emailed.

commit 0a22085fdbcf3d940e0acb9c17205eafafbe1a1e
Author: tjhunt <tjhunt>
Date:   Fri, 29 Feb 2008 07:39:15 +0900
Tag:    v1.9.0

MDL-13723 - Unbalanced brackets in get_users_by_capability in the groups bit.

commit 14942a2508debe09cf0b819f14cad506318fba88
Author: tjhunt <tjhunt>
Date:   Fri, 29 Feb 2008 06:43:47 +0900
Tag:    v1.9.0

MDL-12815 - Quiz uses inconsistent class attribute for the paging bar.

I have added the standard .paging class, but I have left the old class there too, so as not to break existing themes.

commit 37477441406f127f9319c96536b50be62ff267a0
Author: tjhunt <tjhunt>
Date:   Thu, 28 Feb 2008 21:52:59 +0900
Tag:    v1.9.0

MDL-13189 - replace the $QTYPE_MENU global with a function call, so that we can set up the language strings later, after $COURSE is initialised. This ensures that the quesion names appear in the right language.

commit 978af5c28b6b1c0301f6e4131df62da3c599a4d4
Author: tjhunt <tjhunt>
Date:   Wed, 20 Feb 2008 02:14:10 +0900
Tag:    v1.9.0

Fix dangerous comment. (MDL-13536)

commit 1cc44fbf90c4c11c6701b5e51b3616bfdf28b8bb
Author: tjhunt <tjhunt>
Date:   Wed, 20 Feb 2008 01:21:35 +0900
Tag:    v1.9.0

MDL-13448 - missing the global $db statement. Fix thanks to Samuli Karevaara.

commit 17e4bb15338a7c4dfadab4b2aa560a08f84d6e08
Author: tjhunt <tjhunt>
Date:   Wed, 20 Feb 2008 01:19:56 +0900
Tag:    v1.9.0

MDL-13390 - Wrong links in quiz notification emails

commit aede0ebcc0b4db48383a1b466f62a78dcfc7a0df
Author: tjhunt <tjhunt>
Date:   Wed, 20 Feb 2008 00:00:00 +0900
Tag:    v1.9.0

MDL-13530 - Improve words used in the gradebook plugin selector dropdown menu

commit 9e1a55242f4bde1c0ce6535eb16aeb239d1ae9d3
Author: tjhunt <tjhunt>
Date:   Thu, 31 Jan 2008 03:18:34 +0900
Tag:    v1.9.0

MDL-13110 - Manually grading random questions does not work. Fix thanks to Ken Burres.

commit 4334697e9e210b8ea3a1783475b64a79f23ef991
Author: tjhunt <tjhunt>
Date:   Thu, 31 Jan 2008 01:33:41 +0900
Tag:    v1.9.0

MDL-13253 - Should use separate language strings for user and module idnumber.

commit 000b78f3f0c27769394bfbf40450ba16cccd8f71
Author: tjhunt <tjhunt>
Date:   Thu, 31 Jan 2008 00:57:56 +0900
Tag:    v1.9.0

MDL-13238 - Optionally show the user's idnumber in the grader report.

commit adea20f6dc290576bf4cacea5dfacec9e1ef7dbc
Author: tjhunt <tjhunt>
Date:   Fri, 25 Jan 2008 02:13:29 +0900
Tag:    v1.9.0

MDL-12933 - Bug in mod/quiz/lib.php break MyMoodle - Fix thanks to Eric Merrill.

commit 0c1d63a43e140a7dcf0708e3ed6fffda2ba718d2
Author: tjhunt <tjhunt>
Date:   Fri, 25 Jan 2008 01:33:37 +0900
Tag:    v1.9.0

MDL-13102 - quiz_results block links to the old URL of the groups editing interface, and it links there for everyone, even if they don't have the capability to go there. Make it link to the participants page instead, if possible.

commit 369f3834caa653dc56c720febc79bfa6e9bdd932
Author: tjhunt <tjhunt>
Date:   Fri, 25 Jan 2008 00:06:48 +0900
Tag:    v1.9.0

MDL-13150 - Remove extra <br /> tag for XHTML strict validation - Thanks to Joseph Rzeau

commit ae1a7e05a6fb1762d41f7ac51bf3ea0b6b6e6668
Author: tjhunt <tjhunt>
Date:   Wed, 16 Jan 2008 00:25:03 +0900
Tag:    v1.9.0

MDL-13011 - Improve import form layout.

commit 168eda8b3aa4d6d5d3011b947e8c969525d3a1f6
Author: tjhunt <tjhunt>
Date:   Fri, 11 Jan 2008 00:38:47 +0900
Tag:    v1.9.0

MDL-12913 - Error messages when doing an XML grade import are not very helpful, include the idnumber that is causing the problem in the error message.

commit d67aacd867387e3092c24f16f28d45e22cdd7fee
Author: tjhunt <tjhunt>
Date:   Thu, 10 Jan 2008 23:17:35 +0900
Tag:    v1.9.0

Fix notice when you try to import an empty XML file.

commit 33d2459c8df2328b70ff10b7d67dddbe618dc7ce
Author: tjhunt <tjhunt>
Date:   Thu, 10 Jan 2008 19:58:09 +0900
Tag:    v1.9.0

MDL-12373 - More instances of links to the participants list being shown in the navigation bar to people without the necessary capability.

commit 0e544a84e68c1b2c0be0785329b74af61246bde3
Author: tjhunt <tjhunt>
Date:   Thu, 10 Jan 2008 02:23:45 +0900
Tag:    v1.9.0

MDL-12373 - If you can see your user profile, but don't have moodle/course:viewparticipants, you get a link in the nav bar that takes you to an error message - and there were also instances in blog.

commit 79a9b69e283a2941c04dfade13f6987404ea0cc7
Author: tjhunt <tjhunt>
Date:   Thu, 10 Jan 2008 01:46:19 +0900
Tag:    v1.9.0

MDL-12373 - If you can see your user profile, but don't have moodle/course:viewparticipants, you get a link in the nav bar that takes you to an error message - this was repeated in other parts of the user profile that I had not noticed when I fixed this before.

commit 5e17bdd0ebbbb6118947c1aefa04f3835ddf8291
Author: tjhunt <tjhunt>
Date:   Wed, 09 Jan 2008 03:37:43 +0900
Tag:    v1.9.0

MDL-12771 - change multianswer quetsion type HTML to more closely match that of other question types, in order to fix a layout glitch in Moodle 1.9.

commit 5ae009ad6db4c64367f515a5bb99a1db97ad7485
Author: tjhunt <tjhunt>
Date:   Wed, 09 Jan 2008 03:29:17 +0900
Tag:    v1.9.0

MDL-12785 - Partially correct tick icon not displayed for MULTICHOICE, single answer questions. Fix thanks to Joseph Rzeau. Merged from MOODLE_18_STABLE.

commit e0a411d4a481cc6368b2d32eb8ef2c6d47dc6990
Author: tjhunt <tjhunt>
Date:   Wed, 09 Jan 2008 00:17:04 +0900
Tag:    v1.9.0

MDL-12875 - Hidden courses not in category list not visible to teachers on those courses in the list of courses in a category.

commit 0229dc83eadba042bcdc62f2be9313fc34d702fe
Author: tjhunt <tjhunt>
Date:   Wed, 09 Jan 2008 00:04:04 +0900
Tag:    v1.9.0

Put back DEBUG_DEVELOPER sanity check in has_capability, that makes sure the capabiltiy you are asking about actually exists. I know it takes an extra DB query, but it is DEBUG_DEVELOPER only, and it is worth its weight in gold, because otherwise you get really subtle bugs that take forever to diagnose. I know, I have just been banging my head against the wall for an hour.

commit d091ee027f3635857df20e1341c5d1620e2e87fc
Author: tjhunt <tjhunt>
Date:   Tue, 08 Jan 2008 01:46:10 +0900
Tag:    v1.9.0

Use the locale to sort the list of activites everywhere. This matches a change a made in one place before christmas. If you don't do this, the PHP sorts by ASCII order, so mixed case names, or special characters, get sorted wrongly.

commit 6bd8edfbde9a68a40e5b9eb4aba4a650d13bc6b5
Author: tjhunt <tjhunt>
Date:   Sat, 22 Dec 2007 00:38:38 +0900
Tag:    v1.9.0

Ensure links of the form /mod/quiz/view.php?q=332 are backed up and restored correctly.

commit 88b020ce951f87f4f60f9e6e4417ec78d6d7c5e4
Author: tjhunt <tjhunt>
Date:   Sat, 22 Dec 2007 00:37:50 +0900
Tag:    v1.9.0

Sort the add activites dropdown using the locale.

commit 176c6e8a2316fb8122986b30c339ce70814943c4
Author: tjhunt <tjhunt>
Date:   Fri, 21 Dec 2007 00:11:01 +0900
Tag:    v1.9.0

MDL-12675 - Give teachers a direct link from the quiz index page to the results.

commit 204f51c760fda8d40ddd276fadc124eff5e6de8b
Author: tjhunt <tjhunt>
Date:   Thu, 20 Dec 2007 20:26:50 +0900
Tag:    v1.9.0

MDL-12666 - When moving questions between categories, we should default to copying amy linked files.

commit 6dd47a844fb1d013745da40f6a5011b8ef202458
Author: tjhunt <tjhunt>
Date:   Thu, 20 Dec 2007 00:06:52 +0900
Tag:    v1.9.0

Teach XMLDB about the local/db folder, but only include it if the local folders exists.

commit 7542409d3934da3e7eaac9a3edb6f26973a08001
Author: tjhunt <tjhunt>
Date:   Wed, 19 Dec 2007 22:31:06 +0900
Tag:    v1.9.0

New option on print_single_button to all printing of disabled buttons.

commit 5af229ea58c745be826ae2277c4c52ede844f950
Author: tjhunt <tjhunt>
Date:   Wed, 19 Dec 2007 21:40:02 +0900
Tag:    v1.9.0

gradebook / graded_users_iterator - Typo in conditional.

commit 16ee776952f73f4bf357f6a4bd8101467ed52756
Author: tjhunt <tjhunt>
Date:   Wed, 19 Dec 2007 21:10:50 +0900
Tag:    v1.9.0

MDL-12647 - Moving multiple_choice questions between contexts breaks them.

commit e5f0e7d200815fdd30a0ff71d0c0756f109605dc
Author: tjhunt <tjhunt>
Date:   Wed, 19 Dec 2007 03:19:36 +0900
Tag:    v1.9.0

Improve the quiz_rescale_grade function, and call it from one other place, instead of duplicating code.

commit 3f7c4ee5c4b62c1653033660976d127c2b0baf51
Author: tjhunt <tjhunt>
Date:   Wed, 19 Dec 2007 01:11:41 +0900
Tag:    v1.9.0

MDL-12635 - Manual grading report does not check capabilites - also, only show the tabs for the reports people can access.

commit 5db5737b4f8d5fdee10bdebd6343aad8541e7918
Author: tjhunt <tjhunt>
Date:   Tue, 18 Dec 2007 23:57:05 +0900
Tag:    v1.9.0

MDL-12517 - fix typo in the last commit.

commit cfa16a536e5bf1dcfc9479ffd10e606d6e430ae5
Author: tjhunt <tjhunt>
Date:   Tue, 18 Dec 2007 02:17:17 +0900
Tag:    v1.9.0

Strip out an unneccessary HTML table that way causing a 'button moves when you try to click on it' problem.

commit 860f345cebd5bc23536fa628c3e8ec10aeb5e8f7
Author: tjhunt <tjhunt>
Date:   Tue, 18 Dec 2007 01:56:16 +0900
Tag:    v1.9.0

Minor quiz layout improvements.

commit 833711e3b896176c95e29fd05ad11691d5c60402
Author: tjhunt <tjhunt>
Date:   Tue, 18 Dec 2007 00:29:43 +0900
Tag:    v1.9.0

Unset a meaningless id. This probably does not change anything in moodle, but it was part of a bug fix in the OU version of Moodle that seemed correct, so I am merging it over.

commit 204666c5691fdf2063d8949ad1dfb9449cae37b4
Author: tjhunt <tjhunt>
Date:   Mon, 17 Dec 2007 21:28:00 +0900
Tag:    v1.9.0

MDL-12616 - Improve layout so you can distinguish the student's response to an essay question from the feedback.

commit c9cde2149efab7c588d2b296eefae25ab9c4fc69
Author: tjhunt <tjhunt>
Date:   Fri, 14 Dec 2007 03:48:16 +0900
Tag:    v1.9.0

MDL-12575 - Backup and restore problems with the new question bank.

commit ddd8279beb02de2a4360a26fe55706e19e752cce
Author: tjhunt <tjhunt>
Date:   Fri, 14 Dec 2007 02:24:51 +0900
Tag:    v1.9.0

Improve error messages.

commit 6a729d0756323014712e12fd8468fc06452e6e71
Author: tjhunt <tjhunt>
Date:   Thu, 13 Dec 2007 23:26:01 +0900
Tag:    v1.9.0

MDL-12517 - Further refinement. Move the processing to after print_header, so any notices do not break XHTML strict.

commit 99a495949413865f1cae77a8d57a154ccf1a0e44
Author: tjhunt <tjhunt>
Date:   Thu, 13 Dec 2007 23:17:29 +0900
Tag:    v1.9.0

MDL-12517 - Move checking code into the user interface layer where it belongs.

commit 946db1620f60a301e3d72dc267e1009941691bfb
Author: tjhunt <tjhunt>
Date:   Thu, 13 Dec 2007 04:12:54 +0900
Tag:    v1.9.0

MDL-11267 - follow-up - don't show the checkboxes in the overview report if you cannot do anything with them.

commit a488df2a9558ffbb8926f120b0b373936ead438f
Author: tjhunt <tjhunt>
Date:   Thu, 13 Dec 2007 04:02:01 +0900
Tag:    v1.9.0

Improve PHP doc comments.

commit 4e0af3b10759a20b8dc2afc84c4be850e52e4365
Author: tjhunt <tjhunt>
Date:   Thu, 13 Dec 2007 03:10:50 +0900
Tag:    v1.9.0

Fix Javascript error from essay questions on the review page.

commit b7f00cff12062645dcccf31f434831b4e28baaae
Author: tjhunt <tjhunt>
Date:   Thu, 13 Dec 2007 02:47:37 +0900
Tag:    v1.9.0

Fix notice.

commit ea7f759cbf59f97f134cc9b51a084f829478d71b
Author: tjhunt <tjhunt>
Date:   Thu, 13 Dec 2007 02:23:38 +0900
Tag:    v1.9.0

MDL-9459 - Provide information relating to groups in the summary message "Attemts: 123". Now, depending on the situation, you see one of three messages: "Attempts: 123", "Attemtps 123 (45 from your groups)" or "Attemtps 123 (45 from this group)".

commit 297178bc876e233812943c4f4de43daca2f65863
Author: tjhunt <tjhunt>
Date:   Thu, 13 Dec 2007 02:10:51 +0900
Tag:    v1.9.0

Improve PHP doc comments.

commit 5775ef80c082846f0e401898a858d77eb4864b52
Author: tjhunt <tjhunt>
Date:   Wed, 12 Dec 2007 03:49:44 +0900
Tag:    v1.9.0

MDL-12546 - The choice module was calling get_users_by_capability, which hammers the database and returns lots of data, inside a loop over users - and it was calling it with identical parameters each time. Ouch!

commit 0eea4f935528288d9e0754a6d2d513dfec7e31ba
Author: tjhunt <tjhunt>
Date:   Wed, 12 Dec 2007 01:55:40 +0900
Tag:    v1.9.0

MDL-12543 - Quiz overview report displays a grade of 0 the same way as a missing grade for an incomplete attempt.

commit 8d531749c3df3ab07a3f294d0eb120d612eb6680
Author: tjhunt <tjhunt>
Date:   Wed, 12 Dec 2007 01:23:32 +0900
Tag:    v1.9.0

MDL-8682 - followup. When disabling the enter key, don't disable it on links. That is bad for accessibility.

commit 6233a11b291a42145559e2bbd518efc836130019
Author: tjhunt <tjhunt>
Date:   Wed, 12 Dec 2007 00:21:28 +0900
Tag:    v1.9.0

MDL-12542 - backup_todb not called on restore on date before it is inserted into mdl_user. This would cause a backup from a pre 1.7 site (or a pre 1.7 that has been upgraded to 1.9) to a 1.9 fresh install, to fail sometimes.

commit c6d734d3f9c019f7bf414c0b8e41ca2189d1fef6
Author: tjhunt <tjhunt>
Date:   Wed, 12 Dec 2007 00:04:09 +0900
Tag:    v1.9.0

MDL-12540 - Quiz sometimes outputs content before <head> when previewing - breaks HTML strict.

commit eabc30d78bed6e4594d09a89f4b6e0a413a055b7
Author: tjhunt <tjhunt>
Date:   Tue, 11 Dec 2007 19:37:56 +0900
Tag:    v1.9.0

Take out debugging output in role_assign. It only tells you that something has worked, and everywhere else we use debugging output to warn people they have called an API wrongly. Therefore, this is just confusing now that we trust this bit of roles code.

commit abc011e5cce27baa166a372cd473d3d61e19584d
Author: tjhunt <tjhunt>
Date:   Tue, 11 Dec 2007 02:37:01 +0900
Tag:    v1.9.0

MDL-12512 - Gradebook calculations are broken. This was caused by == FALSE that should have been === FALSE deep in the 3rd pary maths lib.

commit 1bb997ecc3b7edd07d1b648e1a7f9609cd02921f
Author: tjhunt <tjhunt>
Date:   Tue, 11 Dec 2007 01:53:11 +0900
Tag:    v1.9.0

Do not suppress errors from developers! it makes debugging a nightmare!

commit 200640a52c4a85c159d90724d92c23206a07c18a
Author: tjhunt <tjhunt>
Date:   Mon, 10 Dec 2007 20:57:22 +0900
Tag:    v1.9.0

Fix notice in numerical question.

commit f8c7c3ae3279c13329abcd2ae253d570eceb80bf
Author: tjhunt <tjhunt>
Date:   Sat, 08 Dec 2007 01:57:53 +0900
Tag:    v1.9.0

MDL-12501 - Logic for including 'Grades' link in admin block is different for the logic in grade/report/index.php.

commit ccc64d9cf0183683620e9098ce4b53ab672a41d3
Author: tjhunt <tjhunt>
Date:   Thu, 06 Dec 2007 02:25:18 +0900
Tag:    v1.9.0

MDL-12452 - not a fix I fear, just clarifying the comments about how this method is broken.

commit 22dd4e275a8eb42c78ce0b45e218985d01340063
Author: tjhunt <tjhunt>
Date:   Thu, 06 Dec 2007 01:50:15 +0900
Tag:    v1.9.0

MDL-12438 - followup - fix typos. Thanks to Dan Poltawski.

commit ecfa2d90ff9d71fa07dec675116484e6f58b252b
Author: tjhunt <tjhunt>
Date:   Thu, 06 Dec 2007 01:13:59 +0900
Tag:    v1.9.0

MDL-12450 - Matching up roles on the restore settings form is broken - this is basically a complete rewrite of these two functions.

commit a7502277f2a45aa2dbeba2982841f2500e5015f6
Author: tjhunt <tjhunt>
Date:   Wed, 05 Dec 2007 02:29:35 +0900
Tag:    v1.9.0

MDL-12438 - Print a develoer debug message if you call get_records with a non-unique first column.

commit 974fc258fbbd6cbfe9f6df4ac2ba4bbcb27a87a8
Author: tjhunt <tjhunt>
Date:   Fri, 30 Nov 2007 21:07:25 +0900
Tag:    v1.9.0

MDL-12373 - If you can see your user profile, but don't have moodle/course:viewparticipants, you get a link in the nav bar that takes you to an error message.

commit 25c052dbd72e93dcd84690e802aeeabdeb074306
Author: tjhunt <tjhunt>
Date:   Fri, 30 Nov 2007 20:00:06 +0900
Tag:    v1.9.0

MDL-12393 - Layout tweaks on question category editing page.

commit 811c6b01e0c33cc9ec13d4ada1451418e8f58277
Author: tjhunt <tjhunt>
Date:   Thu, 29 Nov 2007 01:43:04 +0900
Tag:    v1.9.0

MDL-12330 - moving a question that uses an image in a subfolder of course files, where the same subfolder does not exist at the destination, fails.

commit 49aeee2bf6cbbe95fdd98a6625c5df759f9266f0
Author: tjhunt <tjhunt>
Date:   Wed, 28 Nov 2007 21:45:42 +0900
Tag:    v1.9.0

MDL-12369 - get_actual_response should not truncate the student's response.

commit b4c11424e2f02453e3b13136b6023ec1c98f2eb9
Author: tjhunt <tjhunt>
Date:   Wed, 28 Nov 2007 04:18:11 +0900
Tag:    v1.9.0

MDL-12362 - Don't show scores for incomplete attempts on the quiz view page.

commit d1453ce26e9ef377f7a901730e8975125b200beb
Author: tjhunt <tjhunt>
Date:   Fri, 23 Nov 2007 03:15:07 +0900
Tag:    v1.9.0

MDL-12322 - Reference to incorrect language file

commit 1dcf42a4baed573e9d58d5d6503814c4d026cc53
Author: tjhunt <tjhunt>
Date:   Thu, 22 Nov 2007 20:51:19 +0900
Tag:    v1.9.0

MDL-12282 - fix typo in previous commit. Sorry.

commit 4a0f06d55107122ca3ba97fec85613a1459646fd
Author: tjhunt <tjhunt>
Date:   Thu, 22 Nov 2007 03:08:56 +0900
Tag:    v1.9.0

MDL-12305 - Don't let the quiz reorder tool put a page break at the start of the quiz.

commit a5f1acc2b4bed5aed730f0402f8dd4812ddb86e3
Author: tjhunt <tjhunt>
Date:   Thu, 22 Nov 2007 02:59:52 +0900
Tag:    v1.9.0

MDL-12305 - Quiz reorder tool broken.

commit ac6fa5eb9052a0f2bb77420bd058ec56e337db42
Author: tjhunt <tjhunt>
Date:   Thu, 22 Nov 2007 01:30:14 +0900
Tag:    v1.9.0

Fix some whitespace.

commit c4c1a7737f3a14b90351281abe3aa9469db544e9
Author: tjhunt <tjhunt>
Date:   Thu, 22 Nov 2007 01:28:40 +0900
Tag:    v1.9.0

Fix typo.

commit 5ee185d12e77abec80a52c588c0d83abdb0a1fc6
Author: tjhunt <tjhunt>
Date:   Wed, 21 Nov 2007 02:51:45 +0900
Tag:    v1.9.0

MDL-12286 - 'Save as new question' button ignores the setting in the 'Save in category' dropdown.

commit b35f76841df59792f809a01f5e9184d1aca92440
Author: tjhunt <tjhunt>
Date:   Wed, 21 Nov 2007 02:30:56 +0900
Tag:    v1.9.0

MDL-12172 - Sorry, more fall-out from converting continue buttons to use GET instead of POST. Sometimes, URLs were being passed in with & already repalced by &amp; and we weren't handling that properly. Should now be fixed.

commit 011508b2b043ad7f1703fab95b3b826424679594
Author: tjhunt <tjhunt>
Date:   Wed, 21 Nov 2007 01:57:15 +0900
Tag:    v1.9.0

MDL-12282 - Numerical question type - the units are displayed on the editing form with a stupidly large number of decimal places. Merged from MOODLE_18_STABLE.

commit e1a0eb49d68f6802c7bee0081d5068bc62c4d055
Author: tjhunt <tjhunt>
Date:   Wed, 21 Nov 2007 00:54:21 +0900
Tag:    v1.9.0

MDL-12280 - Question bank forgets sort order when adding multiple questions to a quiz.

commit 09846a54ad800bfc8a605452486f1017581c1a24
Author: tjhunt <tjhunt>
Date:   Wed, 21 Nov 2007 00:07:48 +0900
Tag:    v1.9.0

MDL-12133 - Errors calling parent::validation in a moodle form subclass because the base class method returns true not an empty array. This patch allow subclasses to start their validate method with

commit 06d7ef9cd38117c11a8729f84cb62a26d0e507fb
Author: tjhunt <tjhunt>
Date:   Tue, 20 Nov 2007 23:46:33 +0900
Tag:    v1.9.0

Remove a developer debug notice and save a database query.

commit 1a632495f7d39445757202fce6a67521f060ca19
Author: tjhunt <tjhunt>
Date:   Tue, 20 Nov 2007 21:40:44 +0900
Tag:    v1.9.0

MDL-12133 - Errors calling parent::validation in a moodle form subclass because the base class method signature was changed. This patch fixes all calls to parent::validation in the question editing forms.

commit 582e15dfd2619c3b2b4da0609a0d28b675b16a31
Author: tjhunt <tjhunt>
Date:   Thu, 15 Nov 2007 02:03:16 +0900
Tag:    v1.9.0

MDL-12066 - Links in the HTML block are not recoded on backup and restore.

commit d2219dda261acc155dd9c8eb21c4067c2beae15b
Author: tjhunt <tjhunt>
Date:   Thu, 15 Nov 2007 01:33:57 +0900
Tag:    v1.9.0

MDL-12172 - print_continue should create a method="get" button, not post.

commit 2fca979ee3c6d1b8422ff9d7b42924f565d86eaa
Author: tjhunt <tjhunt>
Date:   Wed, 14 Nov 2007 23:48:46 +0900
Tag:    v1.9.0

Delete commented-out code that was actually not commented out properly, and so caused warnings. Merged from MOODLE_18_STABLE.

commit 6d3bcb44dd99148651c79be8eef84a0198d22a05
Author: tjhunt <tjhunt>
Date:   Thu, 08 Nov 2007 00:26:29 +0900
Tag:    v1.9.0

Eliminate duplicate $Id$ tag.

commit 41c88b8cdafe77ca9b163bbc6831d75e2a6dcd3b
Author: tjhunt <tjhunt>
Date:   Thu, 08 Nov 2007 00:20:48 +0900
Tag:    v1.9.0

Eliminate duplicate $Id$ tag.

commit 228d5ecb07ec5c3de88b64be2d178f4c598394de
Author: tjhunt <tjhunt>
Date:   Wed, 07 Nov 2007 21:35:09 +0900
Tag:    v1.9.0

Eliminate duplicate $Id$ tag.

commit 5cf2c57a22b08b140380e95dcfc9685b933c8066
Author: tjhunt <tjhunt>
Date:   Sat, 03 Nov 2007 01:19:54 +0900
Tag:    v1.9.0

Minor whitespace fixups.

commit 2e978de3d1fd2f42d6360518a56ff5286dd15c3d
Author: tjhunt <tjhunt>
Date:   Thu, 01 Nov 2007 02:08:51 +0900
Tag:    v1.9.0

MDL-10284 - wrong language string used on the quiz view page to inform students of the quiz deadline. I took the opportunity to strip out an unnecessary HTML table, and reviewing uses of the string /quiz(open|close)s?/ found one other inconsistency on the quiz editing form. Merged from MOODLE_18_STABLE.

commit a999da51c5a9faaad924b879102042765c5d2914
Author: tjhunt <tjhunt>
Date:   Thu, 01 Nov 2007 01:42:06 +0900
Tag:    v1.9.0

MDL-11624 - /mod/quiz/index.php too dependant on individual course format names. I basically changed it to do the same as the forum module. Merged from MOODLE_18_STABLE.

commit 3d94c5e08ec02e07ac491add50c59f9f14acdcad
Author: tjhunt <tjhunt>
Date:   Wed, 31 Oct 2007 04:28:05 +0900
Tag:    v1.9.0

MDL-6376 - fix minor errors in the previous commit.

commit d09ab4014272e0f033489b987ab962a98e98269d
Author: tjhunt <tjhunt>
Date:   Tue, 30 Oct 2007 19:49:25 +0900
Tag:    v1.9.0

MDL-11951 - supplemental - need capability checks in the outer if of the file too.

commit 435d7bdba91915915381ed8a1cdcfd835a9bc7ce
Author: tjhunt <tjhunt>
Date:   Tue, 30 Oct 2007 19:46:23 +0900
Tag:    v1.9.0

Unit tests for MDL-9295 - clean_param with PARAM_URL/PARAM_LOCALURL. Merged from MOODLE_18_STABLE.

commit 7e340b3e8d23cd5d5bf84501cb3145695a3f3c39
Author: tjhunt <tjhunt>
Date:   Tue, 30 Oct 2007 19:15:27 +0900
Tag:    v1.9.0

MDL-9295 - PARAM_URL/PARAM_LOCALURL does not accept http://localhost/ or other hosts on lans. Merged from MOODLE_18_STABLE.

commit 384a9cbda958bb8de06a497de57a56f9ced9c189
Author: tjhunt <tjhunt>
Date:   Tue, 30 Oct 2007 19:10:20 +0900
Tag:    v1.9.0

Correct misleading comment. Follow-on from the fix to MDL-11462.

commit 13beed44aa74776b582728d724d39f4b21e2f5e7
Author: tjhunt <tjhunt>
Date:   Tue, 30 Oct 2007 01:58:10 +0900
Tag:    v1.9.0

MDL-11952 - In the course admin block, if the user has moodle/question:managecategory, but no other capabilites, the questions link should go to the manage categories page

commit 1db25b89500fdd541f22447710a07e3629d12e22
Author: tjhunt <tjhunt>
Date:   Tue, 30 Oct 2007 01:53:41 +0900
Tag:    v1.9.0

MDL-11951 - Need a link to the Front Page course question bank in the admin tree.

commit 4288cc0e90d2c6458ec4694874e99be2a1341405
Author: tjhunt <tjhunt>
Date:   Tue, 30 Oct 2007 00:38:31 +0900
Tag:    v1.9.0

MDL-11784 - On the role assign page, list who is assigned the role for roles with only a few assignments. Improved version. Now, it only shows the extra column if some roles have between 1 and 10 assignees, as per Martin D's request.

commit e63938ba8a5c00bf434a577840bc43d975fc8d95
Author: tjhunt <tjhunt>
Date:   Sat, 27 Oct 2007 00:59:49 +0800
Tag:    v1.9.0

MDL-11917 - Improve the title on the assign/override roles page.

commit 677ab5e475ceacbb4518ac13e24183dcdf55f59e
Author: tjhunt <tjhunt>
Date:   Thu, 25 Oct 2007 22:29:39 +0800
Tag:    v1.9.0

Fix typo.

commit 4a4b110509c24f70776bb4467eb33882cecf0a11
Author: tjhunt <tjhunt>
Date:   Thu, 25 Oct 2007 17:43:09 +0800
Tag:    v1.9.0

MDL-11825 - Force penaltyfactor to 1 for truefalse questions on GIFT import, as is done on the editing form. Merged from MOODLE_18_STABLE.

commit 6a3ba4e585cf82d340a55b317b0f8fd323b2de43
Author: tjhunt <tjhunt>
Date:   Wed, 24 Oct 2007 00:27:06 +0800
Tag:    v1.9.0

MDL-11784 - On the role assign page, list who is assigned the role for roles with only a few assignments.

commit b16832dd090391b7089bfd8d114ac2a21e30bc9c
Author: tjhunt <tjhunt>
Date:   Wed, 24 Oct 2007 00:15:31 +0800
Tag:    v1.9.0

MDL-11881 - User with question permission but not mod/quiz:manage can get a nasty require_capability error.

commit e88133dc1243104cd677a1353cc5a99027910500
Author: tjhunt <tjhunt>
Date:   Tue, 23 Oct 2007 15:47:43 +0800
Tag:    v1.9.0

MDL-11870 - Notices on the quiz view page if the corresponding grade item was deleted.

commit 7cc3f26d187a58032680581c44ef5dc5975d2aac
Author: tjhunt <tjhunt>
Date:   Tue, 23 Oct 2007 00:57:09 +0800
Tag:    v1.9.0

MDL-11708 - Zero answers are not allowed in Matching questions - sometimes I hate PHP. Merged from MOODLE_18_STABLE.

commit 8ac54989ebab5cf0a16d3e9db190e3d5fff954b9
Author: tjhunt <tjhunt>
Date:   Mon, 22 Oct 2007 23:37:25 +0800
Tag:    v1.9.0

MDL-11824 - Literal asterisk (\*) in shortanswer question not handled correctly by get_correct_responses + Unit tests. Merged from MOODLE_18_STABLE.

commit b85eb9fa4a6bc67a4ac742a86b00bfa3b6172ff4
Author: tjhunt <tjhunt>
Date:   Thu, 18 Oct 2007 04:20:17 +0800
Tag:    v1.9.0

MDL-11061 - admin notifications about $CFG->wwwroot, which sometimes lead to obscure errors.

commit c5c60abd3e2b701bb342d932dbeab4ef2a683d05
Author: tjhunt <tjhunt>
Date:   Wed, 17 Oct 2007 22:35:34 +0800
Tag:    v1.9.0

Fix notice.

commit aeb50096a1cf10f79acbe28faff0c369f7766fa4
Author: tjhunt <tjhunt>
Date:   Wed, 17 Oct 2007 05:26:03 +0800
Tag:    v1.9.0

MDL-5262 - PHP notice when sorting on R% coloumn in the Item analysis report - I adopted the simple solution of stopping people sorting on that column, since it is the same as sorting on rcount, I think.

commit 8af53beeec3e4005316653c329bf73ba139b463d
Author: tjhunt <tjhunt>
Date:   Wed, 17 Oct 2007 04:52:12 +0800
Tag:    v1.9.0

Fix possible notice.

commit ede4316c01cefaf99f351ffa65e165a2b57b4e8f
Author: tjhunt <tjhunt>
Date:   Wed, 17 Oct 2007 04:43:28 +0800
Tag:    v1.9.0

MDL-11794 - Blocks editing on button is not XHTML Strict when produced by page_generic_activity.

commit 49fa880ef668e040519c2d6b84c2c49b8c1eff7e
Author: tjhunt <tjhunt>
Date:   Wed, 17 Oct 2007 04:29:37 +0800
Tag:    v1.9.0

MDL-11791 - Custom corners broken on the quiz view page because I missed a global declaration, and PHP empty was hiding the problem.

commit 40c6886f951f0275426775b6c45e28680e247a44
Author: tjhunt <tjhunt>
Date:   Tue, 16 Oct 2007 22:03:08 +0800
Tag:    v1.9.0

Fix restore notice when a role has no capabilities.

commit 478c9e9380875590631702c64307cb5709b96eab
Author: tjhunt <tjhunt>
Date:   Mon, 15 Oct 2007 15:31:52 +0800
Tag:    v1.9.0

MDL-11762 - Navigation not set up properly for resources - $this->navlinks was not being initialised in the base class.

commit 94f07cd5242b5d146ddcb3ad35dbd6574e14778f
Author: tjhunt <tjhunt>
Date:   Sun, 14 Oct 2007 06:00:30 +0800
Tag:    v1.9.0

Correct misleading error message in upgrade_activity_modules. Spotted while diagnosing MDL-11732.

commit b34fc1be248eddc80d38e1ed5980c2c300938c7d
Author: tjhunt <tjhunt>
Date:   Sat, 13 Oct 2007 00:09:37 +0800
Tag:    v1.9.0

MDL-11741 - Convert core modules to take advantage of recent improvements to build_navigation.

commit c971067f91e6e2d62e3d61493d80e121037bcf5e
Author: tjhunt <tjhunt>
Date:   Fri, 12 Oct 2007 23:11:39 +0800
Tag:    v1.9.0

MDL-11699 - Making one more common case a bit nicer for callers.

commit 36f4fa0c2d7a1873213fca80443a73774a4e1510
Author: tjhunt <tjhunt>
Date:   Fri, 12 Oct 2007 18:35:55 +0800
Tag:    v1.9.0

MDL-11699 - Further, backwards-compatible, improvement to the build navigation API to simplify a common case. Also, further improvements to the doc comment, so it is easy to use.

commit ba79369331fed6f9eda14ff85f840b4a165521a3
Author: tjhunt <tjhunt>
Date:   Fri, 12 Oct 2007 00:43:16 +0800
Tag:    v1.9.0

MDL-11699 - Addendum - fix typo in fixup code. Sorry.

commit 0a4025eaa59da2dcd4eedd36e4751fec717c8856
Author: tjhunt <tjhunt>
Date:   Thu, 11 Oct 2007 23:25:14 +0800
Tag:    v1.9.0

Small tidy-up in print_header_simple.

commit b9ecfd49572a1f808e2b3abfd46093790ca3ac08
Author: tjhunt <tjhunt>
Date:   Thu, 11 Oct 2007 19:42:03 +0800
Tag:    v1.9.0

MDL-9542 - Show final grades from new gradebook in Quiz UI - with help from Petr.

commit 3270033ab8d8ae14dce63811bd57f2eb16156317
Author: tjhunt <tjhunt>
Date:   Wed, 10 Oct 2007 23:26:45 +0800
Tag:    v1.9.0

MDL-11703 - escaped *'s in shortanswer answers were not matching properly. Merged from MOODLE_18_STABLE.

commit 1ba3ad7df5fc02bfebfbf947e9549d694ead1281
Author: tjhunt <tjhunt>
Date:   Wed, 10 Oct 2007 22:00:41 +0800
Tag:    v1.9.0

MDL-11699 - Make build_navigation more helpful by having it optionally build the activity and activityinstance links too, if you pass a $cm object. Note that this only does extra DB queries if you do pass a $cm object, and it does not have all the required fields, but in this case it will winge at you in developer debug mode. If you get your $cm using get_coursemodule_from_instance or get_coursemodule_from_id, which is best practice these days, then you won't have a problem.

commit 6f3b54c8aa5bd7a2790e893f7074aea68abdb7bf
Author: tjhunt <tjhunt>
Date:   Tue, 09 Oct 2007 23:44:06 +0800
Tag:    v1.9.0

MDL-9076 - Move the 'Add 3 more overall feedbacks' button inside that group of elements on the quiz settings form.

commit e2833e870082c4cb2a1b1dac8be8cfc3d5a8b4a8
Author: tjhunt <tjhunt>
Date:   Tue, 09 Oct 2007 23:19:07 +0800
Tag:    v1.9.0

MDL-11617 - 'Student may review' heading on quiz settings form is now misleading. I have fixed some lang strings and improved the help. Also, finish off the clarification of how various capabilites affect quiz review that was started in MDL-11580.

commit 01600b51909c27b4e96c7e80885525fa2615e76c
Author: tjhunt <tjhunt>
Date:   Thu, 04 Oct 2007 23:57:09 +0800
Tag:    v1.9.0

MDL-11580 - refinement to Yu's checkin, including removing the $CFG->openuniversityhacks.

commit 75afe0e7e4301f8c9de7a9f508f8656d5a2fa12d
Author: tjhunt <tjhunt>
Date:   Wed, 03 Oct 2007 02:49:04 +0800
Tag:    v1.9.0

PHP docs for choose_from_menu function. Merged from MOODLE_18_STABLE.

commit 325898c61eac6ed84f5ededb52c56b3d614c2c62
Author: tjhunt <tjhunt>
Date:   Tue, 02 Oct 2007 21:32:51 +0800
Tag:    v1.9.0

MDL-11552 - Oops, I missed one bit when merging from OU Moodle.

commit aad9f920b1f533ea6776a9e3033464e2e7f4e3c8
Author: tjhunt <tjhunt>
Date:   Tue, 02 Oct 2007 21:30:51 +0800
Tag:    v1.9.0

MDL-11552 - Look for the name of an admin report inside the plugin's own lang dir before falling back to the main admin.php lang file.

commit 411efaee251fe980865056e3b24b08eaa330b894
Author: tjhunt <tjhunt>
Date:   Thu, 27 Sep 2007 14:54:17 +0800
Tag:    v1.9.0

MDL-5327 - When making up a default question name from the question text, strip any HTML tags. Merged from MOODLE_18_STABLE.

commit 3b0ee367a79150aa367ec812a2184bd68fe32523
Author: tjhunt <tjhunt>
Date:   Thu, 27 Sep 2007 05:31:54 +0800
Tag:    v1.9.0

MDL-11466 - failing to check for the case $rs = false in the accesslib performance improvements. Credit for the fix goes to Gareth Morgan.

commit 771b1a46f7621d90e3dacfb21f60358ad855e50c
Author: tjhunt <tjhunt>
Date:   Thu, 27 Sep 2007 04:45:23 +0800
Tag:    v1.9.0

MDL-9331 - Problem with the tables on the quiz index page. Merged from MOODLE_18_STABLE.

commit 2d8bfda03f5823979e66a5e8e4fc8bd9396a360a
Author: tjhunt <tjhunt>
Date:   Thu, 27 Sep 2007 04:13:47 +0800
Tag:    v1.9.0

MDL-5086 - Improve the formatting of the question import and export help so that the code samples fit. Merged from MOODLE_18_STABLE.

commit 4879c1ab031fb605a9da0a81731d1780767b26bf
Author: tjhunt <tjhunt>
Date:   Thu, 27 Sep 2007 04:10:08 +0800
Tag:    v1.9.0

Tweak the styles for <pre> tags in help files. These are mostly used for code samples, and they have a grey background and are shown in a different font, so the indent I am getting rid of is not necessarly to make the structure of the document clearn, and usually just means that the code sample does not fit. Merged from MOODLE_18_STABLE.

commit fba3ea31bc398ac363763b837f72ede3d5f88069
Author: tjhunt <tjhunt>
Date:   Thu, 27 Sep 2007 02:15:31 +0800
Tag:    v1.9.0

MDL-8682: Pressing enter when answering a short answer question can submit the wrong one. To fix this, I have disabled the enter key unless the keyboard focus is on a submit button (or inside a text box or HTML editor).

commit c6f9234ce38fc6e9d42d88381c902e1c32282cf7
Author: tjhunt <tjhunt>
Date:   Thu, 27 Sep 2007 01:48:27 +0800
Tag:    v1.9.0

Comment out an if (ajaxenabled()) check that was stopping any javascript included with require_js before print_header from being included, (but not js included afterwareds). See http://moodle.org/mod/forum/discuss.php?d=81050 for discussion.

commit f59dba84970e43ae75abde8a82a4c6f1e70e459f
Author: tjhunt <tjhunt>
Date:   Thu, 27 Sep 2007 00:10:38 +0800
Tag:    v1.9.0

MDL-11398 - Random questions sometimes ended up with names different from the cateogry they were actually picking from. Also, the same random questoin could be used in more than one quiz, in which case editing that question would change two quizzes unexpectedly. The fix is:

commit 44888f691ab02cb7d1faccd2908471526b542b1b
Author: tjhunt <tjhunt>
Date:   Wed, 26 Sep 2007 18:13:23 +0800
Tag:    v1.9.0

Add $Id$ tags.

commit 8d503f7557b8197a499b799ca3787883a1101b73
Author: tjhunt <tjhunt>
Date:   Wed, 26 Sep 2007 18:11:13 +0800
Tag:    v1.9.0

Get rid of duplicate $Id$ tags.

commit 7e7b6825efe0b2a169c0ccbb03cc71fcb4914e16
Author: tjhunt <tjhunt>
Date:   Wed, 26 Sep 2007 18:02:00 +0800
Tag:    v1.9.0

MDL-11446 - when a set of radio buttons is a required field, don't colour the lables of all the individual radio buttons red.

commit 4827029b9213a86661c64132f3e75ada9d65d3e3
Author: tjhunt <tjhunt>
Date:   Wed, 26 Sep 2007 17:40:28 +0800
Tag:    v1.9.0

MDL-11454 - hard-coded mdl_ prefix. Also, wrong logic in is_siteadmin in accesslib.php.

commit f22bc9dbcbc3ae0aff416fba8aff2acc2cb64bc8
Author: tjhunt <tjhunt>
Date:   Wed, 26 Sep 2007 01:18:08 +0800
Tag:    v1.9.0

MDL-10402 - udpate the Main glossary help file, to clarify the position with Main glossaries since Moodle 1.7.

commit f8f95b454a0304fb5dc2a544516189eb87ddd3d7
Author: tjhunt <tjhunt>
Date:   Tue, 25 Sep 2007 22:44:53 +0800
Tag:    v1.9.0

MDL-10898 - Option to back up only selected role assignements when backing up a course with users.

commit c0ca082d2ffa71ffa9a6632395d9281c7fae62cf
Author: tjhunt <tjhunt>
Date:   Tue, 25 Sep 2007 22:39:42 +0800
Tag:    v1.9.0

Remove spurious characters from some SQL statements.

commit b92ffdf9ac9a6d222956ee93fd653afe1fa9ec8d
Author: tjhunt <tjhunt>
Date:   Mon, 24 Sep 2007 23:45:29 +0800
Tag:    v1.9.0

Whitespace cleanup.

commit 80fdc53efd7300ec4b2f4c6137756927794416a2
Author: tjhunt <tjhunt>
Date:   Mon, 24 Sep 2007 22:18:47 +0800
Tag:    v1.9.0

Related to MDL-10916 - saving Cloze questions in Moodle 1.9 generates Notices because of changes to questionstupe_base::save_question.

commit 4ab4dcb27acbe981097ff94c07044da42ddf6906
Author: tjhunt <tjhunt>
Date:   Mon, 24 Sep 2007 22:17:23 +0800
Tag:    v1.9.0

MDL-10916 - Import and Export of Cloze question misses out "generalfeedback" column. Merged from MOODLE_17_STABLE.

commit ec2692a6990568d71b9c684d1f4ea1d76f7a96ca
Author: tjhunt <tjhunt>
Date:   Sat, 22 Sep 2007 02:28:45 +0800
Tag:    v1.9.0

MDL-11316 - Extra slashes appearing in the correct answer of shortanswer questions when they contain a slash. Merged from MOODLE_18_STABLE.

commit 8cf0f100b8146e201c5e48fc6f6c0735140ff660
Author: tjhunt <tjhunt>
Date:   Sat, 22 Sep 2007 01:10:39 +0800
Tag:    v1.9.0

MDL-11392 - Stupid bloody requirement to call addslashes between loading data from the database and saving it back, because we don't use placeholder. Was breaking question bank upgrade.

commit 095b599a7f9a9c16a52c8ed73df79586cc26607c
Author: tjhunt <tjhunt>
Date:   Sat, 22 Sep 2007 00:18:06 +0800
Tag:    v1.9.0

MDL-9952 - Cant escape # by using \ in a Cloze question. Merged from MOODLE_18_STABLE.

commit a4faed6925f6175d6b498d65b55cba50f4870a0d
Author: tjhunt <tjhunt>
Date:   Sat, 22 Sep 2007 00:01:40 +0800
Tag:    v1.9.0

MDL-10030 - the logic controlling whether students were allowed to see the review screen was wrong.

commit 8368d9791686ddb020c53de2f057ead829c846e3
Author: tjhunt <tjhunt>
Date:   Fri, 21 Sep 2007 21:28:53 +0800
Tag:    v1.9.0

MDL-3731 - Help file for the Item Analysis report does not explain why Disc. Coeff. is sometimes reported at -999.00. Merged from MOODLE_18_STABLE.

commit f0bb0a87382d6ad593a1642498913d39dbe3072f
Author: tjhunt <tjhunt>
Date:   Fri, 21 Sep 2007 19:10:37 +0800
Tag:    v1.9.0

MDL-10338 - quiz index page does not work in weekscss format. Merged from MOODLE_18_STABLE.

commit b5a16eb72ec96b963700f5c674ee4451aa3c3fbd
Author: tjhunt <tjhunt>
Date:   Fri, 21 Sep 2007 19:05:04 +0800
Tag:    v1.9.0

MDL-6376 - Include quizzes on the MyMoodle page. Initial implementation by Stephen Bourget, with refinements by Tim Hunt. The logic for which quizzes are listed is very similar to the lesson module.

commit c033e37f169f3dd43b038f6a7992cd33df2959dc
Author: tjhunt <tjhunt>
Date:   Thu, 20 Sep 2007 23:57:02 +0800
Tag:    v1.9.0

Notices on restore.

commit db451e99f6db52d1cb170afa9afd0460e5cde2f8
Author: tjhunt <tjhunt>
Date:   Thu, 20 Sep 2007 23:35:19 +0800
Tag:    v1.9.0

XHTML Strict.

commit e63faf2b500cbccd5ad6f7ba5d2f3e4ea1efafec
Author: tjhunt <tjhunt>
Date:   Thu, 20 Sep 2007 23:14:24 +0800
Tag:    v1.9.0

MDL-10376 - since roles and capabilities came along, the quiz was not very gracious if you were logged in as guest, or really logged in on the server, but using guest access to look a a particular course, or were enrolled in a course, but in a role that did not let you preview or attempt quizzes. This patch should clean up the logic for all these cases.

commit c5ccb82c614578e1cf51a6cdf7d1608c5b4af4df
Author: tjhunt <tjhunt>
Date:   Thu, 20 Sep 2007 23:10:04 +0800
Tag:    v1.9.0

XHTML Strict in question state history table. Merged from MOODLE_18_STABLE.

commit 314fc083d925e4e0def3e7b926de818bcd50bdfb
Author: tjhunt <tjhunt>
Date:   Thu, 20 Sep 2007 01:44:52 +0800
Tag:    v1.9.0

MDL-10824 - spaces in javascript URLs are not strictly valid. Merged from MOODLE_18_STABLE.

commit 1ced9d7b73193273373544f3c8ddf4ed3ebc81bc
Author: tjhunt <tjhunt>
Date:   Thu, 20 Sep 2007 01:06:31 +0800
Tag:    v1.9.0

MDL-10903 - Wrong capability checked in get_all_instances_in_course should be moodle/course:viewhiddenactivities, not moodle/course:viewhiddencourses. Merged from MOODLE_18_STABLE.

commit 260812ba065fcd46efe06c10aa4af2dd2162fe88
Author: tjhunt <tjhunt>
Date:   Wed, 19 Sep 2007 23:52:27 +0800
Tag:    v1.9.0

MDL-10972 - The lang string 'fullname', which is normally used for course fullnames, was being used for a person's full name in some quiz reports. This dual usage is not translatable into all languages. Merged from MOODLE_18_STABLE.

commit 6ef56c991f43f441b88d127ce9e75a7e4cf19c38
Author: tjhunt <tjhunt>
Date:   Wed, 19 Sep 2007 23:38:14 +0800
Tag:    v1.9.0

MDL-6043 - supplimental - make corse reset function update quiz open and close dates. Thanks to Shamim Rezaei for the implementation, which I edited slightly.

commit fca490bca0ddce652b40b9e9e5b1488e7ab83123
Author: tjhunt <tjhunt>
Date:   Wed, 19 Sep 2007 18:56:24 +0800
Tag:    v1.9.0

MDL-6315 - When processing a manul grading action, if both the comment and the score are blank - as might be the case on the 'Grade all' page of the manual grading when the teacher uses it to grade some, but not all of the students - then do not record the question as graded. Merged from MOODLE_18_STABLE.

commit 6c554fc9b8ccfe9cd27d5aed7a7f18f713c7e760
Author: tjhunt <tjhunt>
Date:   Wed, 19 Sep 2007 18:32:09 +0800
Tag:    v1.9.0

XHTML Strictness. Merged from MOODLE_18_STABLE.

commit 01c4e87acfdae0cef0f464c30fafe45f999cee1c
Author: tjhunt <tjhunt>
Date:   Wed, 19 Sep 2007 18:26:39 +0800
Tag:    v1.9.0

MDL-11095 - Use absolute path to include tabs.php, not a relative path, for greater robustness. Merged from MOODLE_18_STABLE.

commit c767d3b7d3fa067f2dd30d2e84bf56ac2f242e32
Author: tjhunt <tjhunt>
Date:   Tue, 18 Sep 2007 20:15:22 +0800
Tag:    v1.9.0

MDL-11317 - Slashes displayed in incorrect responses for short answer questions. Fix by adding stripslashes in the appropriate place. Merged from MOODLE_18_STABLE.

commit 07a7d8592454393515e3288b60256920c300e89f
Author: tjhunt <tjhunt>
Date:   Tue, 18 Sep 2007 00:17:24 +0800
Tag:    v1.9.0

MDL-11267 - Anywone who can view quiz reports can delete student attempts. Merged from MOODLE_18_STABLE.

commit 4da81e73429dc74cced07afe4979994d1594644a
Author: tjhunt <tjhunt>
Date:   Mon, 17 Sep 2007 22:39:52 +0800
Tag:    v1.9.0

MDL-11310 - Multichoice edititing form should have space for 5 answers by default. Merged from MOODLE_18_STABLE.

commit 83d22f706434663e1783b904ff0419a04ea51d8f
Author: tjhunt <tjhunt>
Date:   Fri, 14 Sep 2007 17:42:53 +0800
Tag:    v1.9.0

MDL-11271 - The closing bracket "}" can't be used in cloze question type. Now, you can excape a closing } with a backslash. Do feedback, as well as answer. Merged from MOODLE_18_STABLE.

commit 9c61c44fc1a55be5f56ea69c06d84d244360fd64
Author: tjhunt <tjhunt>
Date:   Fri, 14 Sep 2007 17:34:52 +0800
Tag:    v1.9.0

MDL-11271 - The closing bracket "}" can't be used in cloze question type. Now, you can excape a closing } with a backslash. Merged from MOODLE_18_STABLE.

commit ace1bf9d8ec9fcf6eae0e9d1f996f08a8397ac3b
Author: tjhunt <tjhunt>
Date:   Fri, 14 Sep 2007 17:33:30 +0800
Tag:    v1.9.0

MDL-11284 - Can't save edited questions

commit e8666d9abbb4d7b9d95d979bb43ea275c6872c1c
Author: tjhunt <tjhunt>
Date:   Fri, 14 Sep 2007 01:29:08 +0800
Tag:    v1.9.0

MDL-11081 and MDL-11211 - Implement quiz_question_list_instances. The lach of this function was causing a horrible dataloss bug: MDL-11211. Fix thanks to Janne Mikkonen, refined by me. Merged from MOODLE_16_STABLE.

commit 8472a14d71dedc5c56732bc785242135a8a243a0
Author: tjhunt <tjhunt>
Date:   Fri, 14 Sep 2007 00:25:00 +0800
Tag:    v1.9.0

MDL-11213 - Quiz preview attempts show up in item analysis. Fix thanks to Jean-Michel Vedrine. Merged from MOODLE_18_STABLE.

commit d9935f29859a945047d3e8b67ec3ca1723a546de
Author: tjhunt <tjhunt>
Date:   Thu, 13 Sep 2007 18:47:05 +0800
Tag:    v1.9.0

MDL-11231 - Missing "correct" tick in Close question with answer '0'. Merged from MOODLE_18_STABLE.

commit 5b875ebf82b155c13bb687e7bebd205f0e1c1447
Author: tjhunt <tjhunt>
Date:   Mon, 10 Sep 2007 19:07:39 +0800
Tag:    v1.9.0

Take out duplicate $Id$ CVS tags.

commit 1a05537338d214950f2e3299d1e868248807f35a
Author: tjhunt <tjhunt>
Date:   Fri, 17 Aug 2007 23:03:06 +0800
Tag:    v1.9.0

MDL-10897 - Backup is horribly inefficient when getting the users to include

commit 2a4e13c5e71d7181760ce1d00079fa5994d6e98f
Author: tjhunt <tjhunt>
Date:   Fri, 17 Aug 2007 21:07:23 +0800
Tag:    v1.9.0

MDL-10894 - Make block add/remove and edit permissions more consistent

commit c389b50482c793853cbb4a6f3d08f076f7bec6d4
Author: tjhunt <tjhunt>
Date:   Fri, 17 Aug 2007 18:01:34 +0800
Tag:    v1.9.0

MDL-10863 - multichoice question type won't upgrade to 1.9 beta because MySQL sometimes treats enum constants case-insensitively.

commit af999b909531568a727464358870c9484f7d4493
Author: tjhunt <tjhunt>
Date:   Fri, 17 Aug 2007 17:59:54 +0800
Tag:    v1.9.0

Temporary fix for MDL-9356 becuase it was blocking a bug I needed to fix. Eloy, please review carefully when you get back from holiday.

commit 2288211e7cdaa7aedb1ce5e79bd2648f951ba8ae
Author: tjhunt <tjhunt>
Date:   Thu, 16 Aug 2007 00:22:54 +0800
Tag:    v1.9.0

MDL-10841 - show all feedback to multiple choice questions on the review page.

commit 583e93ca2764cf64827f2674657895b1ca44d576
Author: tjhunt <tjhunt>
Date:   Wed, 15 Aug 2007 21:43:27 +0800
Tag:    v1.9.0

Clarify comment.

commit a462602a06e60ff505849131b258c242a43a5ed3
Author: tjhunt <tjhunt>
Date:   Wed, 15 Aug 2007 20:45:23 +0800
Tag:    v1.9.0

MDL-10858 - Edit field sizes for overall feedback are silly. Merged from MOODLE_18_STABLE.

commit 1e05bf54b2fc6c600e37d3866a9bf680ea8578b6
Author: tjhunt <tjhunt>
Date:   Wed, 15 Aug 2007 20:06:21 +0800
Tag:    v1.9.0

Space beteen category name and count.

commit acda04bfb93c28210c32a9191a786fb12812c220
Author: tjhunt <tjhunt>
Date:   Tue, 14 Aug 2007 21:33:39 +0800
Tag:    v1.9.0

MDL-10834 - Restore of quiz module may create calendar events without a date/time. Fix thanks to Derek Woolhead. Merged from MOODLE_17_STABLE.

commit dc5c68519e7ac8a2b931bfadb69ad86e54dbb27a
Author: tjhunt <tjhunt>
Date:   Mon, 13 Aug 2007 19:19:51 +0800
Tag:    v1.9.0

Notice on quiz config.html page.

commit d402153a54cdfb82173b4f745bf5aeec62e9e2e7
Author: tjhunt <tjhunt>
Date:   Fri, 10 Aug 2007 23:22:28 +0800
Tag:    v1.9.0

MDL-10581 - Each attemtp builds on last & multi-page quizzes was casuing grading errors. Merged from MOODLE_18_STABLE.

commit ceeae340f993ac7c99aa0c6a670dba038ce36016
Author: tjhunt <tjhunt>
Date:   Fri, 10 Aug 2007 23:21:29 +0800
Tag:    v1.9.0

MDL-10799 - Question types do not accurately determine whether their state has changed or not. Merged from MOODLE_18_STABLE.

commit a8bb516dce3cd120e066939530abad20e1a76dfe
Author: tjhunt <tjhunt>
Date:   Fri, 10 Aug 2007 20:21:55 +0800
Tag:    v1.9.0

lang files in plugin folder support for gradebook plugin types.

commit da3802dbaeafc84018e23c2400027ec73a45051c
Author: tjhunt <tjhunt>
Date:   Fri, 10 Aug 2007 18:48:58 +0800
Tag:    v1.9.0

MDL-10786 - Short Answer questions will not allow 0 as the sole answer. Merged from MOODLE_18_STABLE.

commit df4c79e23214fda60bbf3a7ebdc2e8b72ea8ad7c
Author: tjhunt <tjhunt>
Date:   Fri, 10 Aug 2007 18:37:30 +0800
Tag:    v1.9.0

Accessing wrong field of $mod from course.modinfo. Merged from MOODLE_17_STABLE.

commit 37d00ed467fb21a407a82c5f32ccb9353964aa79
Author: tjhunt <tjhunt>
Date:   Fri, 10 Aug 2007 18:00:06 +0800
Tag:    v1.9.0

Fix notice.

commit e3fa6587ee45ca8117996ca1ba895e1bb89daa40
Author: tjhunt <tjhunt>
Date:   Thu, 09 Aug 2007 23:38:35 +0800
Tag:    v1.9.0

Helper method to help when calling print_error from a question type.

commit 215bd82630701159baf3d0f103737aeec2ac2c02
Author: tjhunt <tjhunt>
Date:   Thu, 09 Aug 2007 17:00:30 +0800
Tag:    v1.9.0

Fix typo. Thanks to Adriane Boyd.

commit f5e9cb1e9c2585655d17f8121f00cb5ae39d9fef
Author: tjhunt <tjhunt>
Date:   Wed, 08 Aug 2007 19:30:50 +0800
Tag:    v1.9.0

MDL-10759 - Bogus get_context_instance call in quiz_print_recent_mod_activity. Merged from MOODLE_17_STABLE.

commit 727e38b0b262bc236a4ca190c0d680826141db60
Author: tjhunt <tjhunt>
Date:   Tue, 07 Aug 2007 20:39:32 +0800
Tag:    v1.9.0

MDL-10737 - Increase size of short answer text entry box. Merged from MOODLE_18_STABLE.

commit 3d3867b69ad735f0aed422b7c27673b5dece179d
Author: tjhunt <tjhunt>
Date:   Mon, 06 Aug 2007 22:10:46 +0800
Tag:    v1.9.0

MDL-10730 - After submitting a question in adaptive mode, go back to that question, not the top of the page. Code thanks to Tony Gardner-Medwin, based on my suggestion.

commit 0675e5eb8fce362cb98d062ac34d6224a095f862
Author: tjhunt <tjhunt>
Date:   Mon, 06 Aug 2007 21:22:59 +0800
Tag:    v1.9.0

MDL-9519 - incorrectuse of language strings in quiz. Merged from MOODLE_18_STABLE.

commit 90a36f8cdf22098a3e6128609117e94721b498aa
Author: tjhunt <tjhunt>
Date:   Fri, 03 Aug 2007 22:26:46 +0800
Tag:    v1.9.0

MDL-10709 - Shortanswer resonses should be trimmed before being saved in the database. Merged from MOODLE_18_STABLE.

commit 99ebfea2471c1bd83fe3aa6fe38c779b4732f259
Author: tjhunt <tjhunt>
Date:   Fri, 03 Aug 2007 18:33:29 +0800
Tag:    v1.9.0

MDL-10690 - Make quiz name a manditory field. Merged from MOODLE_18_STABLE.

commit 3a41f324cc274766a6746b82394e8dc942d4fb66
Author: tjhunt <tjhunt>
Date:   Thu, 02 Aug 2007 00:54:39 +0800
Tag:    v1.9.0

Fix notices on the admin page.

commit d349d4f0e12b3e22d125e820817aa2dc048e384d
Author: tjhunt <tjhunt>
Date:   Tue, 31 Jul 2007 06:14:32 +0800
Tag:    v1.9.0

MDL-10661 - another bloody invisiblefieldset bug. Merged from MOODLE_18_STABLE.

commit 5fceb049cc33424bfa8ad2420d81e0efb286c6d8
Author: tjhunt <tjhunt>
Date:   Tue, 31 Jul 2007 01:04:46 +0800
Tag:    v1.9.0

Use of get_html_head_contributions was causing unwanted interaction bewteen question types. Switched to using a class variable.

commit de266537a75f5665f73edbde49c497690e6d7049
Author: tjhunt <tjhunt>
Date:   Mon, 30 Jul 2007 18:33:43 +0800
Tag:    v1.9.0

MDL-10300 - cleaning incorrectly applied to overall feedback.

commit 00719c02d66fca180334d22b4e0cf781a8ef4c27
Author: tjhunt <tjhunt>
Date:   Mon, 30 Jul 2007 18:05:11 +0800
Tag:    v1.9.0

MDL-10656 - Way to control when Overall feedback is displayed, independantly of the other sorts of feedback. Also, improve the layout of those settings on the quiz editing form.

commit 46ee31748dbd22172323a8bd9ed39191e67159b6
Author: tjhunt <tjhunt>
Date:   Mon, 30 Jul 2007 17:41:31 +0800
Tag:    v1.9.0

Change the config.html form to match changes made in mod_form ages ago. Oops!

commit 9fd26d104208584ada3677cab3555365ca79f1b3
Author: tjhunt <tjhunt>
Date:   Mon, 30 Jul 2007 17:36:39 +0800
Tag:    v1.9.0

Eliminate commented code.

commit bb7053f3d839fc23288221c832d617250116c346
Author: tjhunt <tjhunt>
Date:   Fri, 27 Jul 2007 19:31:34 +0800
Tag:    v1.9.0

MDL-10627 - "No message plugins installed" warning on admin page on head

commit a2cd1ed6ff1cb0c84a58f7c9abbda2af781e9905
Author: tjhunt <tjhunt>
Date:   Fri, 27 Jul 2007 19:05:34 +0800
Tag:    v1.9.0

MDL-10626 - Change HTML of checkboxes etc., to make it easier to style forms

commit a4bcb27f0e14e428c12af90ca7518eb696bfdd03
Author: tjhunt <tjhunt>
Date:   Fri, 27 Jul 2007 17:24:20 +0800
Tag:    v1.9.0

Improvements to sql_bitand, etc. so that the caller does not have to worry about operator precidence.

commit d5ab1b0cf44c43b6caf54b645548f778b6609603
Author: tjhunt <tjhunt>
Date:   Thu, 26 Jul 2007 20:04:34 +0800
Tag:    v1.9.0

Minor tidyup.

commit 8995ddda2aac7b9cf4f061af429c9339114b6e09
Author: tjhunt <tjhunt>
Date:   Thu, 26 Jul 2007 19:39:04 +0800
Tag:    v1.9.0

MDL-10619 - Quiz password form does not work.

commit be161556ce5598448c4e255a1f370b05650ab455
Author: tjhunt <tjhunt>
Date:   Thu, 26 Jul 2007 01:08:41 +0800
Tag:    v1.9.0

OU Bug 2867 - Overview report keeps forgetting the 'Display options' settings. Merged MOODLE_18_STABLE.

commit 33dfb53e0964ddf7594859f20951ed295d47e9d8
Author: tjhunt <tjhunt>
Date:   Wed, 25 Jul 2007 20:34:21 +0800
Tag:    v1.9.0

Fix whitespace.

commit 362b172c188988b7f88b9a6fb7e0a178cb14eb9a
Author: tjhunt <tjhunt>
Date:   Wed, 25 Jul 2007 20:01:57 +0800
Tag:    v1.9.0

Tabs to spaces.

commit e344003ad67c544b57c1f314982d9ce723652f45
Author: tjhunt <tjhunt>
Date:   Wed, 25 Jul 2007 01:17:52 +0800
Tag:    v1.9.0

MDL-10589 - make the forum subscribe link a post form button.

commit 40ce63cbb7b2f51e9b06935ae12950457c795d38
Author: tjhunt <tjhunt>
Date:   Wed, 25 Jul 2007 01:06:29 +0800
Tag:    v1.9.0

MDL-10588 - refactor the code for printing the 'subscribe/unsubscribe from this forum' link into one place.

commit 962d013395c3de97e468d11abb3a3c9f9bd1d2ca
Author: tjhunt <tjhunt>
Date:   Tue, 24 Jul 2007 18:43:23 +0800
Tag:    v1.9.0

Oops, typo in one half of the previous commit. See, that is why duplicated code is bad for maintenance!

commit 49b53f26e021b4a170c15ca0ae0d3d415b61f3c4
Author: tjhunt <tjhunt>
Date:   Tue, 24 Jul 2007 18:39:10 +0800
Tag:    v1.9.0

Elimintate duplicated code and simplify some logic. Ironically, do it twice in two separate places, becuase there is some more large-scale code duplication in this file that I am not even going to attempt to fix.

commit 3a5e1d064eabe0d58a9d4ec82b832880a1a95e51
Author: tjhunt <tjhunt>
Date:   Tue, 24 Jul 2007 18:37:00 +0800
Tag:    v1.9.0

Get rid of pointless 'TODO document' comments.

commit a7a8973866963c8b5bb3bf8b273c0d4406eb2599
Author: tjhunt <tjhunt>
Date:   Tue, 24 Jul 2007 17:10:21 +0800
Tag:    v1.9.0

MDL-10533 - forum search results were having format_text applied twice, which was breaking things like glossary links.

commit 9d308cb4d064eba13ee88eef0a4fb8900c8aba4b
Author: tjhunt <tjhunt>
Date:   Tue, 24 Jul 2007 00:54:16 +0800
Tag:    v1.9.0

Improve javadocs.

commit 21976af149373ddcc394acf04e67250ce67b84ed
Author: tjhunt <tjhunt>
Date:   Tue, 24 Jul 2007 00:00:36 +0800
Tag:    v1.9.0

Starting work on MDL-10533 - Eliminate one totally evil abuse of $SESSION. Also, document forum_print_post.

commit 5aed30094db1ba16241b27fc580495bc5ca67263
Author: tjhunt <tjhunt>
Date:   Mon, 23 Jul 2007 22:55:35 +0800
Tag:    v1.9.0

Fix whitespace, and round times to the previous multiple of the 'step' option, if necessary.

commit 606f71c97d9b8af109e698e7075834cd86c493f2
Author: tjhunt <tjhunt>
Date:   Sat, 21 Jul 2007 01:40:09 +0800
Tag:    v1.9.0

Fix whitespace.

commit bfbafdfe746935d1ff0a90b9b77613fa4ad9d108
Author: tjhunt <tjhunt>
Date:   Sat, 21 Jul 2007 01:10:35 +0800
Tag:    v1.9.0

MDL-7925 - it happened again. Stupid bloodly forms lib. I have no idea what it was playing at. Merged from MOODLE_18_STABLE.

commit 5d5ae618a823b281a23b3e1394a434f1e8fa41e0
Author: tjhunt <tjhunt>
Date:   Fri, 20 Jul 2007 00:51:17 +0800
Tag:    v1.9.0

MDL-8056 - one if statement was missed during Matt Clarkson's/Eloy's commit on 15th July 2007. Merged from MOODLE_18_STABLE

commit e584e7c84e3dba0652015d61fe86f2c45c75df90
Author: tjhunt <tjhunt>
Date:   Thu, 19 Jul 2007 18:27:54 +0800
Tag:    v1.9.0

Improve display of preview attemtp summary on quiz view page.

commit b60af635df537f1ebdd16a3b052fe65e254b4f02
Author: tjhunt <tjhunt>
Date:   Wed, 18 Jul 2007 21:57:24 +0800
Tag:    v1.9.0

MDL-10515 - Change HTML to make it easier to style multiple choice questions. Merged from MOODLE_18_STABLE

commit 4f2c86ad81fe931183dc7130215d46df58766085
Author: tjhunt <tjhunt>
Date:   Tue, 17 Jul 2007 23:27:59 +0800
Tag:    v1.9.0

OU bug 3463 - warnings when you start an attempt in 'each attempt builds on last' mode.

commit 46a29ccfec2bdfd1016fdf6c7ab043c2faefac65
Author: tjhunt <tjhunt>
Date:   Mon, 16 Jul 2007 21:32:52 +0800
Tag:    v1.9.0

Add id="responseform" to the question preview form tag, to match the quiz form, to make life easier for Javascript on questions. Idea thanks to Adriane Boyd.

commit efe256e4a91a483bbcb5431eef5c7aa0dbd9a92b
Author: tjhunt <tjhunt>
Date:   Mon, 16 Jul 2007 21:23:13 +0800
Tag:    v1.9.0

Stop the 'remove rqp' environment message from appearing after the question type is gone.

commit ed8bebce5a65ea12891d402ab2f28aaf7d058f36
Author: tjhunt <tjhunt>
Date:   Fri, 13 Jul 2007 23:58:42 +0800
Tag:    v1.9.0

MDL-10452 - start quiz UI is confusing if you have quiz:preview capability. Change the 'start/continue attempt button' to say 'start/continue preview' in this case. Merged from MOODLE_17_STABLE.

commit 99a1bf3d9c59b06e0081114999afa862c892f9ce
Author: tjhunt <tjhunt>
Date:   Sat, 07 Jul 2007 00:37:06 +0800
Tag:    v1.9.0

MDL-10374 - Quiz layout improvements, selectively merged from OU-moodle.

commit 604a618428e2943ae0336fd73bbb2c98ea1eb443
Author: tjhunt <tjhunt>
Date:   Fri, 06 Jul 2007 21:30:16 +0800
Tag:    v1.9.0

Fix notice in essay question.

commit 21988c8e20e5b4c00a52927079d2c195baba899c
Author: tjhunt <tjhunt>
Date:   Fri, 06 Jul 2007 19:29:25 +0800
Tag:    v1.9.0

Small improvement to print_table. Lets you apply a class attribute to particular table rows.

commit b0972c0593eeb6725f125f334613c6799239d025
Author: tjhunt <tjhunt>
Date:   Fri, 06 Jul 2007 16:20:07 +0800
Tag:    v1.9.0

MDL-648 - minor corrections.

commit bb4598fcf7156b999a1c83eceae1887cbca7f01a
Author: tjhunt <tjhunt>
Date:   Mon, 02 Jul 2007 14:48:50 +0800
Tag:    v1.9.0

Quiz time limit field: Store it in the DB as an int(10), like the other time-related columns. Also, include the unit (minutes) in the forum label.

commit ac48e43a896d1a6315c38e3aac5a3c5f0d327cb8
Author: tjhunt <tjhunt>
Date:   Wed, 27 Jun 2007 00:34:05 +0800
Tag:    v1.9.0

MDL-648 - Email notification and confirmation when quizzes are submitted. Thanks to Graham Miller for implementing this to my design.

commit d53587d822972d59a747dfb9bedf8783e00c41df
Author: tjhunt <tjhunt>
Date:   Wed, 27 Jun 2007 00:16:46 +0800
Tag:    v1.9.0

MDL-10250 - Extend get_users_by_capability to have a $useviewallgroups parameter.

commit d19bd4d0420c542e3fbee56ddba0de6b93434c80
Author: tjhunt <tjhunt>
Date:   Tue, 26 Jun 2007 01:13:52 +0800
Tag:    v1.9.0

Clean up whitespace. Merged from MOODLE_18_STABLE.

commit 11ac5c3ef7754fe4cb27178302c474f0788270ac
Author: tjhunt <tjhunt>
Date:   Sun, 24 Jun 2007 19:53:07 +0800
Tag:    v1.9.0

MDL-10237 - Improve wording on true/false edit form. Merged from MOODLE_18_STABLE.

commit ccac7305eadd321c5dac5a84bcf7feca0d182695
Author: tjhunt <tjhunt>
Date:   Sat, 23 Jun 2007 18:39:28 +0800
Tag:    v1.9.0

Make a library function for deleting quiz attempts, rather than having duplicated code - Followup: make sure we only delete preview attempts. Merged from OU Moodle.

commit dc1fd03d6d492d9d59577a139ef15d14fa0d3412
Author: tjhunt <tjhunt>
Date:   Fri, 22 Jun 2007 23:05:42 +0800
Tag:    v1.9.0

MDL-10198 - Further refinements.

commit 0ec4fb87e36b6617dc8f0a05c966fdae3dfdc528
Author: tjhunt <tjhunt>
Date:   Fri, 22 Jun 2007 22:07:35 +0800
Tag:    v1.9.0

Improve and simplify question layout.

commit f9108f58ded5906da54dd9408ed98822aa8fd4db
Author: tjhunt <tjhunt>
Date:   Fri, 22 Jun 2007 21:46:00 +0800
Tag:    v1.9.0

MDL-10213 - layuout problem for question in IE in Moodle 1.7. I'm taking the opportunity to clean up the CSS in 1.8 and HEAD to match what I did in 1.7. Merged from MOODLE_18_STABLE.

commit 96f3629bd52a626cca88a79b044b9d2cde6163d5
Author: tjhunt <tjhunt>
Date:   Fri, 22 Jun 2007 00:21:47 +0800
Tag:    v1.9.0

MDL-7772 - improve the SQL for showing users without attemtps. Merged from MOODLE_18_STABLE.

commit 82f61686083b2f08c5e0d8989d1a1424b875355b
Author: tjhunt <tjhunt>
Date:   Thu, 21 Jun 2007 23:53:00 +0800
Tag:    v1.9.0

Improve CSS for question layout.

commit 4a5b91b48f6faff62faace69d9be38ba5ed8e476
Author: tjhunt <tjhunt>
Date:   Thu, 21 Jun 2007 23:46:26 +0800
Tag:    v1.9.0

Improved the HTML for essay questions.

commit 8356aa7af117e1a4ed1ee1d0d5483ba6511e8be2
Author: tjhunt <tjhunt>
Date:   Thu, 21 Jun 2007 23:43:29 +0800
Tag:    v1.9.0

MDL-10198 - Further refinements to $forcedownload.

commit 11d7a2ab81ccbf221771616666956fe3c08f9abd
Author: tjhunt <tjhunt>
Date:   Thu, 21 Jun 2007 23:28:42 +0800
Tag:    v1.9.0

Fix minor JavaScript error in the quiz.

commit 91075d6894b8a555cad9fe32ae9439933c051060
Author: tjhunt <tjhunt>
Date:   Thu, 21 Jun 2007 19:41:16 +0800
Tag:    v1.9.0

MDL-10198 - Further refinements from Adriane Boyd.

commit 816552399202568bfd1641992fa90557f4f274bd
Author: tjhunt <tjhunt>
Date:   Thu, 21 Jun 2007 00:18:37 +0800
Tag:    v1.9.0

Put information about which quiz and page in the URL for attempt.php, instead of in hidden form fields. Merged from OU Moodle.This makes things a little more robust in some situations, for example you can bookmark a page half way through a quiz attempt to make it easier to get back later.

commit 14e6dc791a23b7e15166b4ca092800fa85615dc6
Author: tjhunt <tjhunt>
Date:   Wed, 20 Jun 2007 23:12:36 +0800
Tag:    v1.9.0

MDL-10198 - New code to allow files from quiestion attempts to be stored in moodledata and later downloaded. Code thanks to Adriane Boyd, but checked and modified by me, so we share the blamewink

commit 7a6f4066cee03e8db752a66d667d91b9b28f9ea5
Author: tjhunt <tjhunt>
Date:   Wed, 20 Jun 2007 06:17:47 +0800
Tag:    v1.9.0

MDL-6043 - Implement course reset function for quizzes.

commit 38dbf2c4ed4eb6ed6f2c6d0d7fc97b56d58bb41d
Author: tjhunt <tjhunt>
Date:   Wed, 20 Jun 2007 00:35:54 +0800
Tag:    v1.9.0

Notices from T/F question is you submit without answering in adaptive mode. Merged from OU Moodle.

commit ca9000df6fb64c7224236e7d74a8b753b3eb4956
Author: tjhunt <tjhunt>
Date:   Wed, 20 Jun 2007 00:33:16 +0800
Tag:    v1.9.0

Fix typo in a comment.

commit 194ce154d3bdac118037d4aacd1274ec8c5974cb
Author: tjhunt <tjhunt>
Date:   Tue, 19 Jun 2007 17:43:28 +0800
Tag:    v1.9.0

Fix layout of quiz reports in groups mode - Merged from OU Moodle.

commit ff51d64621b6ccf8aed95998745f8b00a4a16bd7
Author: tjhunt <tjhunt>
Date:   Tue, 19 Jun 2007 00:19:00 +0800
Tag:    v1.9.0

Make a library function for deleting quiz attempts, rather than having duplicated code. Merged from OU Moodle.

commit 294e63eadd0c49ed829c055111c15e08ab56d789
Author: tjhunt <tjhunt>
Date:   Fri, 15 Jun 2007 19:02:47 +0800
Tag:    v1.9.0

Make it possible for question types to do file uploads.

commit c746ce0d033f3648fbd0b48e993d7fecdd6e55e6
Author: tjhunt <tjhunt>
Date:   Fri, 15 Jun 2007 18:42:11 +0800
Tag:    v1.9.0

Fix whitespace.

commit bc301dc93a2a9a43f1765f9deb8778fd6df672d0
Author: tjhunt <tjhunt>
Date:   Fri, 15 Jun 2007 18:42:02 +0800
Tag:    v1.9.0

Remove unused variable.

commit d0e88092e944e50568e28f5670c68064a1d25a01
Author: tjhunt <tjhunt>
Date:   Fri, 15 Jun 2007 18:25:09 +0800
Tag:    v1.9.0

MDL-10130 - Thanks to Adriane Boyd.

commit eedb2494edc092ef5cb64713057a4f8ca3e7b99f
Author: tjhunt <tjhunt>
Date:   Fri, 15 Jun 2007 18:24:29 +0800
Tag:    v1.9.0

Fix whitespace.

commit b5c2f0afffab966941d3d7350621a904719b1ad1
Author: tjhunt <tjhunt>
Date:   Tue, 12 Jun 2007 21:47:21 +0800
Tag:    v1.9.0

Fix typo spotted by Eclipse.

commit da1cc34073d03eb57ef958490f951e5e807eeb88
Author: tjhunt <tjhunt>
Date:   Tue, 12 Jun 2007 19:13:49 +0800
Tag:    v1.9.0

MDL-10089 - Cannot delete questions from question bank - Thanks to Adriane Boyd for the fix.

commit e765b5d37794954f9bac2184043e61af234a579f
Author: tjhunt <tjhunt>
Date:   Tue, 12 Jun 2007 19:11:42 +0800
Tag:    v1.9.0

Improve doc comments on get_context_* funcitions.

commit ed66fb1390ae70110684e641b84446489118b3d7
Author: tjhunt <tjhunt>
Date:   Tue, 12 Jun 2007 00:42:13 +0800
Tag:    v1.9.0

MDL-9996 - Multiple choice answer box too small in the question editing form in Moodle 1.8. Merged from MOODLE_18_STABLE.

commit 1e95d7b7a31d82648847e2ee7aecbb5dc8a8da72
Author: tjhunt <tjhunt>
Date:   Fri, 08 Jun 2007 00:04:23 +0800
Tag:    v1.9.0

OU Bug 3246 - No logs shown when a group is selected. Merged from OU Moodle. Merged from MOODLE_18_STABLE.

commit 0be701047435bdeed8918391b32792c52751acd4
Author: tjhunt <tjhunt>
Date:   Thu, 07 Jun 2007 23:40:08 +0800
Tag:    v1.9.0

Fix logging of course settings updates.

commit edf3ef00a74540fcaebf1de058afbbcf5ac1c543
Author: tjhunt <tjhunt>
Date:   Thu, 07 Jun 2007 23:33:56 +0800
Tag:    v1.9.0

Make code slightly more robust, merged from MOODLE_18_STABLE.

commit 453db696ada1ab498e6f8da2d827719f0a2480d1
Author: tjhunt <tjhunt>
Date:   Thu, 07 Jun 2007 00:02:19 +0800
Tag:    v1.9.0

Accessibility - make it clear to screen-reader users that the question number is a quesiton number.

commit 18dfa59377b788605270ce75afaedc5b2a48691c
Author: tjhunt <tjhunt>
Date:   Tue, 05 Jun 2007 22:56:12 +0800
Tag:    v1.9.0

Eliminate trailing whitespace.

commit 2ac5177aff60e92bbb9c3e6ca1ab2fa4e447daa7
Author: tjhunt <tjhunt>
Date:   Sun, 03 Jun 2007 15:26:54 +0800
Tag:    v1.9.0

MDL-10006 - Sorting the quiz overview report on feedback breaks it. Merged from MOODLE_18_STABLE.

commit 699a472b5b560e7dd7bb60ae49685a0186cc85ea
Author: tjhunt <tjhunt>
Date:   Fri, 01 Jun 2007 21:52:36 +0800
Tag:    v1.9.0

Remove invalid unit test.

commit 6e9debfbf19cfb158c03238eca391fb3fb346438
Author: tjhunt <tjhunt>
Date:   Fri, 25 May 2007 01:25:37 +0800
Tag:    v1.9.0

Removing remaining references to RQP in core code. I had not realised there were so many.

By the way, I am committing this from a pub in York. Pub's with wireless, whatever next?

commit 5114a1ac012bc819ea65f59dd0d3d095eea42531
Author: tjhunt <tjhunt>
Date:   Thu, 24 May 2007 15:44:08 +0800
Tag:    v1.9.0

Small cleanup to remove duplicated code.

commit 8b192edbc1fad03ea43454752c1e2ec49e3ba673
Author: tjhunt <tjhunt>
Date:   Thu, 24 May 2007 15:42:27 +0800
Tag:    v1.9.0

Comment improvements.

commit dcb784c5dee57aae66ac0e8cedddf55fd30df9f7
Author: tjhunt <tjhunt>
Date:   Wed, 23 May 2007 18:52:16 +0800
Tag:    v1.9.0

XHTML strict. Fix entity. Merged from MOODLE_18_STABLE.

commit 19faed1ab3bdba3913123d40770356f68cf35145
Author: tjhunt <tjhunt>
Date:   Wed, 23 May 2007 18:21:43 +0800
Tag:    v1.9.0

MDL-9914 - Can't download mark details from the quiz overview report. Merged from MOODLE_18_STABLE.

commit 214f6330f95371d8ddd71e24cd922a4f6c13508c
Author: tjhunt <tjhunt>
Date:   Tue, 22 May 2007 22:04:06 +0800
Tag:    v1.9.0

MDL-9881 - Attempting to delete large number of questions fails due to long URL - Merged from MOODLE_18_STABLE.

commit 5d852ba111960aa7f4af5f21720adc4e71ae5d56
Author: tjhunt <tjhunt>
Date:   Tue, 22 May 2007 21:25:31 +0800
Tag:    v1.9.0

When using DEBUG_DEVELOPER, make error(...) output a stack trace.

commit d1f2b9e130871538decbfde9cf717299818140cd
Author: tjhunt <tjhunt>
Date:   Tue, 22 May 2007 21:24:51 +0800
Tag:    v1.9.0

Switch a form from post to get, since that is more appropriate.

commit 2c89cfb533c1ab3cab99eecc751c11bd848595d2
Author: tjhunt <tjhunt>
Date:   Fri, 04 May 2007 18:04:20 +0800
Tag:    v1.9.0

Matching qestion type was failing to correctly determine wheterh the student had changed their answer - further improvements. Merged from MOODLE_18_STABLE.

commit b186cb9d863f68b33e1872457d7564c4dce143c6
Author: tjhunt <tjhunt>
Date:   Tue, 01 May 2007 15:03:52 +0800
Tag:    v1.9.0

Fix all the PHP syntax errors in this code. I can't think of any valid reason for checking code with that many syntax errors into CVS, especially when there are plenty of editors out there that check the syntax for you and highlight the errors.

Also, can I point out that Moodle coding guidelines require spaces for indents, not tabs. (http://docs.moodle.org/en/Development:Coding)

commit ce5f45783e258f3f0e459f996a65644ddd414bf6
Author: tjhunt <tjhunt>
Date:   Sat, 28 Apr 2007 01:43:03 +0800
Tag:    v1.9.0

MDL-9616 - tidy up * add a better message in the table for these checks. * improve existing strings for other types of check. * remove a line of debug code.

commit facc83a83af3ff9cf21d7500542ad454aa92c0d8
Author: tjhunt <tjhunt>
Date:   Sat, 28 Apr 2007 01:41:38 +0800
Tag:    v1.9.0

Get the strings the right way round!

commit bac40536f4db7b10fff6cad23f331c259e4379bd
Author: tjhunt <tjhunt>
Date:   Sat, 28 Apr 2007 01:15:24 +0800
Tag:    v1.9.0

MDL-9616 - Custom checks in environment.xml

commit 571da767884f845b42c19397352f6d1b91702cc8
Author: tjhunt <tjhunt>
Date:   Fri, 27 Apr 2007 19:18:08 +0800
Tag:    v1.9.0

MDL-6368 and MDL-6369 - supplimental - I missed one bit.

commit 8e652f025b6a47ced718625dd80b89d5d595437d
Author: tjhunt <tjhunt>
Date:   Fri, 27 Apr 2007 19:05:57 +0800
Tag:    v1.9.0

Insufficient error checking was causing problems.

commit 0eb6b04a7352f693ac37f627fcc3af88dfaabf4d
Author: tjhunt <tjhunt>
Date:   Fri, 27 Apr 2007 18:37:39 +0800
Tag:    v1.9.0

New capability for configuring question types.

commit d4bf4b86957c48d8fa248f68b847daca30e58956
Author: tjhunt <tjhunt>
Date:   Fri, 27 Apr 2007 18:37:21 +0800
Tag:    v1.9.0

Fix syntax error.

commit ab0a8ff22cd5e50a500dc06a64633b67e4114618
Author: tjhunt <tjhunt>
Date:   Fri, 27 Apr 2007 16:33:11 +0800
Tag:    v1.9.0

MDL-9608 - Work around Firefox putting the user's password in the quiz password field. Merged from MOODLE_18_STABLE.

commit 27987cbb7804984aa57c17c7880723d169e971d3
Author: tjhunt <tjhunt>
Date:   Thu, 26 Apr 2007 02:20:04 +0800
Tag:    v1.9.0

Eliminate support for old-style question editing forms.

commit e3aea79afed703f2bf89700374945fd6282710dd
Author: tjhunt <tjhunt>
Date:   Thu, 26 Apr 2007 01:59:53 +0800
Tag:    v1.9.0

MDL-9565 - Fix error in previous commit. Merged from MOODLE_18_STABLE.

commit 5df53d00827d891af8034d052b9eba11408021a1
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 23:45:24 +0800
Tag:    v1.9.0

* Fix layout problem on password form. (invisiblefieldset). 
* Question state fixes: 
  + Don't change from EVENTOPEN too soon. 
  + Make sure all questions get closed at the end of the attempt in adaptive mode. 
* Get rid of the delay on the redirect when you submit all and finish.

commit 5a56d93857ea7a64c72737ee0b134ffafad19c28
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 23:37:01 +0800
Tag:    v1.9.0

Clean up whitespace.

commit b10e17ecb4c0aa4f3d7d53c4a78e063c864a5a19
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 23:31:34 +0800
Tag:    v1.9.0

New lang string for clarifying quiz UI.

commit 47e16978146c570ef97b910ba17c6bfccfbaff9e
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 19:20:22 +0800
Tag:    v1.9.0

The question core code was restricting question types unnecessarily. This is a temporary fix, prior to a proper refactoring.

commit 7375c542cf40c11e90bdd0dbba572fb46ea409eb
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 07:39:22 +0800
Tag:    v1.9.0

Clean up whitespace.

commit ed0ba6da04eadfffeec88560e594c7ab91839d46
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 07:37:32 +0800
Tag:    v1.9.0

Occasional unique-key violations were caused by some really weird code to do with units in numerical questions. This cleans it up.

commit 295043c21cb79d116face245e854136d000da1a9
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 07:31:41 +0800
Tag:    v1.9.0

Base class methods preparitory to deleting a lot of essentially duplicated code from the various question types.

commit 53a4d39f1cdbc75ba034d3f383fff0637bf477c4
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 07:26:48 +0800
Tag:    v1.9.0

Clean up whitespace.

commit 06d20c2429d018923f8b3865ce63e3a350fb5fce
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 07:25:33 +0800
Tag:    v1.9.0

Clean up trailing whitespace.

commit 732c472fca76c898944b9a98d2b83acdf496cb3f
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 07:23:25 +0800
Tag:    v1.9.0

Remove duplicate $Id$

commit cb354a653c87da69414d307b35e162bb35f0b2ac
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 05:16:14 +0800
Tag:    v1.9.0

Fix comedy require_once. Merged from MOODLE_16_STABLE.

commit 2d05b47209461dee49734dbc41713fd84fccfe7a
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 01:32:21 +0800
Tag:    v1.9.0

MDL-6368 and MDL-6369 - allow question type plugins to easily provide some bits of Javascript and CSS - I forgot about the review page.

commit 5ea4af22109afd81036f23ceeed8499800ccac17
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 01:09:12 +0800
Tag:    v1.9.0

Stop "Undefined variable: ALLOWED_TAGS" errors all over the place.

commit 7d87171ba946c5faa18e8f5d8d0d19e0f9f0af33
Author: tjhunt <tjhunt>
Date:   Wed, 25 Apr 2007 00:59:32 +0800
Tag:    v1.9.0

MDL-9565 - Question preview links don't work in developer debug mode, and not XHTML strict. Merged from OU Moodle.

commit fe76ab50067e498a2ac18b21bb0db236e9463f91
Author: tjhunt <tjhunt>
Date:   Tue, 24 Apr 2007 00:23:17 +0800
Tag:    v1.9.0

MDL-9389 - True / False penalty factor field redundant. Merged from MOODLE_18_STABLE.

commit 7c77033fb6234ce225744b045e1a2d7e4e92bbf3
Author: tjhunt <tjhunt>
Date:   Tue, 24 Apr 2007 00:19:25 +0800
Tag:    v1.9.0

MDL-9524 - Formslib gets confused if a required field is frozen. Merged from MOODLE_18_STABLE.

commit fe6480283c883c224116cb65241c3857ebdca76a
Author: tjhunt <tjhunt>
Date:   Mon, 23 Apr 2007 21:55:22 +0800
Tag:    v1.9.0

MDL-9447 - Default grade field is redundant in embeded answer (Cloze) question. Merged from MOODLE_18_STABLE.

commit e3b2eb60e1828941f4fe11fc75717cdd65635e5d
Author: tjhunt <tjhunt>
Date:   Fri, 20 Apr 2007 01:37:14 +0800
Tag:    v1.9.0

MDL-9432 - Forgot to return success/failure in two places.

commit 0d6f26503481a67028acb9cc6322637fc2834d25
Author: tjhunt <tjhunt>
Date:   Fri, 20 Apr 2007 01:16:20 +0800
Tag:    v1.9.0

Fix error message to say the right thing.

commit c85607f0be348967e1eedaad08c2943c45079a6a
Author: tjhunt <tjhunt>
Date:   Wed, 18 Apr 2007 23:56:21 +0800
Tag:    v1.9.0

MDL-9432 - When restoring questions, links are not recoded. Merged from OU moodle.

commit 3e0647ffaf2c81224b6f7d2ed24d5188888fcfb5
Author: tjhunt <tjhunt>
Date:   Sat, 14 Apr 2007 05:16:04 +0800
Tag:    v1.9.0

MDL-9342 - Let the question author choose how the options are numbered in Multiple choices questions.

commit 3509094e655086f187aa2b37058b09b07908e2c9
Author: tjhunt <tjhunt>
Date:   Sat, 14 Apr 2007 00:25:10 +0800
Tag:    v1.9.0

Remove blank line at start of file.

commit c73189115fb18d83d1244144ee1b908db0abcad5
Author: tjhunt <tjhunt>
Date:   Fri, 13 Apr 2007 18:03:10 +0800
Tag:    v1.9.0

Work round PHP4 being a stinking pile of crap.

commit 0558f04745fa44045742bd3f9c1b0c9c7306ea1d
Author: tjhunt <tjhunt>
Date:   Fri, 13 Apr 2007 16:12:08 +0800
Tag:    v1.9.0

Reveted Nick's alleged typo fix.

Thank you very much for trying to fix my code, but your change is definitely wrong. get_context_instance needs to be passed a coursemoduleid, not a coursemodule object.

Why did you think there was a typo?

And neither of us had noticed that I had left some debug code in. Removing that.

commit b423cff11a834a2b0db44099998330e18381876d
Author: tjhunt <tjhunt>
Date:   Fri, 13 Apr 2007 06:16:47 +0800
Tag:    v1.9.0

MDL-9325 - mod/quiz:ignoretimelimits does not work.

This is a really horrific short-term fix to a problem not of my making.
Merged from MOODLE_18_STABLE.

commit 15aa9df95811a2a153d99c5fef3aed5c763a6f9b
Author: tjhunt <tjhunt>
Date:   Fri, 13 Apr 2007 04:11:27 +0800
Tag:    v1.9.0

MDL-5799 - quiz previews were sometimes showing up in the quiz overview report. Merged from MOODLE_18_STABLE.

commit 99ba746d29d428b4b442061243d0ff39ca90dda4
Author: tjhunt <tjhunt>
Date:   Thu, 12 Apr 2007 23:58:32 +0800
Tag:    v1.9.0

MDL-6368 and MDL-6369 - allow question type plugins to easily provide some bits of Javascript and CSS.

commit dcc2ffde6323003a4c2390748bc37e1767b1fd12
Author: tjhunt <tjhunt>
Date:   Thu, 12 Apr 2007 06:57:46 +0800
Tag:    v1.9.0

MDL-9082 - moodle/question:manage does not let you create questions. Also: 
 * remove useless option from print_question_icon 
 * use the right module context in question_list 
 * a bit of XHTML strrrict in question_list 
Merged from MOODLE_18_STABLE.

commit add2d7acdfda262578fead2a57236c4f3d29f2df
Author: tjhunt <tjhunt>
Date:   Thu, 12 Apr 2007 05:21:06 +0800
Tag:    v1.9.0

MDL-9244 - From Moodle 1.9 onwards, don't support question types that have not updated and provided a moodleform for editing.

commit 807ae30aaa5d153442930ce61cdbf259324bc2ec
Author: tjhunt <tjhunt>
Date:   Thu, 12 Apr 2007 04:38:02 +0800
Tag:    v1.9.0

MDL-9079 - Paging broken in quiz overview report. Merged from MOODLE_17_STABLE.

commit 86ccf19cdbaf8e33d4a4e23672a78a15011d11c7
Author: tjhunt <tjhunt>
Date:   Thu, 12 Apr 2007 04:07:36 +0800
Tag:    v1.9.0

MDL-9280 - JavaScript countdown timer did not work in 1.8 due to XHTML strict changes.
Also, fixing a few more XHTML strrrrict things in attempt.php.
Merged from MOODLE_18_STABLE.

commit 54074fb872db6a1bac18491159dc0fd1a946dcbb
Author: tjhunt <tjhunt>
Date:   Thu, 12 Apr 2007 03:04:52 +0800
Tag:    v1.9.0

MDL-9303 - General Feedback not shown for essay questions on review screen. Merged from MOODLE_17_STABLE.

commit 26d12a0c1616aa42e70e48852a2ca2cba747e685
Author: tjhunt <tjhunt>
Date:   Tue, 10 Apr 2007 22:37:36 +0800
Tag:    v1.9.0

quiz/locallib.php clean up:  * Tidy up comment layout.  * Strip trailing whitespace.

commit 50d7b53ecb253b844138d12da51b0350c5d35d2f
Author: tjhunt <tjhunt>
Date:   Tue, 10 Apr 2007 22:27:56 +0800
Tag:    v1.9.0

attempt.php refactor.  * Move all output code to the end.  * Make comment style consistent.  * Trim trailing whitespace from lines.

commit dc6c8ca1ac492fb58f1647a0062bc7d678cd45a9
Author: tjhunt <tjhunt>
Date:   Tue, 10 Apr 2007 21:02:09 +0800
Tag:    v1.9.0

Minor cleanups to the quiz code.

commit 7d014bf58251fb0cf4f03f58af906bf29835ba55
Author: tjhunt <tjhunt>
Date:   Thu, 05 Apr 2007 21:54:20 +0800
Tag:    v1.9.0

MDL-9224 - Score sometimes relealed, even when the quiz settings say it should not be. Merged from OU Moodle.

commit 1b16ecd1ca92b5215fd1dd2494eea114824b5c13
Author: tjhunt <tjhunt>
Date:   Thu, 05 Apr 2007 02:01:36 +0800
Tag:    v1.9.0

MDL-9208 - Only hightlight the correct answer if that option is set.

commit 288731fa09fbd412735ea433782beaa7d4214b64
Author: tjhunt <tjhunt>
Date:   Thu, 05 Apr 2007 00:51:10 +0800
Tag:    v1.9.0

Bug 2951 - correct PARAM_ types for answers to multichoice and shortanswer questions. Merged from OU Moodle.

commit b3396fe91dbb373930786671994197e5a7f59b61
Author: tjhunt <tjhunt>
Date:   Wed, 04 Apr 2007 23:30:41 +0800
Tag:    v1.9.0

MDL-9183 - yet another invisiblefieldset causing layout problems. Merged from MOODLE_18_STABLE.

commit 5081e0a635ad3bae93f63ab32dddd9f95cd37b47
Author: tjhunt <tjhunt>
Date:   Tue, 03 Apr 2007 16:34:39 +0800
Tag:    v1.9.0

Better way to detect whether a function exists in this version of PHP before redefining it.

commit 1aa7b31dd95ed5ff115f83cb2032fe1557e66ae6
Author: tjhunt <tjhunt>
Date:   Mon, 02 Apr 2007 23:28:43 +0800
Tag:    v1.9.0

Make sure print_object output is always left-aligned. Also, make it look more like other debugging output.

commit 7d0763a0082138e7ff7c0da64af0f7b16b788c16
Author: tjhunt <tjhunt>
Date:   Mon, 02 Apr 2007 23:26:31 +0800
Tag:    v1.9.0

Missing format_string. Merged from MOODLE_18_STABLE.

commit d95c82ab59680c53db1aadc40d5b83a94baadd96
Author: tjhunt <tjhunt>
Date:   Mon, 02 Apr 2007 21:02:09 +0800
Tag:    v1.9.0

MDL-9173 - Can't create match anything answer to numerical question type. Merged from OU Moodle.

commit b388c7664db1d4e5cc5bce89e7267dac38dd2091
Author: tjhunt <tjhunt>
Date:   Mon, 02 Apr 2007 06:19:39 +0800
Tag:    v1.9.0

Another attempt to get redirect() to not redirect if an error was output to the screen, to make dubuggin easier. Sorry I had not noticed the bit in the docs that says error_get_last was PHP 5.2.0+.

commit 9523cbfcef4ea7bae0b2185691e2fdb8c5f8a7a6
Author: tjhunt <tjhunt>
Date:   Fri, 30 Mar 2007 18:17:16 +0800
Tag:    v1.9.0

Small code cleanup to fix an obscure warning. If you got an error in the middle of creating a quiz attempt, you could get an attempt with no states. Then that caused an error when the attempt was deleted. Merged from MOODLE_17_STABLE.

commit 46e910c7cd121b6bc7f9223dfc0ee506bc32d230
Author: tjhunt <tjhunt>
Date:   Fri, 30 Mar 2007 17:34:05 +0800
Tag:    v1.9.0

Fix notice. Merged from MOODLE_17_STABLE.

commit 77b2b1fa4333b782a70188badb4ef38226e51205
Author: tjhunt <tjhunt>
Date:   Fri, 30 Mar 2007 07:12:08 +0800
Tag:    v1.9.0

MDL-9107 (regression from) MDL-8994 - adding random questions to a quiz was broken. Merged from MOODLE_18_STABLE.

commit b63c5b590588c75d71e95df5383625513432d118
Author: tjhunt <tjhunt>
Date:   Fri, 30 Mar 2007 07:00:48 +0800
Tag:    v1.9.0

MDL-9094 - Penalty factor is meaningless for Essay questions, so remove it from the editing form. Manual merge of the corresponding change from MOODLE_17_STABLE.

commit fb708c1130e42d16e6f99ce6858bb54e9080a99f
Author: tjhunt <tjhunt>
Date:   Fri, 30 Mar 2007 00:36:16 +0800
Tag:    v1.9.0

MDL-6269, MDL-8958, MDL-8990 - Major fix to do with each attempt builds on last:

commit a6b691d84d459f96e635fbd2fbd71924e491e426
Author: tjhunt <tjhunt>
Date:   Fri, 30 Mar 2007 00:05:55 +0800
Tag:    v1.9.0

Add developer debugging to something that should not happen, and fix one instance of it.

commit 71248ce89ee8095ca3ed6696c31f676d45d5cbe9
Author: tjhunt <tjhunt>
Date:   Thu, 29 Mar 2007 00:57:22 +0800
Tag:    v1.9.0

MDL-9061 - Only show global assign roles warning if you are assigning roles in the global context! Also, change name of admin menu entry to reduce confusion. Merged from MOODLE_18_STABLE.

commit 88495aa8d296a218623d1bf9dfcb915f77bf8c00
Author: tjhunt <tjhunt>
Date:   Fri, 23 Mar 2007 07:02:14 +0900
Tag:    v1.9.0

Followup to MDL-8994 - validate the category id we got from the form. Merged from MOODLE_18_STABLE.

commit bc67d9b3bdc9fe64509822759ba3d4a4553fee09
Author: tjhunt <tjhunt>
Date:   Fri, 23 Mar 2007 06:31:39 +0900
Tag:    v1.9.0

MDL-7241 - Manual grading report, sort by completed time didn't. Merged from MOODLE_16_STABLE.

commit 6fd3300925fbc11090862d25b975de1851b42e5e
Author: tjhunt <tjhunt>
Date:   Fri, 23 Mar 2007 01:43:48 +0900
Tag:    v1.9.0

Make debugging more helpful by printing a full stack trace.

commit 6a5e9a8506ccfb9c5a0ed30556612383a13a93e2
Author: tjhunt <tjhunt>
Date:   Thu, 22 Mar 2007 20:46:15 +0900
Tag:    v1.9.0

MDL-9004 - Breadcrumb trail is wrong when editing a quiz question. Merged from MOODLE_18_STABLE.

commit 6000365ee4076a1a0bc88ec03b66bd71a7fe4195
Author: tjhunt <tjhunt>
Date:   Thu, 22 Mar 2007 09:10:47 +0900
Tag:    v1.9.0

MDL-8994 - Question category selector on the question type editing forms is ignored. Merged from MOODLE_18_STABLE.

commit 4fa684477e1d36b44ea71533880e996b5bd0229c
Author: tjhunt <tjhunt>
Date:   Thu, 22 Mar 2007 08:25:33 +0900
Tag:    v1.9.0

MDL-7259 - Item analysis report does not use the right format_text settings. Merged from MOODLE_16_STABLE.

commit dd46d88e2723c9afe99bca7830d3b0e5b6f550dd
Author: tjhunt <tjhunt>
Date:   Thu, 22 Mar 2007 08:04:51 +0900
Tag:    v1.9.0

Fix whitespace problems and Eclipse warnings in Item Analysis quiz report.

commit c2f8c4be5f32338fe24e4d71ba9fe51e6eac408d
Author: tjhunt <tjhunt>
Date:   Thu, 22 Mar 2007 02:12:50 +0900
Tag:    v1.9.0

Improve string handling in the question type base class. Merged from MOODLE_18_STABLE.

commit d187f6604699f20fa88f5fa584bbd81043a34286
Author: tjhunt <tjhunt>
Date:   Wed, 21 Mar 2007 19:41:28 +0900
Tag:    v1.9.0

MDL-8946 - Fix a regression that broke question export.

Also, partially clean up the way that question bank navigation tabs are printed, so the code is not duplicated in the quiz.

Some other miscellaneous code cleaning too.

Merged from MOODLE_18_STABLE.

commit 77fa3a0dad5d4cfd7a6d137172b6adcd3a30bbe0
Author: tjhunt <tjhunt>
Date:   Wed, 21 Mar 2007 09:19:24 +0900
Tag:    v1.9.0

MDL-8978 - Regression from MDL-6386. Merged from MOODLE_16_STABLE.

commit 121609d80a5b4c79fcbfb1a39968911642f2b927
Author: tjhunt <tjhunt>
Date:   Wed, 21 Mar 2007 07:45:19 +0900
Tag:    v1.9.0

MDL-8299 - Wrong capability on review.php. Merged from MOODLE_18_STABLE.

commit 93c80e1c0eca2a52731958141ca59628c2b6ef64
Author: tjhunt <tjhunt>
Date:   Wed, 21 Mar 2007 07:23:56 +0900
Tag:    v1.9.0

MDL-8140 Other units disappear from the editing form when there is no unit with multiplier 1. Merged from MOODLE_18_STABLE.

commit 8745405435904b0e9020c0fe7c86532623f8b96b
Author: tjhunt <tjhunt>
Date:   Wed, 21 Mar 2007 00:06:48 +0900
Tag:    v1.9.0

MDL-4084 Backup all question categories in a course, not just the ones from which questions are used in a quiz. Merged from MOODLE_18_STABLE.

commit 1f8db780916610c2c9e1ed08625b7479362989e5
Author: tjhunt <tjhunt>
Date:   Tue, 20 Mar 2007 23:30:44 +0900
Tag:    v1.9.0

MDL-6386/MDL-6462 - yet more special character issues with multianswer. I think I have got them all this time.

commit b25486fc72061f8e00bcda431131ecb00d9d7124
Author: tjhunt <tjhunt>
Date:   Tue, 20 Mar 2007 23:06:56 +0900
Tag:    v1.9.0

Matching qestion type was failing to correctly determine wheterh the student had changed their answer.

commit 4323d02959144b1210ef81b14560d1579668d701
Author: tjhunt <tjhunt>
Date:   Tue, 20 Mar 2007 02:22:46 +0900
Tag:    v1.9.0

Give the question bank code sensible PHPdocumentor package names.

commit e51efd7ea7544255f8c4483b344a2ac031152763
Author: tjhunt <tjhunt>
Date:   Thu, 15 Mar 2007 21:59:10 +0900
Tag:    v1.9.0

MDL-6462 - Cloze (multianswer) question special character issues. Merged from MOODLE_16_STABLE.

commit 779d35f1438976493cb3f441623c8a1b4be9b110
Author: tjhunt <tjhunt>
Date:   Thu, 15 Mar 2007 21:52:50 +0900
Tag:    v1.9.0

Fix notice.

commit d2ab4956936c58edcd95a3fe0c30a6bbcfef6863
Author: tjhunt <tjhunt>
Date:   Thu, 15 Mar 2007 06:24:44 +0900
Tag:    v1.9.0

MDL-8127 - bad use of DESCRIPTION constant in quiz module causes upgrade to fail. Thanks to Pavel Krejci for the fix. Merged from MOODLE_17_STABLE.

commit 277e551b882820a77a488a850d78b5b0916d748f
Author: tjhunt <tjhunt>
Date:   Thu, 15 Mar 2007 06:10:55 +0900
Tag:    v1.9.0

Oops, reverting. Eloy had already fixed it.

commit 2099d05dec0cc5de9c86073a2736da3d34766955
Author: tjhunt <tjhunt>
Date:   Thu, 15 Mar 2007 06:07:37 +0900
Tag:    v1.9.0

MDL-8232 - can't use = on TEXT colums with MSSQL - was breaking numerical question type upgrade.

commit 6cad9e60699916499e4e43488d1455f94aab1b03
Author: tjhunt <tjhunt>
Date:   Thu, 15 Mar 2007 05:15:20 +0900
Tag:    v1.9.0

MDL-8772 - Use the same list of places to search in get_string and help.php. Merged from MOODLE_18_STABLE.

commit 3eb89b9997ff865f024ff2b5765c63845f7414ed
Author: tjhunt <tjhunt>
Date:   Thu, 15 Mar 2007 00:29:46 +0900
Tag:    v1.9.0

Notice when a student attempts a quiz, because there are no tabs to display. Merged from MOODLE_18_STABLE.

commit 69945f899eed30f4a021defdf38924c23e7738c4
Author: tjhunt <tjhunt>
Date:   Wed, 14 Mar 2007 20:33:08 +0900
Tag:    v1.9.0

Fix typo

commit e1a3af61a338efc3480afe440937ed1fe204174b
Author: tjhunt <tjhunt>
Date:   Wed, 14 Mar 2007 02:42:57 +0900
Tag:    v1.9.0

Eliminate bizarre use of function_exists.

commit 0c6b4d2e81728bbefb826f4c9ce347333aae6d44
Author: tjhunt <tjhunt>
Date:   Wed, 14 Mar 2007 01:27:24 +0900
Tag:    v1.9.0

Entity decoding only done the right number of times on import, not once too often. Also, fix a notice and and Eclipse warning.

commit 5b0dc681ad7b3ddb952db304aa8d362a86f29f4d
Author: tjhunt <tjhunt>
Date:   Wed, 14 Mar 2007 01:24:13 +0900
Tag:    v1.9.0

Use the right string processing when outputting question text on import/export.

commit 70ed76670e18e9ea9c862ed629b28f4c58ceee7f
Author: tjhunt <tjhunt>
Date:   Wed, 14 Mar 2007 01:20:41 +0900
Tag:    v1.9.0

Use the right string processing functions when outputting question names.

commit 42be916421b358e8c08cc071c0732a752277f77b
Author: tjhunt <tjhunt>
Date:   Mon, 12 Mar 2007 20:39:47 +0900
Tag:    v1.9.0

Comitting language string for Pierre Pichet.

commit 5dba65907b7284284ab37d8043c5c22161a674e1
Author: tjhunt <tjhunt>
Date:   Sat, 10 Mar 2007 09:34:05 +0900
Tag:    v1.9.0

MDL-8177 - Random questions selected deleted questions. Merged from MOODLE_18_STABLE.

commit c2f51fe3bebf89b47e9c29428b0d58a010748afc
Author: tjhunt <tjhunt>
Date:   Fri, 09 Mar 2007 23:33:50 +0900
Tag:    v1.9.0

Groups upgrade fails if you have groups defined, but none of them contain any members.

commit 08eef20df4718892e51d656eb10bc1ade8f95fe9
Author: tjhunt <tjhunt>
Date:   Wed, 07 Mar 2007 03:00:23 +0900
Tag:    v1.9.0

MDL-8349 - responses not being filtered in history display. Merged from MOODLE_18_STABLE.

commit 06565ec739249eda740229f87bf1103a4054cc36
Author: tjhunt <tjhunt>
Date:   Tue, 06 Mar 2007 16:57:22 +0900
Tag:    v1.9.0

Add a couple more plugin types to get_string that Martin missed yesterday.

commit b030a630c0eb83556db755b09eb160c7c9ff0939
Author: tjhunt <tjhunt>
Date:   Tue, 06 Mar 2007 03:05:51 +0900
Tag:    v1.9.0

MDL-8764 - In menus, show question categories from this course first, then published categories from other courses. Merged from MOODLE_18_STABLE.

commit 31f6834e366ef1497bcc65d5bb0c10a41d152905
Author: tjhunt <tjhunt>
Date:   Fri, 02 Mar 2007 01:47:55 +0900
Tag:    v1.9.0

Fix upgrade that MySQL could not cope with.

commit 341e99513b01ae260283b9bef3980b41cdfae7dd
Author: tjhunt <tjhunt>
Date:   Fri, 02 Mar 2007 01:42:39 +0900
Tag:    v1.9.0

Make error messages non-ambiguous. Merged from MOODLE_18_STABLE.

commit 8388ade86599558181729cdc95bd24a842fdfcf8
Author: tjhunt <tjhunt>
Date:   Fri, 02 Mar 2007 01:42:36 +0900
Tag:    v1.9.0

Make error messages non-ambiguous. Merged from MOODLE_18_STABLE.

commit 3ed998f343dc5629157718aa615a7b4ccd20f790
Author: tjhunt <tjhunt>
Date:   Thu, 01 Mar 2007 18:45:53 +0900
Tag:    v1.9.0

MDL-6773 - eliminate duplicate code for getting a list of question categories. Merged from MOODLE_18_STABLE.

commit b9ea2b7ad5c93888ffcf70a1446de9488c903fa9
Author: tjhunt <tjhunt>
Date:   Thu, 01 Mar 2007 02:19:04 +0900
Tag:    v1.9.0

Add a unique index to the question_numerical_units table, to prevent duplicate units being created.

commit a24a414f248ddc417114d63e3c4eab639a3fac6b
Author: tjhunt <tjhunt>
Date:   Thu, 01 Mar 2007 02:18:28 +0900
Tag:    v1.9.0

When restoring numerical questions, don't create duplicate unit definitions. Merged from MOODLE_18_STABLE.

commit 51e89d95f7e454aa517193cbe9b9ec8dd1fe4f8e
Author: tjhunt <tjhunt>
Date:   Thu, 01 Mar 2007 02:17:40 +0900
Tag:    v1.9.0

Improve validation code to match the recent improvements in shortanswer validation.

commit 2cb16d8f9be3788cbf75bd61232a208d7805ce50
Author: tjhunt <tjhunt>
Date:   Thu, 01 Mar 2007 02:15:45 +0900
Tag:    v1.9.0

Minor improvement to validation code. Merged from MOODLE_18_STABLE.

commit c349b0518141481952d39feb1b2d94d0a8d2425d
Author: tjhunt <tjhunt>
Date:   Thu, 01 Mar 2007 00:34:56 +0900
Tag:    v1.9.0

XHTML Strrrrrrict!

commit 3023608c83a30d3cebd3c4ef5abd62fbd21497a1
Author: tjhunt <tjhunt>
Date:   Thu, 01 Mar 2007 00:21:35 +0900
Tag:    v1.9.0

Bug with editing essay questions.

commit 7919952cf74af8b9810752b101f30796447df18f
Author: tjhunt <tjhunt>
Date:   Thu, 01 Mar 2007 00:16:01 +0900
Tag:    v1.9.0

Remove CVS conflict markers.

commit a0807a00913c0942fc9e1e529c1d76f642989186
Author: tjhunt <tjhunt>
Date:   Wed, 28 Feb 2007 21:24:54 +0900
Tag:    v1.9.0

XHTML Strrrrrrict! on quiz module config page.

commit 645dff1cf77d2c57eb6f8a5c9aa83fcbb9189550
Author: tjhunt <tjhunt>
Date:   Wed, 28 Feb 2007 20:34:50 +0900
Tag:    v1.9.0

Correct logic for stopping people using guest access from doing quizzes. Merged from MOODLE_18_STABLE.

commit 846e7545253ac4f6e4e305993c28f70529e14b96
Author: tjhunt <tjhunt>
Date:   Wed, 28 Feb 2007 01:20:40 +0900
Tag:    v1.9.0

MDL-8671 - better checking when creating short answer questions. Fix thanks to Joseph Rzeau. Merged from MOODLE_18_STABLE.

commit 2387f332581812144e09fde1e09cc9c716dec260
Author: tjhunt <tjhunt>
Date:   Wed, 28 Feb 2007 01:20:39 +0900
Tag:    v1.9.0

MDL-8671 - better checking when creating short answer questions. Fix thanks to Joseph Rzeau. Merged from MOODLE_18_STABLE.

commit 5eb266d8aa0da1f984f2bc043148ed8fe48579f6
Author: tjhunt <tjhunt>
Date:   Tue, 27 Feb 2007 23:01:46 +0900
Tag:    v1.9.0

Improve quiz editing screen layout a little bit based on a usability suggestion in the forums.

commit 37b9e8bccc824cfdeef6f280ce3368ba632beac8
Author: tjhunt <tjhunt>
Date:   Wed, 21 Feb 2007 00:18:46 +0900
Tag:    v1.9.0

Another wretched adslashes problem. Roll on placeholder. Thanks to Howard Miller. Merged from MOODLE_18_STABLE.

commit 624cbc9c26a5f4b56083b2c1321891f0af62bc82
Author: tjhunt <tjhunt>
Date:   Tue, 20 Feb 2007 10:48:09 +0900
Tag:    v1.9.0

MDL-4793 - Option to show question text in the question bank.

Also, fix layout problems on the quiz editing screen.

Merged from MOODLE_18_STABLE.

commit b28e2577d731c2a1f09ac1c0bd4fc62b83f16be5
Author: tjhunt <tjhunt>
Date:   Mon, 19 Feb 2007 13:24:14 +0900
Tag:    v1.9.0

MDL-8145 - Add more options to the add random questions dropdown.

commit 983ce2d579d27fc723400e93263ec1c32201c861
Author: tjhunt <tjhunt>
Date:   Sun, 18 Feb 2007 02:16:38 +0900
Tag:    v1.9.0

MDL-8154 - Typo in course search code. Fix thanks to Anthony Borrow.