Git commits in Moodle 1.8.0 by jamiesensei

commit 6b344faba70b52c383c39ef86c2beaea01b5dcb0
Author: jamiesensei <jamiesensei>
Date:   Tue, 13 Mar 2007 23:46:17 +0900
Tag:    v1.8.0

small change to fix MDL-8788 which was a problem with non unique header element names

commit 68696f6aa8fa8266337588000d92ffe7f7bd44de
Author: jamiesensei <jamiesensei>
Date:   Thu, 01 Mar 2007 16:40:25 +0900
Tag:    v1.8.0

fix to MDL-8659 Impossible to create Cloze type question in Moodle 1.8 beta

commit c799044c2cfafeee5031f4300563957ecb985129
Author: jamiesensei <jamiesensei>
Date:   Mon, 26 Feb 2007 15:32:15 +0900
Tag:    v1.8.0

fix for  (MDL-8449) Quiz start and close times should allow the teacher to select a time as well as a date.

commit 8cf2a05c4a380160ccf93971148a44b9a038aa49
Author: jamiesensei <jamiesensei>
Date:   Wed, 31 Jan 2007 04:09:46 +0900
Tag:    v1.8.0

fix for misalignment of text inputs in formslib forms in ie MDL-7748

commit bc9ec4a604876718e1290b2feaaa0178ad01166c
Author: jamiesensei <jamiesensei>
Date:   Wed, 31 Jan 2007 03:44:23 +0900
Tag:    v1.8.0

more clean fix to safari issue with fieldsets

commit f60feba579c7b17a0b9248d6a3cd8ce46448855d
Author: jamiesensei <jamiesensei>
Date:   Wed, 31 Jan 2007 01:55:18 +0900
Tag:    v1.8.0

fix for bug in Safari displaying fieldsets when the last element is textarea in which case textarea tended to overlap fieldset boundary.

commit a8d2a373a184ee2c05efed0ca4738e2b5676f9a4
Author: jamiesensei <jamiesensei>
Date:   Wed, 31 Jan 2007 00:31:50 +0900
Tag:    v1.8.0

some fixes for problem reported by Pierre Pichet.

commit 9bf930bd07220475227791ff29afb1f24efd9551
Author: jamiesensei <jamiesensei>
Date:   Tue, 30 Jan 2007 16:45:15 +0900
Tag:    v1.8.0

fix related to MDL-8282 - "show advanced" button doesn't work under IE7

commit 552d35c1876f2d7d1fa055ffea12e565942d2b84
Author: jamiesensei <jamiesensei>
Date:   Thu, 25 Jan 2007 00:13:46 +0900
Tag:    v1.8.0

fixed some small typos I introduced.

commit 3a298174e8ed9c9abb6dd1cae279b0925b07d33f
Author: jamiesensei <jamiesensei>
Date:   Sun, 21 Jan 2007 19:32:42 +0900
Tag:    v1.8.0

important security fix previous use of ['type'] in repeatedeloptions array would not have worked.

commit 658772186af91c901c640ea78f20ac2cc36120e1
Author: jamiesensei <jamiesensei>
Date:   Sun, 21 Jan 2007 18:26:33 +0900
Tag:    v1.8.0

some small changes

commit 988d1202e31c7e75ca5e74500a8d28055d7e2e92
Author: jamiesensei <jamiesensei>
Date:   Sun, 21 Jan 2007 18:23:19 +0900
Tag:    v1.8.0

fixed focus method which was tring to focus on hidden fields.

commit 5054ddbb59e24c5524098291165bd9b4a2a98079
Author: jamiesensei <jamiesensei>
Date:   Sun, 21 Jan 2007 18:14:35 +0900
Tag:    v1.8.0

comment got detached from function - fixed.

commit f84d6a8d5606a9d1cb095ff9b4f745d9424617b5
Author: jamiesensei <jamiesensei>
Date:   Sun, 21 Jan 2007 17:26:59 +0900
Tag:    v1.8.0

fixes to wiki form checkboxes value saving

commit 0e8d6a3e9efdc1fd6d22b33a0c6a9f1a356b0017
Author: jamiesensei <jamiesensei>
Date:   Fri, 19 Jan 2007 22:05:54 +0900
Tag:    v1.8.0

MDL-7780 Choose legend/header text carefully - short and non-repeated

commit c0ae32d9ff12123838ca0d2ae719d5fdc57c1236
Author: jamiesensei <jamiesensei>
Date:   Fri, 19 Jan 2007 20:35:12 +0900
Tag:    v1.8.0

made some changes to user/edit.php setAdvanced and header name changes for MDL-7780

commit ec3dac9876d283dbca20a8b74cd274cd5c91e10b
Author: jamiesensei <jamiesensei>
Date:   Fri, 19 Jan 2007 20:10:09 +0900
Tag:    v1.8.0

fixes for 'Choose legend/header text carefully - short and non-repeated' MDL-7780

commit 642b2ab1820f425337a3179fcbc6e05c3093d330
Author: jamiesensei <jamiesensei>
Date:   Fri, 19 Jan 2007 20:06:05 +0900
Tag:    v1.8.0

fixed problem with helpbuttons appearing below the label on static and frozen elements.

commit d4039c7262a495aa38505a0b6c42b3c3d76a017f
Author: jamiesensei <jamiesensei>
Date:   Fri, 19 Jan 2007 19:35:00 +0900
Tag:    v1.8.0

fix for syntax error trying to call hardFreeze on element instead of form object.

commit 549b26b33965af382828cdb4db9459632634d5b2
Author: jamiesensei <jamiesensei>
Date:   Fri, 19 Jan 2007 17:10:01 +0900
Tag:    v1.8.0

migrated wiki form to formslib

commit 7043d0a756125d56de4200776ab8bf858e95debc
Author: jamiesensei <jamiesensei>
Date:   Fri, 19 Jan 2007 17:08:50 +0900
Tag:    v1.8.0

set default for this element to return a '0' if unchecked and '1' if checked.

commit cfa73a95519eac9ee387dda65f00542c5b30ae1d
Author: jamiesensei <jamiesensei>
Date:   Fri, 19 Jan 2007 16:21:51 +0900
Tag:    v1.8.0

answer '0' is a valid answer for a numeric question.

commit 845b703bb9a45046008208cbf450c304bf097ed1
Author: jamiesensei <jamiesensei>
Date:   Fri, 19 Jan 2007 16:20:43 +0900
Tag:    v1.8.0

oops. fix to last commit about empty answers logic was wrong

commit b7d4df606ebfd8c81f8106d6561075b150fe4a1a
Author: jamiesensei <jamiesensei>
Date:   Fri, 19 Jan 2007 16:18:26 +0900
Tag:    v1.8.0

fix for erroneous empty answer detection when answer is '0' which is a valid answer for numeric qs.

commit 7b41a4a98924230c0f460a7d99ff09bcc2f61d84
Author: jamiesensei <jamiesensei>
Date:   Thu, 18 Jan 2007 20:21:10 +0900
Tag:    v1.8.0

some more small changes to datasetdependent and calculated question type forms

commit 71534002d01814ac8bc85e6d6718ba1887178adb
Author: jamiesensei <jamiesensei>
Date:   Thu, 18 Jan 2007 19:22:56 +0900
Tag:    v1.8.0

migrated 'missingtype' questoin creation forms to use formslib

commit 60b5ecd3cf29cc4898f9958d75220e9d18d8b3af
Author: jamiesensei <jamiesensei>
Date:   Thu, 18 Jan 2007 03:28:51 +0900
Tag:    v1.8.0

more work on the datasetdependent / calculated question creation forms

commit a7f7e52fc5cd6385365725abb46bcee9da0fa553
Author: jamiesensei <jamiesensei>
Date:   Wed, 17 Jan 2007 00:36:33 +0900
Tag:    v1.8.0

changed name of moodleform_mod method 'defaults_preprocessing' to 'data_preprocessing' in line with change of set_defaults name to set_data.

commit fa3bf11d0229f92c01a1289a762cbd77e9327f31
Author: jamiesensei <jamiesensei>
Date:   Mon, 15 Jan 2007 19:39:43 +0900
Tag:    v1.8.0

removed print_object that got left in here

commit 8fc3e643ae4be846947370eea9957f12de230d93
Author: jamiesensei <jamiesensei>
Date:   Sat, 13 Jan 2007 17:59:00 +0900
Tag:    v1.8.0

more work on the calculated and datasetdependent qtype

commit 9958e84f3c751b1fcee291daf2bb00084974608f
Author: jamiesensei <jamiesensei>
Date:   Fri, 12 Jan 2007 18:41:21 +0900
Tag:    v1.8.0

removed condition 'if ($userupdate) {' (ie if user has capability moodle/user:update) then freeze fields locked  by admin / auth plug ins. Now fields are always frozen.

commit 98af2d1dc31235d8ae7b5fccef80de024986bbf2
Author: jamiesensei <jamiesensei>
Date:   Fri, 12 Jan 2007 17:36:24 +0900
Tag:    v1.8.0

small fix in hardFreeze

commit 3c19571fedd318046d17c0e182358bc02beeaca4
Author: jamiesensei <jamiesensei>
Date:   Fri, 12 Jan 2007 17:22:56 +0900
Tag:    v1.8.0

just amended some of the set_defaults stuff

commit acc9c3e037339c76f52452fb1812a11be571e532
Author: jamiesensei <jamiesensei>
Date:   Fri, 12 Jan 2007 15:19:39 +0900
Tag:    v1.8.0

added hardFreeze method and used it in edit_form.php it ensures frozen elements have persistantFreeze property set to false.

commit ccbef0e2b76644610230c33e603a0a47e6564f6d
Author: jamiesensei <jamiesensei>
Date:   Fri, 12 Jan 2007 14:07:22 +0900
Tag:    v1.8.0

moved set_defaults to main script out of definition method.

commit 0ffb4cc703d0181428b712fb26ae97e5de1ec68f
Author: jamiesensei <jamiesensei>
Date:   Fri, 12 Jan 2007 13:36:02 +0900
Tag:    v1.8.0

special handling of frozen fields - frozen elements pass the default value (set by set_defaults or setDefault) and ignore submitted data in data_submitted()

commit 92186abc95c61cefc09aad945c135a0e89012f5f
Author: jamiesensei <jamiesensei>
Date:   Thu, 11 Jan 2007 13:59:16 +0900
Tag:    v1.8.0

working on multipage form for calculated question type

commit 0709d4d5f5cf168bc6b4ff304dae3a22a91d47d5
Author: jamiesensei <jamiesensei>
Date:   Thu, 11 Jan 2007 13:57:57 +0900
Tag:    v1.8.0

some xhtml validity fixes for the case that select and text elements are 'frozen'

commit 8c2550c87a004e5eeacb128eca7d1f9d3dd447f5
Author: jamiesensei <jamiesensei>
Date:   Wed, 10 Jan 2007 15:46:12 +0900
Tag:    v1.8.0

moved header printing so it is only printed when displaying a form.

commit 87391656a38d8c02d9b5d20ba9b686b05c9780c6
Author: jamiesensei <jamiesensei>
Date:   Wed, 10 Jan 2007 15:40:42 +0900
Tag:    v1.8.0

got rid of 'Changes Saved' message before redirect.

commit 78354cec8ca382365f8ee26ff9cd7cc5187632a7
Author: jamiesensei <jamiesensei>
Date:   Wed, 10 Jan 2007 15:17:45 +0900
Tag:    v1.8.0

fixed xhtml problem in repeared header elements which had [] in id.

commit 10a3103164e06f75cb1d21a5658ead7e1e2cf1bb
Author: jamiesensei <jamiesensei>
Date:   Wed, 10 Jan 2007 14:26:22 +0900
Tag:    v1.8.0

fix for MDL-8117 - div nested in span for grouped elements in formslib - changed spans to div

commit 9aa022feef852f561b28894e1cc6033e62a66377
Author: jamiesensei <jamiesensei>
Date:   Wed, 10 Jan 2007 14:05:26 +0900
Tag:    v1.8.0

xhtml validity fix for static element type qtype calculated form - started

commit 86aab05ced2e926f52735cad7d786b39abc69350
Author: jamiesensei <jamiesensei>
Date:   Tue, 09 Jan 2007 00:53:17 +0900
Tag:    v1.8.0

fix for xhtml probs MDL-8102 and MDL-7979 - invalid id attributes. and stopped using label tag for a group of elements where the label refers to the group of elements and not an individual one.

commit 08224df157c5f6f105927ee756653dbafe5f5c77
Author: jamiesensei <jamiesensei>
Date:   Mon, 08 Jan 2007 22:58:42 +0900
Tag:    v1.8.0

migrated randomsamatch to formslib. fixed small typo in quiz mod_form

commit 24f7485b155fde06647b5bc310e11e47c9344213
Author: jamiesensei <jamiesensei>
Date:   Mon, 08 Jan 2007 19:35:57 +0900
Tag:    v1.8.0

some extra validaton for multichoice and some bug fixes for multichoice and random qtype.

commit 4a163300c8406450537ad99ebac49544da9dcd7a
Author: jamiesensei <jamiesensei>
Date:   Mon, 08 Jan 2007 18:09:39 +0900
Tag:    v1.8.0

removed redundant files after formslib conversion

commit 490d89e591e12b5dc602437b94a9b1dd8d73df5e
Author: jamiesensei <jamiesensei>
Date:   Mon, 08 Jan 2007 02:22:31 +0900
Tag:    v1.8.0

removing more redundant files after qtype form formslib migration

commit c6fc998899bbcafeaa42c8fe07f6eb4f9c78fbbc
Author: jamiesensei <jamiesensei>
Date:   Mon, 08 Jan 2007 02:06:50 +0900
Tag:    v1.8.0

more last fixes to question forms and removal of redundant files

commit 111be766b69b960a9fb785444e511ada0ecca759
Author: jamiesensei <jamiesensei>
Date:   Mon, 08 Jan 2007 01:41:06 +0900
Tag:    v1.8.0

changed implementation of advcheckbox so as to keep PEAR code seperate to Moodle code.

commit 04786f082d90c042910329eb1e729e7e1d9d52bc
Author: jamiesensei <jamiesensei>
Date:   Mon, 08 Jan 2007 01:36:38 +0900
Tag:    v1.8.0

removing redundant files after migration to formslib and some further bug fixing in question type forms.

commit cfcfddbcbfa62539f5bb133645929698b5325a4f
Author: jamiesensei <jamiesensei>
Date:   Mon, 08 Jan 2007 01:11:48 +0900
Tag:    v1.8.0

new formslib element type advcheckbox prepends a hidden element to a checkbox so a value is submitted whether the checkbox is checked or not.

commit 6e9b6ba20789b9991d1d38d1f37faa1889ab617c
Author: jamiesensei <jamiesensei>
Date:   Mon, 08 Jan 2007 01:10:42 +0900
Tag:    v1.8.0

numerical and random question type creation form migrated to formslib

commit 375ed78a93106da39de253a46e8fba1429585b94
Author: jamiesensei <jamiesensei>
Date:   Sun, 07 Jan 2007 22:54:36 +0900
Tag:    v1.8.0

fixed the MoodleQuickForm_questioncategory, question_category_options function wasn't committed so I've implemented it from question_category_select_menu code.

commit 271ffe3f254ef814fd79a133c7fedf5fb600468e
Author: jamiesensei <jamiesensei>
Date:   Sun, 07 Jan 2007 21:46:47 +0900
Tag:    v1.8.0

various formslib work including bug fixes for MDL-8039 id attribute collision between forms and page ids. Also added editor helpbutton. This is a fix for MDL-6941 need the ability to associate several helptopics with htmleditor. Also started on converting forms for question types to formslib.

commit 01ae934f23d4173e90e051d62bef8a6cb63e265c
Author: jamiesensei <jamiesensei>
Date:   Sun, 07 Jan 2007 21:11:57 +0900
Tag:    v1.8.0

renamed file and some changes to form definition etc.

commit d5307218772e33cf773458d13a39aa4deeecd2b2
Author: jamiesensei <jamiesensei>
Date:   Fri, 05 Jan 2007 16:05:54 +0900
Tag:    v1.8.0

settting first param of moodleform constructor to null tells moodleform to autodetect where to submit to

commit b07b6c81341167bf59588f38707013e7c9265094
Author: jamiesensei <jamiesensei>
Date:   Fri, 05 Jan 2007 15:47:35 +0900
Tag:    v1.8.0

added 'required' class to outermost div of form elements

commit 18a7736107923aec98ec5673e511aac084bec855
Author: jamiesensei <jamiesensei>
Date:   Fri, 05 Jan 2007 13:51:46 +0900
Tag:    v1.8.0

added helpbuttons to htmleditors where needed. Further work on htmleditor helpbutton code.

commit ff768bc57eea49aa008835f4f9ea463325dc9ee4
Author: jamiesensei <jamiesensei>
Date:   Thu, 04 Jan 2007 20:30:37 +0900
Tag:    v1.8.0

small fix to button

commit 5ce73257ab81f55a1e008db53fe2557190fcea76
Author: jamiesensei <jamiesensei>
Date:   Thu, 04 Jan 2007 19:23:06 +0900
Tag:    v1.8.0

some bug fixes in setHelpButton internals. added new editorhelpbutton function that can be used to refer to several help topics.

commit ebff6e2c5e41fb478e22704484faab60ba949f4d
Author: jamiesensei <jamiesensei>
Date:   Fri, 29 Dec 2006 01:44:47 +0900
Tag:    v1.8.0

better code formatting

commit b6d15ddef91a31f703c11f31460fd4d3b9754212
Author: jamiesensei <jamiesensei>
Date:   Fri, 29 Dec 2006 01:12:22 +0900
Tag:    v1.8.0

removed all 'Revert' buttons from forms and removed it altogether from add_action_buttons method since it was decided it didn't contribute to usability.

commit 1d284fbd8571aa20574b74004a567c8013be2b8e
Author: jamiesensei <jamiesensei>
Date:   Fri, 29 Dec 2006 00:43:47 +0900
Tag:    v1.8.0

fixing all the form names as per new class naming convention (PHP class names are also used for html id for styling)

commit f07b9627b605414282091dcd0719e9fee763c6c7
Author: jamiesensei <jamiesensei>
Date:   Thu, 28 Dec 2006 18:32:45 +0900
Tag:    v1.8.0

changes to how we generate the id attribute of forms and the naming convention of forms migrate blog edit to formslib

commit cc8cbf55916cbb3144ba4ce4891a50154b1ddb6b
Author: jamiesensei <jamiesensei>
Date:   Tue, 19 Dec 2006 20:43:32 +0900
Tag:    v1.8.0

got rid of extra help button that shouldn't have been there.

commit da43c002ff57ab4b329fa681d53c846ed8b8fae7
Author: jamiesensei <jamiesensei>
Date:   Tue, 19 Dec 2006 20:18:06 +0900
Tag:    v1.8.0

fix for MDL-7937 'Fatal error: Call to a member function on a non-object in /var/www/dev/lib/pear/HTML/QuickForm.php on line 602 error'

commit a23f0aaf9570886bf5803459f0018dd68e835328
Author: jamiesensei <jamiesensei>
Date:   Tue, 19 Dec 2006 16:03:08 +0900
Tag:    v1.8.0

* Added setAdvanced functionality see http://docs.moodle.org/en/Development:lib/formslib.php_setAdvanced * Added MoodleQuickForm method closeHeaderBefore($elementName); http://docs.moodle.org/en/Development:lib/formslib.php_Form_Definition#Use_Fieldsets_to_group_Form_Elements * Added moodleform method add_action_buttons(); see http://docs.moodle.org/en/Development:lib/formslib.php_Form_Definition#add_action_buttons.28.24cancel_.3D_true.2C_.24revert_.3D_true.2C_.24submitlabel.3Dnull.29.3B * is_cancelled method added to moodleform http://docs.moodle.org/en/Development:lib/formslib.php_Usage#Basic_Usage_in_A_Normal_Page * added hidden labels to elements within groups such as the date_selector select boxes and other elements in 'groups' * quiz/mod.html migrated to formslib * glossary/edit.html migrated to formslib * extended registerNoSubmitButton() functionality to automatically add js to onclick to bypass client side js input validation. * added no_submit_button_pressed() function that can be used in a similar way to is_cancelled() as a test in the main script to see if some button in the page has been pressed that is a submit button that is used for some dynamic functionality within the form and not to submit the data for the whole form. * added new condition for disabledIf which allows to disable another form element if no options are selected from within a select element. * added default 'action' for moodleform  - strip_querystring(qualified_me()) http://docs.moodle.org/en/Development:lib/formslib.php_Usage#Basic_Usage_in_A_Normal_Page

commit 19194f825ac32fef16b0ccafbb4acc326ee84cae
Author: jamiesensei <jamiesensei>
Date:   Thu, 14 Dec 2006 21:44:10 +0900
Tag:    v1.8.0

added setAdvanced MoodleQuickForm method. And added closeHeaderAfter method

commit fe2e0a749ed927e18f021c094c6c78e99e435524
Author: jamiesensei <jamiesensei>
Date:   Mon, 11 Dec 2006 19:10:26 +0900
Tag:    v1.8.0

fixing couple of syntax errors introduced into css

commit 84b4a843ed4a2ef1527561a6c600ac8059a35651
Author: jamiesensei <jamiesensei>
Date:   Mon, 11 Dec 2006 19:07:47 +0900
Tag:    v1.8.0

removed whitespace at the end of file causing headers already sent errors

commit 44875d78989d31fde47ee1e33781c0233bbf3476
Author: jamiesensei <jamiesensei>
Date:   Sat, 09 Dec 2006 23:06:15 +0900
Tag:    v1.8.0

added code to include hidden labels in groups in forms

commit 37601e884fd37972bcec73d2312d36747b779759
Author: jamiesensei <jamiesensei>
Date:   Sat, 09 Dec 2006 21:16:41 +0900
Tag:    v1.8.0

small change to stop elements moving down to next line in IE with 800 px width.

commit 4dd564ddb2bc0671c2e3a0b03ba36c6b0fc48a54
Author: jamiesensei <jamiesensei>
Date:   Sat, 09 Dec 2006 20:45:24 +0900
Tag:    v1.8.0

small fix to disabledIf initiation

commit 11f260f4eef7b65921a089c34027464a3fae610c
Author: jamiesensei <jamiesensei>
Date:   Sat, 09 Dec 2006 20:42:57 +0900
Tag:    v1.8.0

some changes to date_selector and date_time_selector. Now automatically disabledIf disable checkbox is checked. 'optional' option includes a disable checkbox.

commit 46e648b610cf1e0ce46d84f01ae9096365321c26
Author: jamiesensei <jamiesensei>
Date:   Thu, 07 Dec 2006 19:39:28 +0900
Tag:    v1.8.0

added Sam's 'enabled' checkbox functionality

commit dbc6607baa7d3d1521e23d3ffe48629036c43d5d
Author: jamiesensei <jamiesensei>
Date:   Thu, 07 Dec 2006 14:37:41 +0900
Tag:    v1.8.0

added some strings for labels for dateselector and datetimeselector day, month etc. elements.  These are not used yet.

commit e7004d051ac495c859f6f5f42039fe2246adbd1a
Author: jamiesensei <jamiesensei>
Date:   Tue, 05 Dec 2006 23:27:24 +0900
Tag:    v1.8.0

fix for problem of duplicated error messages, client side validation not deleting old error message before displaying new ones.

commit a2e67a9a47672837afdf5e91c96d8c341955f7d4
Author: jamiesensei <jamiesensei>
Date:   Tue, 05 Dec 2006 22:32:32 +0900
Tag:    v1.8.0

fix for error preventing adding of more choices in chat upate form

commit 0b82f5b9133d00d85ef5cb4da0175690166c4f27
Author: jamiesensei <jamiesensei>
Date:   Tue, 05 Dec 2006 22:23:18 +0900
Tag:    v1.8.0

fix for error in logic about where to redirect to after a cancel or after activity mod is successfully added or update.

commit 0befbdfd8f0d5f6a25b71e49a363c8c608fc371a
Author: jamiesensei <jamiesensei>
Date:   Tue, 05 Dec 2006 22:21:40 +0900
Tag:    v1.8.0

petr's patch to fix problem with htmlarea breaking clientside validation. Also using id's with same naming convention as formslib for htmlareas.

commit eca038b50bb1a6bf7f34efe8e5b0c1f6dc306240
Author: jamiesensei <jamiesensei>
Date:   Tue, 05 Dec 2006 20:58:43 +0900
Tag:    v1.8.0

changed name of reset element in form from 'reset' to 'resetbutton' so that the element name doesn't conflict with js form method reset.

commit 1c51317b2cc6f7fa102c86ade712d0fd0c966538
Author: jamiesensei <jamiesensei>
Date:   Mon, 04 Dec 2006 19:59:07 +0900
Tag:    v1.8.0

small change to type of returned var from is_validated()

commit 3ba2c1871e06870c48e34d673195306c6afbfe4a
Author: jamiesensei <jamiesensei>
Date:   Mon, 04 Dec 2006 19:55:50 +0900
Tag:    v1.8.0

*** empty log message ***

commit 19110c573dbb33d815d65f25ca2efa1606649b01
Author: jamiesensei <jamiesensei>
Date:   Mon, 04 Dec 2006 18:36:30 +0900
Tag:    v1.8.0

added new 'cancel' element type and introduced new is_cancelled() MoodleQuickForm method. also used new cancel button in all mod_forms as well as a 'Revert' button and reworked logic about where to go on cancel or after submission for modedit.php

commit a12034e4abf21daa1a02d0f75e0cafcfd5ef72e7
Author: jamiesensei <jamiesensei>
Date:   Fri, 01 Dec 2006 14:33:23 +0800
Tag:    v1.8.0

fixed 2 problems with css styling :

commit 67906614ad803b7aa7a066742ed4241b48d57ed9
Author: jamiesensei <jamiesensei>
Date:   Thu, 30 Nov 2006 16:47:52 +0800
Tag:    v1.8.0

now using disabledIf method in course/edit

commit d4b26b9025d5e72fbe0ec90311528c394e55bae5
Author: jamiesensei <jamiesensei>
Date:   Tue, 28 Nov 2006 23:35:22 +0800
Tag:    v1.8.0

migrated mod/exercise/mod.html to formslib

commit 4c523bed9e3bca3d279eab5f4991d5a62c865fcc
Author: jamiesensei <jamiesensei>
Date:   Tue, 28 Nov 2006 23:14:22 +0800
Tag:    v1.8.0

small change to formslib css

commit f88a9e63595b404d7f66e1c7078387405543f262
Author: jamiesensei <jamiesensei>
Date:   Tue, 28 Nov 2006 23:13:16 +0800
Tag:    v1.8.0

added help file for 'req' icon.

commit 2dbd6409323a023123e70f5abe1b987aec8c0373
Author: jamiesensei <jamiesensei>
Date:   Tue, 28 Nov 2006 16:04:00 +0800
Tag:    v1.8.0

some fixes for disabledIf and using disabledIf in course/edit_form.php

commit 49eacbe3284f5b00d8ec8231632543154ab9ff57
Author: jamiesensei <jamiesensei>
Date:   Mon, 27 Nov 2006 17:02:35 +0800
Tag:    v1.8.0

added check to see if at least two choices have been entered when setting up or updating a choice activity.

commit 74e01e62815889f87b1e5fab883201d548fe136e
Author: jamiesensei <jamiesensei>
Date:   Sat, 25 Nov 2006 00:38:22 +0800
Tag:    v1.8.0

changed name of submit buttons to submitbutton instead of sumbit as submit was conflicting with method form.submit()

commit 8e308b00c744fcfdf99f26524962d8ecb5d3d68f
Author: jamiesensei <jamiesensei>
Date:   Fri, 24 Nov 2006 20:49:32 +0800
Tag:    v1.8.0

little bit of white space cleaning up

commit 616b549a58d4d6c11aa09e91b4b5fc8750b12ae5
Author: jamiesensei <jamiesensei>
Date:   Fri, 24 Nov 2006 20:33:53 +0800
Tag:    v1.8.0

added some phpdoc comments to repeat_elements() method

commit ebd3c7ac94c775318740f4ecd09f7d8080812a8b
Author: jamiesensei <jamiesensei>
Date:   Fri, 24 Nov 2006 20:20:26 +0800
Tag:    v1.8.0

added repeat_elements method to moodleform and used method for choice form

commit e24b7f851a34b1a5d15970eb4f83876d834f82cf
Author: jamiesensei <jamiesensei>
Date:   Fri, 24 Nov 2006 14:39:15 +0800
Tag:    v1.8.0

some restructuring of formslib - moving moodleform_mod definition to new file course\moodleform_mod.php and some changes to moodleform_mod standard elements setup and moodleform disabledIf API

commit 02f8f37d5de255ce26dc1f8cbbd7edc3c02e29c0
Author: jamiesensei <jamiesensei>
Date:   Thu, 23 Nov 2006 17:38:33 +0800
Tag:    v1.8.0

added defaults for when there is no submitted data to datetimeselector and small fix for forum\mod_form.php

commit 7a3d8c602f0878eaefe0567f47efdf7897d9a66d
Author: jamiesensei <jamiesensei>
Date:   Thu, 23 Nov 2006 00:54:12 +0800
Tag:    v1.8.0

added dependencies to form

commit 9403060aacc9c5a653bf1c511d78b6b5dc00a233
Author: jamiesensei <jamiesensei>
Date:   Wed, 22 Nov 2006 23:58:07 +0800
Tag:    v1.8.0

fix for focus problem

commit abf11956f93b1c18485c39d0532a93f0f17df891
Author: jamiesensei <jamiesensei>
Date:   Wed, 22 Nov 2006 23:19:20 +0800
Tag:    v1.8.0

changed method name addDependency to disabledIf and removed data/mod.html

commit 621c4b7d8715857e40ef2ddc1e60737d8aea3e8a
Author: jamiesensei <jamiesensei>
Date:   Wed, 22 Nov 2006 19:09:24 +0800
Tag:    v1.8.0

added dependencies to form

commit d01a38cb06b4f375f4bae20c693eddeb1abbd338
Author: jamiesensei <jamiesensei>
Date:   Wed, 22 Nov 2006 16:53:35 +0800
Tag:    v1.8.0

*** empty log message ***

commit 9c03bbaa0433820a255ddcbc3a8a7b507ee33975
Author: jamiesensei <jamiesensei>
Date:   Tue, 21 Nov 2006 19:02:13 +0800
Tag:    v1.8.0

more fixes for lockoptions behaviour; changes to forum/mod_form.php; removed forum/mod.html

commit 002bd268728c464c2dc9002ad3b1d2b84a391d10
Author: jamiesensei <jamiesensei>
Date:   Tue, 21 Nov 2006 18:19:28 +0800
Tag:    v1.8.0

removed redundant return

commit 57cf1be250a8cf25410dd4fd3dafeba6226124d4
Author: jamiesensei <jamiesensei>
Date:   Tue, 21 Nov 2006 18:18:39 +0800
Tag:    v1.8.0

a bug fix for custom element dateselector

commit 4a2d352a883c6c08d6d81be25cfe46923cae3719
Author: jamiesensei <jamiesensei>
Date:   Tue, 21 Nov 2006 18:16:01 +0800
Tag:    v1.8.0

oops, removed print_object that was left in from debugging

commit 0e6303103b5dde48e97cda262e6dffff5e6c4ee2
Author: jamiesensei <jamiesensei>
Date:   Tue, 21 Nov 2006 18:14:38 +0800
Tag:    v1.8.0

fixed a couple of bugs in custom elements

commit 6e372b2591168a063301f504f90e11a4a12e3d84
Author: jamiesensei <jamiesensei>
Date:   Tue, 21 Nov 2006 17:33:48 +0800
Tag:    v1.8.0

added commenting to addDependency method and used new functionality in forum\mod_form.php

commit 50ef8eb9bd62a5d7cb13bc7d8a5df310584bb568
Author: jamiesensei <jamiesensei>
Date:   Tue, 21 Nov 2006 17:17:46 +0800
Tag:    v1.8.0

adding lockoptions functionality to formslib library and added lockoptionsall()  function which allows multiple dependencies for one dependent element and handles that properly.

commit 373503035f48e46f72cb62e7d9fc128dc418495e
Author: jamiesensei <jamiesensei>
Date:   Wed, 15 Nov 2006 15:49:43 +0800
Tag:    v1.8.0

little bit of clean up. removed extra global var and format element helpbutton is now included in element definition.

commit 5f649aaa7943b2058f2b89e6a349c5e468f23270
Author: jamiesensei <jamiesensei>
Date:   Wed, 15 Nov 2006 15:44:33 +0800
Tag:    v1.8.0

migrated mod/lesson/mod.html to formslib

commit 3c7656b4b02e35de0bfdc9a9668c4e64e0f54e23
Author: jamiesensei <jamiesensei>
Date:   Wed, 15 Nov 2006 15:40:49 +0800
Tag:    v1.8.0

added two new elements button and choosecoursefile which inherits from button

commit f388442b260e41d1dbe05dd6eeb5f30fb8800010
Author: jamiesensei <jamiesensei>
Date:   Wed, 15 Nov 2006 15:36:00 +0800
Tag:    v1.8.0

added removeOption method to allow removing options from a select drop down

commit 145dbd7cee0fff54da91beec2d991a924ab6b8eb
Author: jamiesensei <jamiesensei>
Date:   Wed, 15 Nov 2006 15:34:34 +0800
Tag:    v1.8.0

added action to redirect back to course page or to url in session var if cancel has been pressed.

commit f1e6550be28abf5d4e1c0db647f645db31071730
Author: jamiesensei <jamiesensei>
Date:   Wed, 15 Nov 2006 15:26:48 +0800
Tag:    v1.8.0

needed to add the option to pass an element id rather than a name to index.php as the choose parameter. XHTML strict doesn't allow giving a form a name attribute so we use the id of the form element to select the element to return the filename to. We use getElementById to find the element in the document.

commit 6b717125f999526be823750a03ed20a2156a3edd
Author: jamiesensei <jamiesensei>
Date:   Tue, 14 Nov 2006 14:09:36 +0800
Tag:    v1.8.0

changed width of form to 80% -aesthetic change

commit b2a0cb86d06ce778139463701684a3f95287f87a
Author: jamiesensei <jamiesensei>
Date:   Tue, 14 Nov 2006 14:01:11 +0800
Tag:    v1.8.0

migrated journal/mod.html to formslib

commit ed904dce6d920d126f3f45a707f3af1f24e93d38
Author: jamiesensei <jamiesensei>
Date:   Tue, 14 Nov 2006 13:38:10 +0800
Tag:    v1.8.0

range third parameter doesn't work pre PHP 5.0 removed the use of this.

commit cc935f9174a15bbdc442d6cd88917ebaad5eb236
Author: jamiesensei <jamiesensei>
Date:   Tue, 14 Nov 2006 13:18:39 +0800
Tag:    v1.8.0

fix for bug - not seeing standard elements on activity module form on some versions of PHP.

commit 4ea750414e5ab2bd06f4ee21972e83b003246aa5
Author: jamiesensei <jamiesensei>
Date:   Tue, 14 Nov 2006 11:00:26 +0800
Tag:    v1.8.0

add custom submit button to registry

commit c65795d3417dbd96cac0021d00daad68032ccc9d
Author: jamiesensei <jamiesensei>
Date:   Tue, 14 Nov 2006 10:57:19 +0800
Tag:    v1.8.0

checking in files for some new custom elements. And added a default help button to the format drop down box.

commit 630371c03ab2f847e3f1e4cc571c31bc80cf6af8
Author: jamiesensei <jamiesensei>
Date:   Mon, 13 Nov 2006 17:20:42 +0800
Tag:    v1.8.0

*** empty log message ***

commit d982f8797849b9115310b0c25c8ed2a8d9bdfd37
Author: jamiesensei <jamiesensei>
Date:   Mon, 13 Nov 2006 17:18:47 +0800
Tag:    v1.8.0

shifted hidden elements from standard_coursemodule_elements()  into standard_hidden_coursemodule_elements()  so that they can be included in a form without the other visible standard elements.

commit 085cfa7240a5bac04b8749b8213663ec9ecfe59c
Author: jamiesensei <jamiesensei>
Date:   Mon, 13 Nov 2006 15:56:01 +0800
Tag:    v1.8.0

removing mod.html migrated to formslib

commit a02c77dc6eec9af5332ceb42a0a22e9e81e809bd
Author: jamiesensei <jamiesensei>
Date:   Mon, 13 Nov 2006 15:52:01 +0800
Tag:    v1.8.0

glossary form migrated to formslib and other formslib forms now using $COURSE global

commit d4fe14d3e42a2bc9878e60235b3679fa72f0df52
Author: jamiesensei <jamiesensei>
Date:   Mon, 13 Nov 2006 15:43:22 +0800
Tag:    v1.8.0

some changes to setHelpButton methods on elements and MoodleQuickForm to allow non standard help buttons such as the grades pop up window.

commit e0f406840925be059ea3768714174b2c7bf4b350
Author: jamiesensei <jamiesensei>
Date:   Sun, 12 Nov 2006 19:30:12 +0800
Tag:    v1.8.0

new element type 'selectyesno' and some clean up to code for modvisible and modgroupmode elements.

commit d24206d657caeb4298d1efab03bd8c6f317a758f
Author: jamiesensei <jamiesensei>
Date:   Sun, 12 Nov 2006 19:07:12 +0800
Tag:    v1.8.0

fixed problem with select box element for 'forum type' which must sometimes display option which is otherwise unselectable.

commit da1320dab65801d09eb12780f9c7af9ce0e794d5
Author: jamiesensei <jamiesensei>
Date:   Sun, 12 Nov 2006 15:28:13 +0800
Tag:    v1.8.0

added many extra phpdoc style comments to file

commit 535e0ab6c3ab677bd48fe019469cf2926e811c81
Author: jamiesensei <jamiesensei>
Date:   Fri, 10 Nov 2006 11:04:34 +0800
Tag:    v1.8.0

migrated mod/forum/mod.html to new formslib

commit de5a83bc4574ce4bc5f5c9fa5f3860c1f78c4c4b
Author: jamiesensei <jamiesensei>
Date:   Fri, 10 Nov 2006 10:23:12 +0800
Tag:    v1.8.0

removed extra erroneous help button

commit df56998ab16a1f17a50a7ff7afc99c1e1d4778ae
Author: jamiesensei <jamiesensei>
Date:   Fri, 10 Nov 2006 09:27:51 +0800
Tag:    v1.8.0

need to pass course as customdata to form definition

commit 6403e67965f8697046360938981197170e5dacf0
Author: jamiesensei <jamiesensei>
Date:   Fri, 10 Nov 2006 03:44:20 +0800
Tag:    v1.8.0

migrated mod/data/mod.html to formslib. Still to add lockoption functionality.

commit 3cd7940b0c070391680c48dc3582456b9f6ff651
Author: jamiesensei <jamiesensei>
Date:   Fri, 10 Nov 2006 03:22:38 +0800
Tag:    v1.8.0

moved the inclusion of mod/{modname}/lib.php to before form definition so that constants in there can be used in form defintion

commit 264867fdebbdc3f028bb01d8449e19a5ba199bd2
Author: jamiesensei <jamiesensei>
Date:   Fri, 10 Nov 2006 02:25:58 +0800
Tag:    v1.8.0

add code to redirect to modedit.php from course/mod.php for activities adding / updating using new formslib migrated chat/mod.html to formslib definition of form is in chat/mod_form.php

commit e2294b982205b375ee8e23ca703f4fc897565621
Author: jamiesensei <jamiesensei>
Date:   Fri, 10 Nov 2006 02:08:34 +0800
Tag:    v1.8.0

fixes for small bugs in datetimeselector and dateselector and added custom elements to formslib library for standard module forms

commit bb40325e1bf6796c6f5870dae5d529dd7124df32
Author: jamiesensei <jamiesensei>
Date:   Wed, 08 Nov 2006 14:22:58 +0800
Tag:    v1.8.0

removed trusttext method from formslib which was unnecessary and revised trusttext use in mod/form/post.php

commit 7f42315c13924dd767e403195b6c1bf2d0faaaf1
Author: jamiesensei <jamiesensei>
Date:   Tue, 07 Nov 2006 17:16:36 +0800
Tag:    v1.8.0

whitespace clean up

commit 8adca237cf7acc9cc75067b19ef59c479775c038
Author: jamiesensei <jamiesensei>
Date:   Tue, 07 Nov 2006 17:08:08 +0800
Tag:    v1.8.0

following on from last commit to post.php removing redundant post.html and adding post_form.php new formslib form description

commit 2b63df96c3e99a69f498fd4fd0e2e7da5e235e27
Author: jamiesensei <jamiesensei>
Date:   Tue, 07 Nov 2006 16:48:18 +0800
Tag:    v1.8.0

migrated mod/forum/post.php to formslib and fixed a string in course/edit_form.php

commit 5c52df6797f3f79ef140abd2cb9389e2f250e0b0
Author: jamiesensei <jamiesensei>
Date:   Mon, 30 Oct 2006 14:27:15 +0800
Tag:    v1.8.0

changed focus when there is no error in the page to the first element in a form rather than no focus.

commit cd9f129f8162ffd28c49d7e58209ec5f36dd234d
Author: jamiesensei <jamiesensei>
Date:   Sun, 29 Oct 2006 18:19:48 +0800
Tag:    v1.8.0

added help button for format drop down

commit c3c5f0bd8635a31fd85db896892eac3202a4d861
Author: jamiesensei <jamiesensei>
Date:   Thu, 26 Oct 2006 15:59:22 +0800
Tag:    v1.8.0

migrated comment.php over to using new formslib.

commit effa85f482210f76b961669dde42b0e5c8bf22ec
Author: jamiesensei <jamiesensei>
Date:   Thu, 26 Oct 2006 15:02:20 +0800
Tag:    v1.8.0

added new form element class 'format' for adding format drop down box to forms.

commit 9e471e11655fd2048961fdb650239c1384902289
Author: jamiesensei <jamiesensei>
Date:   Tue, 24 Oct 2006 20:19:34 +0800
Tag:    v1.8.0

migrated to formslib

commit 45ca9e8e2d3c27d737118def7038a797619b1c1a
Author: jamiesensei <jamiesensei>
Date:   Tue, 24 Oct 2006 19:43:51 +0800
Tag:    v1.8.0

added autofocus on first error and moved formslib include to inside request_form.php

commit 6cd72677f6947eb23817f96714d8b3f521d552ad
Author: jamiesensei <jamiesensei>
Date:   Tue, 24 Oct 2006 19:38:33 +0800
Tag:    v1.8.0

added focus on first element with error

commit e8a34ad424646468ec6d7c19bfaa9fa8f0c653d7
Author: jamiesensei <jamiesensei>
Date:   Tue, 24 Oct 2006 19:10:48 +0800
Tag:    v1.8.0

migrated signup.php over to using new formslib

commit 2c412890455eca9923e2a9d04582a523da50f60e
Author: jamiesensei <jamiesensei>
Date:   Tue, 24 Oct 2006 19:05:50 +0800
Tag:    v1.8.0

added a method to return javascript to select form element with first error for use in focus in print_header

commit e995c46e2430f996265d2498c55333c353f36747
Author: jamiesensei <jamiesensei>
Date:   Thu, 19 Oct 2006 15:12:11 +0800
Tag:    v1.8.0

fix for : $this->_form->getElement('allowedmods')->                         updateAttributes(array('disabled' => 'disabled')) ;  that didn't work in PHP 4. (calling a method on a returned object)

commit 073fe8f980df386e9181aabf37c25c72174e199f
Author: jamiesensei <jamiesensei>
Date:   Tue, 17 Oct 2006 19:44:13 +0800
Tag:    v1.8.0

oops, forgot to set to PARAM_RAW for summary field which uses htmleditor on last commit.

commit b6241ce2c8b1a00385db6e0f56ea8e53d6963786
Author: jamiesensei <jamiesensei>
Date:   Tue, 17 Oct 2006 19:38:46 +0800
Tag:    v1.8.0

fixed some whitespace problems

commit e13cc88f021b30abc45aa3f155e3fc2386006716
Author: jamiesensei <jamiesensei>
Date:   Tue, 17 Oct 2006 19:08:13 +0800
Tag:    v1.8.0

migrated to new formslib code. Also removed $course variable which was been used in a number of places in this file but not set anywhere.

commit c08ac0162711545b8143983e69fabeaf38736094
Author: jamiesensei <jamiesensei>
Date:   Mon, 16 Oct 2006 20:07:44 +0800
Tag:    v1.8.0

added new dummy function to moodleform to allow some defintion to be done for the form dependent on data values.

commit 5bc97c98627a8373377348cf6bf03c7fcf2f9a33
Author: jamiesensei <jamiesensei>
Date:   Sat, 14 Oct 2006 20:32:31 +0800
Tag:    v1.8.0

Fixed a bug with client side validation of form fields.

commit 5da7b0b2b4058b1caeaea007b835a4745cfbcb1a
Author: jamiesensei <jamiesensei>
Date:   Thu, 12 Oct 2006 22:21:15 +0800
Tag:    v1.8.0

new edit3.php demos Petr's new API

commit c56f18269e6bc11310d90f37beda6b341b172a2c
Author: jamiesensei <jamiesensei>
Date:   Thu, 12 Oct 2006 22:15:59 +0800
Tag:    v1.8.0

added some methods to give a choice of

commit e9d39a32158bae30c7e67424f206d7464964cd03
Author: jamiesensei <jamiesensei>
Date:   Wed, 11 Oct 2006 14:30:03 +0800
Tag:    v1.8.0

added new form element datetimeselector