Git commits in Moodle 1.6.x by defacer

commit 2dd1350d6482ef44d820eddc7da05fdbff999745
Author: defacer <defacer>
Date:   Thu, 01 Mar 2007 16:01:13 +0900
Tag:    v1.6.5

Fix for MDL-8515: Prefixing chat messages with a slash should not hide the user's name unless it's a special command we handle.

commit 55a30b97adf33e1dd77cbe0205ba4c77c321f716
Author: defacer <defacer>
Date:   Tue, 27 Feb 2007 23:25:17 +0900
Tag:    v1.6.5

Fix for MDL-4701: Event URLs now include anchor so that the event is immediately visible.

commit e2ea2456460c5be65f0882cdbee979a1bf96645c
Author: defacer <defacer>
Date:   Tue, 27 Feb 2007 22:55:29 +0900
Tag:    v1.6.5

Bugfix: skodak's fix for MDL-5991 is needed here as well.

commit 9b2fb1535bdfac30a8929da225ae8918f1d9c7df
Author: defacer <defacer>
Date:   Tue, 27 Feb 2007 22:44:17 +0900
Tag:    v1.6.5

Changing email addresses that caught my eye in the comments.

commit 8960cc378075e66277a9efe81557fb004942856a
Author: defacer <defacer>
Date:   Tue, 27 Feb 2007 22:38:06 +0900
Tag:    v1.6.5

Not needing this anymore, we now have Moodle Docs.

commit c109bb608a76903efb5b7662b1c422704f607b97
Author: defacer <defacer>
Date:   Sun, 25 Feb 2007 08:07:32 +0900
Tag:    v1.6.5

Fix for MDL-4940: Social Activities block disappears when editing course settings.

commit e68cf1b3e91a3faaaa6448b9580213d07dcdc9a9
Author: defacer <defacer>
Date:   Sun, 29 Jan 2006 03:49:16 +0800
Tag:    v1.6.0

Merging from STABLE: Fix for bug 4627:

commit ce432524ee97611bb5fe9362a00f8aa21581f684
Author: defacer <defacer>
Date:   Sun, 15 Jan 2006 10:32:04 +0800
Tag:    v1.6.0

Changing the naming scheme for auto-generated HTML ids here; due to copy/paste this might have resulted in non-unique ids in the same page.

commit 85e0be2aaa714de6de5ccf8d5c3ff5e01fa4605b
Author: defacer <defacer>
Date:   Sun, 15 Jan 2006 09:52:07 +0800
Tag:    v1.6.0

Seems I got the only remaining instance of set_default(), so it's time to draw the curtains.

commit 3ce130eac5002a79fc202282c19e6e0971445c02
Author: defacer <defacer>
Date:   Sun, 15 Jan 2006 09:44:08 +0800
Tag:    v1.6.0

When creating/editing events, it seems that the current/existing timestart is not pre-filled in the forms. This is a regression, no idea how and when it happened. Investigating...

commit 42f9b64b80b021feda57af7a10f7b8c09c5cafbc
Author: defacer <defacer>
Date:   Sat, 14 Jan 2006 00:28:19 +0800
Tag:    v1.6.0

On second thought, we can be a bit more diplomatic with this one. The best of both worlds, but a hack is a hack. wink

commit 24acdc993bbb06bb2f468781c90ead49bcbb682b
Author: defacer <defacer>
Date:   Sat, 14 Jan 2006 00:20:40 +0800
Tag:    v1.6.0

Fixing a bug, see http://moodle.org/mod/forum/discuss.php?d=37545

commit b5f1b8b10e86286834679e71d9ada35e52e6e297
Author: defacer <defacer>
Date:   Fri, 13 Jan 2006 23:34:30 +0800
Tag:    v1.6.0

Super-basic export to iCal functionality, still very raw. But works!

commit e58e1a947430d538ce61bce2704288aa8ba27729
Author: defacer <defacer>
Date:   Fri, 13 Jan 2006 23:30:24 +0800
Tag:    v1.6.0

XHTML fixes for the administration page, plus a couple assorted styles.

commit 1198996db65a979e50c15ef909194a47ce22d8f7
Author: defacer <defacer>
Date:   Fri, 13 Jan 2006 23:15:19 +0800
Tag:    v1.6.0

Some XHTML fixes I had lying around.

commit f3b6ac1539e7724e7a236d69dec4f39e4d98cda4
Author: defacer <defacer>
Date:   Fri, 13 Jan 2006 23:06:25 +0800
Tag:    v1.6.0

Incoming: Bennu library to be used for iCal imports/exports.

commit 8eefd42e7e88458ccb3ed7889455b52fe5d0179e
Author: defacer <defacer>
Date:   Sat, 17 Dec 2005 12:53:50 +0800
Tag:    v1.6.0

Oops. Forgot some debug code in there.

commit 1130633117ed6dd064dddbedd2a718bf4e98d1d3
Author: defacer <defacer>
Date:   Sat, 17 Dec 2005 12:37:55 +0800
Tag:    v1.6.0

NEW FEATURE:

commit a9033ad5f80bedf35cb3a09d14f2527f41a1294c
Author: defacer <defacer>
Date:   Sat, 17 Dec 2005 11:09:13 +0800
Tag:    v1.6.0

Faster block_method_result(), my back-of-the-envelope benchmarks say that call_user_func is about 3 times faster than eval(). Which is no surpise. wink

commit ccfa3918def5fbafb627bb34099508cd1bc15c95
Author: defacer <defacer>
Date:   Wed, 07 Dec 2005 23:01:02 +0800
Tag:    v1.6.0

Merge from STABLE:

commit 164574905701f4d1b53c9b5582baa5c0c9123113
Author: defacer <defacer>
Date:   Sat, 03 Dec 2005 21:12:09 +0800
Tag:    v1.6.0

Correcting the way of setting lowbound <= $var <= highbound, spotted by Petr (SC#203).

commit 00d94a2001915dc7fbf53c9b7764672ab41c8935
Author: defacer <defacer>
Date:   Sat, 26 Nov 2005 08:58:53 +0800
Tag:    v1.6.0

Fix for bug 4371 (also SC#199):

commit 13f64465e161de0e238667b55931748cbc87a270
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 07:40:26 +0800
Tag:    v1.6.0

Removing some code which looks _very_ dead to me (traced its origins back to when the Blocks2 stuff was first committed).

commit a7ef57d4da4903f1bebd25ba3024bff1b584614e
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 07:16:24 +0800
Tag:    v1.6.0

Making section links point to #section-NNN instead of #NNN

commit 4baeb9b028d9abfe512187a3802f37f40c54d30c
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 07:14:25 +0800
Tag:    v1.6.0

Removing the <a name="2"></a> anchors from course sections (used with links, e.g. /course/view.php?id=2#4). We already have elements with id="section-XXX", so I made all links I could possibly grep for point to those.

commit 4d4e738f7cc11866e3e9c4d8752632a702538777
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 06:47:35 +0800
Tag:    v1.6.0

Fixing line endings

commit 296c94b13456b2c8793fa979a5a9eccac2482458
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 06:33:33 +0800
Tag:    v1.6.0

Begone, evil <font> tag

commit 7f9def8fa9835fb14f02e544633202cc44aba756
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 06:31:52 +0800
Tag:    v1.6.0

XHTML fix

commit 64f36986b6d7e29fc25393daf87281ec27732d1e
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 06:22:44 +0800
Tag:    v1.6.0

The bug where an event was not created for closing-time-only-supplied quizzes also existed when updating a quiz instance (not only adding)...

commit 018881d4a97c82b2fb701ebf7cbea8db27114e89
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 06:14:57 +0800
Tag:    v1.6.0

Fixing invalind value for cellpadding ("5px")

commit 3d6fc452292dbde2985167361355f6f28c7c49d8
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 06:11:50 +0800
Tag:    v1.6.0

Fixing defaults (copy/paste error) -- this printed notices with debug=on and actually mangled the "create lesson instance" query so badly that you could not add lessons!

commit 001996c2f290f1ced6a37d0295268afa53dede6c
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 05:34:48 +0800
Tag:    v1.6.0

Fix for bug 4358:

commit d0eafce59475e2f0dab4d5f397e9e0cdd120711d
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 05:21:30 +0800
Tag:    v1.6.0

These quotes were going into (quoted) HTML attributes and breaking XHTML.

commit 9173a5671c1a092090214153d615a8c3c62a4b46
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 05:16:47 +0800
Tag:    v1.6.0

Searching around in the langfile, it seems that these are the correct strings for the helpbuttons' title attribute. I added the first helpbutton back in as well (exists in 1.5.3+ but not in HEAD???).

commit 8635a2824a7d8440ca9e05f52efd7420e190817e
Author: defacer <defacer>
Date:   Thu, 24 Nov 2005 05:00:40 +0800
Tag:    v1.6.0

Fixing one get_string() that didn't specify the Quiz langfile, and changing another to be uniform with the help file title.

commit 94cda02214f29567ba62ab084c39048775fe7ff1
Author: defacer <defacer>
Date:   Tue, 15 Nov 2005 00:21:41 +0800
Tag:    v1.6.0

file unchecked_vars.php was initially added on branch MOODLE_15_STABLE.

commit 136f43dcdaacdcfe881235085e7c13aedc3c9019
Author: defacer <defacer>
Date:   Mon, 14 Nov 2005 12:33:25 +0800
Tag:    v1.6.0

Missing footers, XHTML warnings.

commit 9013e4ad731bf13ffbcaf00c8dd1bbded9d6ae80
Author: defacer <defacer>
Date:   Sun, 13 Nov 2005 12:42:21 +0800
Tag:    v1.6.0

Now get_sql_sort can be called static-function-imitation style as well. Necessary to solve SC#187 gracefully.

commit 02828119f674343e9eb4affa7ec37fc0df8ab595
Author: defacer <defacer>
Date:   Sun, 13 Nov 2005 12:30:50 +0800
Tag:    v1.6.0

OK, trying to write about this in the SC made me think, thinking made me find the solution. No hacks, no replicating the table object, I just tweaked the table class itself to help us.

commit 86f6539591f317d7b9ce92fc63b8f9e3e0583cec
Author: defacer <defacer>
Date:   Sun, 13 Nov 2005 12:01:41 +0800
Tag:    v1.6.0

Removing code block which, upon closer inspection, does nothing at all.

commit 9894b8246ca1cfb49852761a4ff7818de96bfe71
Author: defacer <defacer>
Date:   Sun, 13 Nov 2005 11:37:40 +0800
Tag:    v1.6.0

Gone through the code carefully. Committed what is basically Skodak's patch at SC#187 postid 1104 with a small addition, EXCEPT the //HACK ALERT part.

commit 5b48244f246f835a05133c720ddaa483c91aa1d8
Author: defacer <defacer>
Date:   Sun, 13 Nov 2005 11:20:35 +0800
Tag:    v1.6.0

Carefully going through the code now...

commit c9977d055d200a50f9afdf68955f3bd6a80e8b31
Author: defacer <defacer>
Date:   Sun, 13 Nov 2005 10:50:46 +0800
Tag:    v1.6.0

Been playing around Assignment a bit, and Tidy kept complaining...

commit 4fdabdc36fde6b9dec154e4516744a16755d3110
Author: defacer <defacer>
Date:   Sat, 12 Nov 2005 11:04:11 +0800
Tag:    v1.6.0

Merging from STABLE:

commit c0b507d11800170b5eeba2064aaec47e4e6e4884
Author: defacer <defacer>
Date:   Sun, 06 Nov 2005 11:20:30 +0800
Tag:    v1.6.0

I was going through the code here and found out that it's completely missing the point, it could be much tighter and easier to understand. So here's the candidate replacement code plus some assertions, I intend to let it run for some time and if no assertion errors come up (they shouldn't) do the replace.

commit 3f754e638ce4c243633d648668d4addfc67b6d32
Author: defacer <defacer>
Date:   Mon, 31 Oct 2005 09:58:42 +0800
Tag:    v1.6.0

Fixing a typo ("=" to "=>") which killed my Moodle after grabbing the latest CVS.

commit 044cdea0c6aacf0fe9281f15fe16ebc49c5dd250
Author: defacer <defacer>
Date:   Sun, 30 Oct 2005 09:10:08 +0800
Tag:    v1.6.0

Removing MY_MOODLE_FORMAT constant, we just play along with relative paths.

commit e7898f26ebb5c5eebf8b56523b1f11f9c0909d9d
Author: defacer <defacer>
Date:   Sun, 30 Oct 2005 02:58:05 +0800
Tag:    v1.6.0

Fix for bug 4251:

commit c2c194eeaf0ec909b534d76bc19128b2a33b387e
Author: defacer <defacer>
Date:   Wed, 26 Oct 2005 21:44:56 +0800
Tag:    v1.6.0

Fixing all incoming parameters when editing course groups as per SC#171.

commit 970f144ef42e578e006d53194cfd6e0b6ed658f4
Author: defacer <defacer>
Date:   Tue, 25 Oct 2005 09:55:21 +0800
Tag:    v1.6.0

A slight improvement for my last edit, which could trigger a small bug.

commit 72989350bec9cc9e81923f8abdfad935def03dd4
Author: defacer <defacer>
Date:   Tue, 25 Oct 2005 01:30:56 +0800
Tag:    v1.6.0

Fix for bug 3794:

commit b2b68362c2038e847b249f49eb2e3aeaafef99a2
Author: defacer <defacer>
Date:   Tue, 25 Oct 2005 01:25:29 +0800
Tag:    v1.6.0

I just worked with a few functions which had misleading or no PHPdoc comments, so it was a good excuse to fix the situation a bit.

commit c5a4a13a2468d82b8be988f1803c2c8b9365e335
Author: defacer <defacer>
Date:   Tue, 25 Oct 2005 01:13:57 +0800
Tag:    v1.6.0

Fix for bug 4203:

commit e5ada99f2bcb74972e47d18d856008405c5c4093
Author: defacer <defacer>
Date:   Fri, 21 Oct 2005 09:18:30 +0800
Tag:    v1.6.0

Merged from STABLE:

commit d515b72998b2594cbe6a3d08ee82ab39fd35b540
Author: defacer <defacer>
Date:   Fri, 21 Oct 2005 08:29:14 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 9bd49dfa3bf144b08f07f8351f181eb2a9d9f5c1
Author: defacer <defacer>
Date:   Sun, 02 Oct 2005 23:46:06 +0800
Tag:    v1.6.0

Code readability improvements and fixed a notice

commit 2280ecf5378feb4fbc261721151695e8d2adb801
Author: defacer <defacer>
Date:   Tue, 30 Aug 2005 11:27:52 +0800
Tag:    v1.6.0

Fix for bug 3981 (also quite lively discussed at http://moodle.org/mod/forum/discuss.php?d=29564):

commit 69963aa63c68740c21dc10d05dac6f9838bf0ede
Author: defacer <defacer>
Date:   Wed, 24 Aug 2005 04:43:32 +0800
Tag:    v1.6.0

Changing some hardwired 1s to SITEID. Is the madness ever going to end? Use 1 as a magic number in code, pay the price...

commit 44525c65913e876da6e7f1db5fe997040e3a6322
Author: defacer <defacer>
Date:   Wed, 24 Aug 2005 04:06:08 +0800
Tag:    v1.6.0

Repeat events are now created correctly even if the DST change boundary is crossed between repeats.

commit e796d82d1ac774de26ad6fcf0f1addf7c1e8381c
Author: defacer <defacer>
Date:   Wed, 24 Aug 2005 03:14:00 +0800
Tag:    v1.6.0

Some new strings for the new "anonymous result" feature.

commit 85311ca8d6d2eca16b13c0c86c4aea2a163f3c92
Author: defacer <defacer>
Date:   Wed, 24 Aug 2005 03:12:54 +0800
Tag:    v1.6.0

Now Quiz Results can be set into anonymous mode, where performance is shown but student and group names are not disclosed. See relevant discussion at

commit 3cdc4597f5cf1eee7a34adb3f2343ee68980bfc0
Author: defacer <defacer>
Date:   Wed, 24 Aug 2005 02:16:06 +0800
Tag:    v1.6.0

Fixing copy/paste typo, caught by Howard Miller.

commit c0e170b2a7385eccb2c027351bf6307dba515271
Author: defacer <defacer>
Date:   Tue, 23 Aug 2005 10:45:45 +0800
Tag:    v1.6.0

My first commit since I don't remember when. Yay!

commit 30d5bd7979e7b01736994f85898c43c54559d2c0
Author: defacer <defacer>
Date:   Sat, 23 Jul 2005 08:53:55 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 98f8f9c2182e6319f540bfbb8566b2132f3c0713
Author: defacer <defacer>
Date:   Thu, 21 Jul 2005 01:58:33 +0800
Tag:    v1.6.0

Adding some fields to mdl_event to facilitate iCalendar import/export. This is a work in (sloooow) progress.

commit 2ecdff78945518c566994fe4a99788df1f6558d8
Author: defacer <defacer>
Date:   Thu, 21 Jul 2005 01:47:05 +0800
Tag:    v1.6.0

Merging from STABLE:

commit e15e02bf98f964e837893a13aff4f04c59ce0d5c
Author: defacer <defacer>
Date:   Thu, 21 Jul 2005 01:23:07 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 164e30542d466a7f182a151259b04850c101baa2
Author: defacer <defacer>
Date:   Wed, 20 Jul 2005 07:45:02 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 281d70ac2d4a90c0300a5341678eeba6b7e43578
Author: defacer <defacer>
Date:   Fri, 08 Jul 2005 11:51:38 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 73ee7658dfb1ee870c1d5c44e1a9684de9d616b3
Author: defacer <defacer>
Date:   Fri, 08 Jul 2005 11:20:54 +0800
Tag:    v1.6.0

Allow <span> as well as <lang> in event titles; clean appropriately.

commit c7d6e274510feea3531964a17a84c1504cfb9a79
Author: defacer <defacer>
Date:   Wed, 06 Jul 2005 08:51:20 +0800
Tag:    v1.6.0

Fixing a notice: $this->footer wasn't always set.

commit fdc36b2f981147309eda36f8f07278533d4f0d9b
Author: defacer <defacer>
Date:   Wed, 06 Jul 2005 08:47:08 +0800
Tag:    v1.6.0

Merging from STABLE: Fixed the annoying "...and the 1 Journals you had..." message when you have no Journals at all, because I was tired of seeing it.

commit e623c7f74000c707f54ef626634258f48185fe28
Author: defacer <defacer>
Date:   Wed, 06 Jul 2005 08:36:36 +0800
Tag:    v1.6.0

Merging from STABLE: Fix for bug 3616:

commit 20cbef6390dffc46b05f4841f00c2cd3a3e576f8
Author: defacer <defacer>
Date:   Fri, 01 Jul 2005 11:57:03 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 7f65461c36cc588df983fd1173ae471ee6391f55
Author: defacer <defacer>
Date:   Thu, 30 Jun 2005 08:03:03 +0800
Tag:    v1.6.0

Merging from STABLE:

commit a5a3f48a4a7fb384a42edd46eee3778d654ea53d
Author: defacer <defacer>
Date:   Mon, 20 Jun 2005 11:47:19 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 2e477369d3ec1f545956a6e2fd9ba3d1e2ea035e
Author: defacer <defacer>
Date:   Wed, 15 Jun 2005 04:33:39 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 93c865201a163b9b4654f59b526bc575d1a62651
Author: defacer <defacer>
Date:   Tue, 14 Jun 2005 23:52:49 +0800
Tag:    v1.6.0

Merging from STABLE:

commit b33dd23adc5664e1d0c532a7e3801fa3ac30a952
Author: defacer <defacer>
Date:   Mon, 13 Jun 2005 11:32:31 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 34137668b55b44df05fd1801ee97a202a464c5c4
Author: defacer <defacer>
Date:   Mon, 13 Jun 2005 10:56:37 +0800
Tag:    v1.6.0

Adding a little more checking to the session switching trap code.

commit 7e9a11eb98f5760e6afff487807e0c7bb8eb1970
Author: defacer <defacer>
Date:   Mon, 13 Jun 2005 10:38:48 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 8023ab860a129f3507a70d8f19d68b771311e490
Author: defacer <defacer>
Date:   Mon, 13 Jun 2005 09:57:33 +0800
Tag:    v1.6.0

Merging from STABLE:

commit eb24097afebd17270d6099f9cd7d076cda830883
Author: defacer <defacer>
Date:   Mon, 13 Jun 2005 08:48:33 +0800
Tag:    v1.6.0

Merge from STABLE:

commit 491cc6d617e8cc699360f387d8cfe7397fb0fca6
Author: defacer <defacer>
Date:   Sun, 05 Jun 2005 01:53:36 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 731df4595cf9cc0f1db9e3472b92fdd74dc86dd1
Author: defacer <defacer>
Date:   Sat, 04 Jun 2005 08:21:00 +0800
Tag:    v1.6.0

Merging from STABLE:

commit bf845f2b30d4654dbe2446e1f9789b234b3ae2ef
Author: defacer <defacer>
Date:   Sat, 04 Jun 2005 07:41:06 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 097c223156e3395d67d8e3e3c651c96770dd4b61
Author: defacer <defacer>
Date:   Sat, 04 Jun 2005 07:32:04 +0800
Tag:    v1.6.0

Merging from STABLE:

commit d5406399a282e853f25b060426eaf1aeb125a90d
Author: defacer <defacer>
Date:   Sat, 04 Jun 2005 07:29:56 +0800
Tag:    v1.6.0

Merging from STABLE:

commit cc038b47725df5bbe19e11950fdeae447136dfd6
Author: defacer <defacer>
Date:   Sat, 04 Jun 2005 07:20:01 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 91bb59f49f954fda623bd42aaddf7c0c708aa850
Author: defacer <defacer>
Date:   Sat, 04 Jun 2005 06:48:07 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 3525d91b4622a2ae1a9aae991dd1384d71de291e
Author: defacer <defacer>
Date:   Mon, 30 May 2005 21:35:36 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 5a74ffd34415710156df09200b7e70679f8601b1
Author: defacer <defacer>
Date:   Mon, 30 May 2005 20:44:30 +0800
Tag:    v1.6.0

Merging from STABLE:

commit e2ba85e99c59f94d1357e8f669bab766eee8f5ca
Author: defacer <defacer>
Date:   Sun, 29 May 2005 05:24:46 +0800
Tag:    v1.6.0

Merging from STABLE:

commit 061d8339a6e05eeea3f3bb7d90c51d89660b94c8
Author: defacer <defacer>
Date:   Sun, 29 May 2005 02:37:47 +0800
Tag:    v1.6.0

Merging from STABLE.

commit 0ead4ee0df9b6a8bc520cfbeb7929fbb2485be87
Author: defacer <defacer>
Date:   Sun, 29 May 2005 02:29:40 +0800
Tag:    v1.6.0

NEW STRING ADDED for admin/blocks.php

commit ca98446a17ec1fc803a6d1af4de700f2051ea73c
Author: defacer <defacer>
Date:   Sun, 29 May 2005 02:24:23 +0800
Tag:    v1.6.0

Merging styles for admin/blocks from STABLE

commit 46bba3597c0cf6862f1433bcaacae2d5ea5b810b
Author: defacer <defacer>
Date:   Thu, 26 May 2005 01:57:53 +0800
Tag:    v1.6.0

Merging bugfix for 3334 (if at first you don't succeed edition)

commit a058decd5e880c51cf268dcfcb34cc61d994fa53
Author: defacer <defacer>
Date:   Wed, 25 May 2005 22:38:06 +0800
Tag:    v1.6.0

Merging fix for bug 3334 from 1.5 STABLE branch.

commit 71f189c537ab7cb686ee32b3f29eda0a29b25b8c
Author: defacer <defacer>
Date:   Wed, 25 May 2005 02:55:30 +0800
Tag:    v1.6.0

Tweaking a little stuff to make CSS the same as those in translated versions.

commit c910274995dd4d89a29062d07c0c0474753f2fcb
Author: defacer <defacer>
Date:   Tue, 24 May 2005 11:31:48 +0800
Tag:    v1.6.0

Fixing a typo.

commit d3555a2ff5c3661bb3608832069e5e5379203606
Author: defacer <defacer>
Date:   Mon, 23 May 2005 21:53:06 +0800
Tag:    v1.6.0

A small bugfix/update to work with DST. Before, events starting between 00:00 and 00:59 in the first day of each month were not shown at all with DST on.

commit 254e5a22a98c33210fbf9fa8d277abef0649d2f2
Author: defacer <defacer>
Date:   Mon, 23 May 2005 05:43:12 +0800
Tag:    v1.6.0

Fixed invalid use of GROUP BY and (mostly) fixed sorting by question grade.

commit 5e5c0f1ea576d24bb19c620c0ee79b2dc9b39dff
Author: defacer <defacer>
Date:   Mon, 23 May 2005 00:57:24 +0800
Tag:    v1.6.0

This just caught my eye; obsolete and misleading line removed.

commit 64ea4ecbbadd4a150d58f637b5a8246f764663b8
Author: defacer <defacer>
Date:   Sun, 22 May 2005 10:05:45 +0800
Tag:    v1.6.0

One new string

commit c8dbfa5cd56db24e4e1d9834790f5acbe32ddb10
Author: defacer <defacer>
Date:   Sun, 22 May 2005 09:53:13 +0800
Tag:    v1.6.0

Fixing a header, this string wasn't set anywhere. Plus it needs a new string in the lang files (coming up next).

commit c5d362036208e3a35019ffb503917f03c95d83fa
Author: defacer <defacer>
Date:   Sun, 22 May 2005 09:51:03 +0800
Tag:    v1.6.0

Fixing invalid GROUP BY sql reported by Patrick Li of Catalyst. (http://moodle.org/mod/forum/discuss.php?d=24110)

commit e345909c50c42552c054f47a74fdfb0046cfbccc
Author: defacer <defacer>
Date:   Fri, 20 May 2005 04:09:57 +0800
Tag:    v1.6.0

Now that the extended multilang filter is in place (bug 2879), reintroducing format_text to the HTML block (bug 2878).

commit fde4a0941b9229d28e97fbf68779471186be3c85
Author: defacer <defacer>
Date:   Fri, 20 May 2005 01:32:30 +0800
Tag:    v1.6.0

New extended multilang filter!

commit 4541e897cb3e3537cb385ef481a9e5675468847e
Author: defacer <defacer>
Date:   Wed, 18 May 2005 08:49:45 +0800
Tag:    v1.6.0

The particulars for the Manage Feeds page finalized. Old code removed.

commit 3753b02a3b242b147468a821bf58c03952c9023d
Author: defacer <defacer>
Date:   Wed, 18 May 2005 08:48:16 +0800
Tag:    v1.6.0

New yummy styles for the Manage Feeds page. Molto belle.

commit 1c7e01d5cd11eb822a0bfbde809c80f5aea835f9
Author: defacer <defacer>
Date:   Wed, 18 May 2005 08:03:18 +0800
Tag:    v1.6.0

Adding "Actions" (plural).

commit 9e0f2a43dcfa6d8f363cab446630b435a9e3213d
Author: defacer <defacer>
Date:   Wed, 18 May 2005 07:35:58 +0800
Tag:    v1.6.0

Switching feed dislay table to use the new table class.

commit 3c47bfc752d4fd167511c864763827ec4f593c3a
Author: defacer <defacer>
Date:   Wed, 18 May 2005 01:00:20 +0800
Tag:    v1.6.0

The bug 2822 saga concludes.

commit b4843fde3b272ef0c505700258182a06209ba383
Author: defacer <defacer>
Date:   Wed, 18 May 2005 00:35:20 +0800
Tag:    v1.6.0

Fix for bug 2822: unwanted table spacing in calendar/view.php. Thanks Andrea! smile

commit b011f733bfc3d340fbe0d37d741c7698c2807764
Author: defacer <defacer>
Date:   Tue, 17 May 2005 23:28:06 +0800
Tag:    v1.6.0

Fix for bug 2635:

commit 7c7d56bbd92e3fe2140d085e06619d1657a39375
Author: defacer <defacer>
Date:   Tue, 17 May 2005 23:01:10 +0800
Tag:    v1.6.0

Fix for bug 2878:

commit 9abcc2f62d948edc6cfcec3a8c9429c7545921f2
Author: defacer <defacer>
Date:   Tue, 17 May 2005 08:29:11 +0800
Tag:    v1.6.0

Removing a string we no longer use.

commit e7beac8992c7b6ba8740ebc0bcaa4d4b276ebbf7
Author: defacer <defacer>
Date:   Thu, 12 May 2005 22:46:16 +0800
Tag:    v1.6.0

Removing dead code.

commit 7979105c629050e744b9e889a95b6984cf912b03
Author: defacer <defacer>
Date:   Thu, 12 May 2005 22:45:16 +0800
Tag:    v1.6.0

If Javascript is enabled, make IE fix the block sizes after the page loads so that it's not a mess to look at.

commit 4c58e0289bab60a87242cb90d31e775d46d59dab
Author: defacer <defacer>
Date:   Wed, 11 May 2005 01:32:01 +0800
Tag:    v1.6.0

Removing dead commented code.

commit e6890163ddb81ee7775636a1d206052250107169
Author: defacer <defacer>
Date:   Wed, 11 May 2005 01:09:15 +0800
Tag:    v1.6.0

Nice borders all around the header when a sideblock is collapsed.

commit c4d951e1f8d867551898be464e4d4ebd3c5458c6
Author: defacer <defacer>
Date:   Tue, 10 May 2005 12:00:56 +0800
Tag:    v1.6.0

Here be DIVs.

commit 45c89333e1adcab303ad2714314449b8cde0d2dc
Author: defacer <defacer>
Date:   Tue, 10 May 2005 08:47:08 +0800
Tag:    v1.6.0

Moving this from inline style to CSS.

commit ef6a8319d4667e69ab538b7e946539dec2c1994a
Author: defacer <defacer>
Date:   Tue, 10 May 2005 08:36:37 +0800
Tag:    v1.6.0

Making these menus smaller so that they fit in the same line as the help icon.

commit d33d0cda79d079d0d7438381d1e8317062b9899f
Author: defacer <defacer>
Date:   Tue, 10 May 2005 08:31:32 +0800
Tag:    v1.6.0

Better appearance for section add menus in vertical mode.

commit 4b4ca01dae263171c673910889fafe9a1775eb30
Author: defacer <defacer>
Date:   Tue, 10 May 2005 08:22:34 +0800
Tag:    v1.6.0

Giving some margin back to /pix/help.gif, and bringing blocks to 90% working order again.

commit 1fd3772bc51cd44d0761dae151155f6257af709e
Author: defacer <defacer>
Date:   Tue, 10 May 2005 08:21:09 +0800
Tag:    v1.6.0

Changing width="22" for /pix/help.gif to width="17"

commit b1aa9a39a2b7caef00097a8987cc27d9f36d2596
Author: defacer <defacer>
Date:   Tue, 10 May 2005 08:20:18 +0800
Tag:    v1.6.0

Switching blocks to table-less format; IT DOESN'T WORK CORRECTLY YET.

commit 1c46eb033406a533bf310ac04afbdd10d3cf4842
Author: defacer <defacer>
Date:   Tue, 10 May 2005 08:17:22 +0800
Tag:    v1.6.0

Improved markup for print_section_add_menus, without tables.

commit ebe43221ff55e99338f03d02a0f36e5168d3fb3a
Author: defacer <defacer>
Date:   Tue, 10 May 2005 08:15:06 +0800
Tag:    v1.6.0

Removing annoying extra padding from the left side of this graphic. We can very easily fix this with CSS, coming up next.

commit 4fad36189f62ce3211f8687e676a6e05da41958b
Author: defacer <defacer>
Date:   Tue, 10 May 2005 07:37:28 +0800
Tag:    v1.6.0

I 'm fed up with the crappy HTML for blocks that keeps giving us no end of trouble (bug 1718 is just the tip of the iceberg).

commit 88bbf2efff7c23a713f004810325a38837c362ab
Author: defacer <defacer>
Date:   Tue, 10 May 2005 07:11:25 +0800
Tag:    v1.6.0

Visual improvement: blocks which are "hidden" (eye icon) now shown exactly like collapsed blocks (minus sign) when editing is on.

commit 15816e0a08fe22aef3e14b35d643bc4e76e5a47f
Author: defacer <defacer>
Date:   Sun, 08 May 2005 01:51:31 +0800
Tag:    v1.6.0

Umm... just adding my standardized calling convention there. Pretend you didn't see :P

commit 8ecefdc8ad33f8a57372a96f01ca618e1630f7b7
Author: defacer <defacer>
Date:   Sun, 08 May 2005 01:47:52 +0800
Tag:    v1.6.0

Don't allow the "mark all posts in current forum read" image to break into a new line, it looks ugly.

commit fee287f3e77c2b05595013369ced3c72a2833315
Author: defacer <defacer>
Date:   Sun, 08 May 2005 01:46:20 +0800
Tag:    v1.6.0

Random change while searching for something: Removing border attribute from <img>, these are handled through CSS (a img {border: none;})

commit cfab68844e9987e4ae759a7e7d066e19a06b30ab
Author: defacer <defacer>
Date:   Sun, 08 May 2005 00:25:46 +0800
Tag:    v1.6.0

Adding a new lang file for the search forums block (no need to load up the forum.php behemoth just for that) and moving a couple of strings there.

commit cec60526cc7897537e66411fe62e0ab747638a81
Author: defacer <defacer>
Date:   Sun, 08 May 2005 00:10:50 +0800
Tag:    v1.6.0

Fixing set_user_sesskey calls (function no longer exists), changing to sesskey()

commit fcb50b292d20d5db9f8b6041a8ecbe142f897df0
Author: defacer <defacer>
Date:   Sat, 07 May 2005 05:44:34 +0800
Tag:    v1.6.0

Fix for bug 3113, some innocent notices.

commit 914493e96176d0eb46855275017549a34603a0c4
Author: defacer <defacer>
Date:   Thu, 05 May 2005 05:54:06 +0800
Tag:    v1.6.0

Fixing a bug, default value must be taken from the global $GRADEPREFSDEFAULTS.

commit 365789db75f4b3358af0f0f456e60952165acea8
Author: defacer <defacer>
Date:   Mon, 02 May 2005 22:27:45 +0800
Tag:    v1.6.0

Some improvements: keep checkbox and weekday name grouped together.

commit b030458beee9df1120595a48ca5c22fdfb6c427f
Author: defacer <defacer>
Date:   Mon, 02 May 2005 01:17:06 +0800
Tag:    v1.6.0

Make very sure that the submitted edit form actually tries to submit a locked field before deciding to complain.

commit 8abc54c4f090dff78c29417dd5189e3b25bcd561
Author: defacer <defacer>
Date:   Mon, 02 May 2005 01:13:30 +0800
Tag:    v1.6.0

Updating the timezone lists with the Manila fix and also the glaring Paris mess-up. Eagle Eye Eloy strikes again!

commit 28c66824e7058547b72d4096bd111b6b28065fc4
Author: defacer <defacer>
Date:   Mon, 02 May 2005 00:50:35 +0800
Tag:    v1.6.0

Fixing two bugs:

commit 6976250146c991a0de62e0fa341bd0602dd4776f
Author: defacer <defacer>
Date:   Sun, 01 May 2005 06:26:17 +0800
Tag:    v1.6.0

Performance boost for admins and editing teachers who teach several courses with NOGROUPS.

commit 459ac79118006871894eabd23c488ed34e2ad9c3
Author: defacer <defacer>
Date:   Sun, 01 May 2005 01:46:11 +0800
Tag:    v1.6.0

Fixing visual glitch in tabs.

commit 165479681584802aa147797be0f44e3362893449
Author: defacer <defacer>
Date:   Sat, 30 Apr 2005 11:25:28 +0800
Tag:    v1.6.0

The final touch for block robustness: when upgrading from 1.4, intercept and disable any incompatible blocks. Print a notice too.

commit 521729041aa4547b7842f58b9805057d56bd2815
Author: defacer <defacer>
Date:   Sat, 30 Apr 2005 11:22:59 +0800
Tag:    v1.6.0

The admin blocks page now doesn't crash when encountering an incompatible block; instead, it shows a notice.

commit ff6191b742100ed429ff942202824d615fcd271c
Author: defacer <defacer>
Date:   Sat, 30 Apr 2005 11:18:02 +0800
Tag:    v1.6.0

On second thought, moving the cache retrieval out of the loop should eliminate up to ten or so function calls per page view. I don't know how expensive they are, but let's take what we can.

commit 9b68732055d43c163db7c282e97b2de5b512039f
Author: defacer <defacer>
Date:   Sat, 30 Apr 2005 11:14:42 +0800
Tag:    v1.6.0

Extra check in blocks_preferred_width: don't examine any instance if that block is not visible. Apart from fixing a bug, this is also they key to fixing broken behavior with legacy 1.4 blocks.

commit 61abc65bb956db43259144ff28c957e3c718488b
Author: defacer <defacer>
Date:   Sat, 30 Apr 2005 11:08:04 +0800
Tag:    v1.6.0

New function block_is_compatible(), if it returns anything but true and you decide to do anything with the block your warranty is void.

commit 6cb79c49d5ee5c964a334114a05cf3aef076dbef
Author: defacer <defacer>
Date:   Fri, 29 Apr 2005 03:23:39 +0800
Tag:    v1.6.0

Latest and (hopefully!!!) final changes to the Blocks how-to. These address the change where we now supply class block_list for list blocks to derive from.

commit 68b38e8d02a35c3a3b1a4f41ff2c9c6da2e0b1fa
Author: defacer <defacer>
Date:   Thu, 28 Apr 2005 02:30:02 +0800
Tag:    v1.6.0

Teachers table is now displayed with the new table class.

commit 380bf7a6d3bce3906b8f3bbeb294c74ac0a0ef5b
Author: defacer <defacer>
Date:   Wed, 27 Apr 2005 11:44:52 +0800
Tag:    v1.6.0

Simply usertimezone(), baby! wink

commit 0c2443159080d06ad0e1024007a8d0056936a35e
Author: defacer <defacer>
Date:   Wed, 27 Apr 2005 11:42:07 +0800
Tag:    v1.6.0

Fix for bug 3045:

commit 630bd96bd9005772dbb33b66474507acb1e5a2f2
Author: defacer <defacer>
Date:   Wed, 27 Apr 2005 06:02:26 +0800
Tag:    v1.6.0

Fixing read tracking link when tracking is forced.

commit 1576756e9f75f53bab278faffb0557dabefbcf47
Author: defacer <defacer>
Date:   Wed, 27 Apr 2005 05:52:39 +0800
Tag:    v1.6.0

Get rid of evil <font> tag and a few aesthetic corrections.

commit c6c3a5994157425223cd9ae8b92a4dfbf8f9019c
Author: defacer <defacer>
Date:   Wed, 27 Apr 2005 05:50:44 +0800
Tag:    v1.6.0

Initializing $parent to new stdClass was a major oops. However, seems it doesn't need to be initialized at all. So I won't hold this against the practice in general.

commit 10426cefb61876748ea7d33b692fbd34dfcb9da6
Author: defacer <defacer>
Date:   Wed, 27 Apr 2005 05:45:48 +0800
Tag:    v1.6.0

Fixing the two other functions that feed stuff into forum_print_post_full as well.

commit 6572ab7170efcbd726deb68294b3ff1ea38a271c
Author: defacer <defacer>
Date:   Wed, 27 Apr 2005 05:29:29 +0800
Tag:    v1.6.0

Fix for bug 3047, which I leave open because I don't know if this is the desired way of fixing the problem. Hopefully it is.

commit a2ad73deb99b08b28b5d7b90e99a030cb8a0720b
Author: defacer <defacer>
Date:   Wed, 27 Apr 2005 05:26:17 +0800
Tag:    v1.6.0

Initialize object as new stdClass instead of NULL.

commit 16955dc6191ecda7ac35fe1910db61dc9ed7e7c6
Author: defacer <defacer>
Date:   Wed, 27 Apr 2005 04:39:08 +0800
Tag:    v1.6.0

Some double quotes to single, use optional_param for $reply.

commit 208fc3a5f0de86cd2784e3de6c0ef432aedddcab
Author: defacer <defacer>
Date:   Tue, 26 Apr 2005 10:06:38 +0800
Tag:    v1.6.0

Initialize object with new stdClass.

commit a1dc259f2502e0bbe586d279f8485e67e8b2dc9f
Author: defacer <defacer>
Date:   Fri, 22 Apr 2005 20:44:11 +0800
Tag:    v1.6.0

Correct fix for bug 2912. That wasn't a typo, and thanks to my good friend IE we now need an ugly workaround (which luckily exists...)

commit d2900290849d310f606fefbe9aa9afe0e9384ae5
Author: defacer <defacer>
Date:   Fri, 22 Apr 2005 11:43:09 +0800
Tag:    v1.6.0

Correcting the behavior of update_record.

commit 6a368788ac0e76b8a5862a091c760434cafbcc57
Author: defacer <defacer>
Date:   Fri, 22 Apr 2005 11:13:58 +0800
Tag:    v1.6.0

Fixing a bug with embedding the parameter a=... in the log URL, which in turn affected the recent_activity block (that's how I found out).

commit 98cd789a4e18b717b87436f1c6216876a4065cde
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 22:33:30 +0800
Tag:    v1.6.0

Editing repeating events in one go works as well. Enjoy!

commit 822c612566b4a2eeabc85e0fbbe88481a757834a
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 22:04:26 +0800
Tag:    v1.6.0

Centering some headers in the calendar screens.

commit e6fbb4d11a7e3fa0cb173b004d5c2058a1ace2e4
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 22:03:22 +0800
Tag:    v1.6.0

You can now delete a repeating event series all at once.

commit 8f71c6b20bccf31fba044d458b5b9a0da808288f
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 21:44:50 +0800
Tag:    v1.6.0

Fixing PHP 5 warning.

commit d3e27ac43915a69e28061e99edb0896919275697
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 21:43:07 +0800
Tag:    v1.6.0

Adding repeatid to newly created repeat events.

commit 8180c859f1c84149c2529211b0225fe6b26fc1be
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 21:36:37 +0800
Tag:    v1.6.0

Adding repeatid in mdl_event.

commit 71de24539ac8c3026b821efdb9e75ec62806211a
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 21:25:43 +0800
Tag:    v1.6.0

Removing one block from social courses defaults, too overcrowded. Fixing also line endings.

commit cb88fbddecac107da9ba6a70d2aeb5b97f170a9c
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 05:46:33 +0800
Tag:    v1.6.0

I broke this with my last commit, fixing.

commit e93f551b3fdb0d1b8dcaa381005eaa2e1ff7e177
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 05:17:39 +0800
Tag:    v1.6.0

Removing leftovers from some debugging session.

commit 95a1810ed90b5ff2d88cbbb1cbebbc19a96885a7
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 05:14:27 +0800
Tag:    v1.6.0

Removing dead code.

commit edf205a609c28ebc7a5c8f8de5dc48626d90551e
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 05:13:08 +0800
Tag:    v1.6.0

Synchronising rights required for event editing with those required for adding events.

commit bc5f95a433f330969a39348461e7968d4a628f2f
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 05:09:26 +0800
Tag:    v1.6.0

Fixing a typo.

commit 4eb1a1df3f3ca7850d1898b0e52cfc606b5fe078
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 05:07:55 +0800
Tag:    v1.6.0

As per bug 2578:

commit fda5a2338fbc49747568f284224f7b7d7df16c1b
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 04:40:04 +0800
Tag:    v1.6.0

Scott Elliott managed to diagnose bug 2784 (and 2990 -- duplicate) and find the solution. All hail! smile

commit 65ef518b1de1b8e729aa3f2c13e94c27c46a0b1e
Author: defacer <defacer>
Date:   Thu, 21 Apr 2005 03:28:14 +0800
Tag:    v1.6.0

See bug 2987 (there is more to it than this checkin):

commit 3bc40d18548ff77198ddca2779697ea1598dd6df
Author: defacer <defacer>
Date:   Wed, 20 Apr 2005 23:09:33 +0800
Tag:    v1.6.0

Fixing a small visual discrepancy in the calendar block filter panel.

commit 865da14944c446e157d49ba85e027c8a7e7929e2
Author: defacer <defacer>
Date:   Wed, 20 Apr 2005 09:32:18 +0800
Tag:    v1.6.0

Fix for bug 2902: Now you can set $focus in print_header to anything, and it will never generate a JS error.

commit 29b592069360948c4b1059dd60f858a31dd17c39
Author: defacer <defacer>
Date:   Wed, 20 Apr 2005 08:44:02 +0800
Tag:    v1.6.0

Fix for bug 2933. Just tidying up HTML.

commit d21135ad85b8897c6c391a646009435289fd9a20
Author: defacer <defacer>
Date:   Wed, 20 Apr 2005 06:15:20 +0800
Tag:    v1.6.0

Fixing notice under PHP 5.

commit c399e50e77a16e0dcd14575e9f19389132e2f9fb
Author: defacer <defacer>
Date:   Wed, 20 Apr 2005 06:09:07 +0800
Tag:    v1.6.0

Inserting back the empty space after the headingblock in social courses, but in a way that makes it uniform with the other two course formats.

commit df03aecee75e79a5f316def1bae36463d6c65ccf
Author: defacer <defacer>
Date:   Wed, 20 Apr 2005 05:52:29 +0800
Tag:    v1.6.0

Fix for bug 2945.

commit bb74176fbfc9d9b4e36ba3b60e3acb0259f6a284
Author: defacer <defacer>
Date:   Wed, 20 Apr 2005 04:54:52 +0800
Tag:    v1.6.0

HTML improvements, including fix for bug 2967.

commit 979f826a2d041822176b1112ad8b4b80acd8320a
Author: defacer <defacer>
Date:   Wed, 20 Apr 2005 04:52:26 +0800
Tag:    v1.6.0

Fixing HTML typo, & -> &amp;

commit 273a80d7be2861ea5603f7e327ffb24d0d9ccc8d
Author: defacer <defacer>
Date:   Wed, 20 Apr 2005 04:45:15 +0800
Tag:    v1.6.0

Fixing bug 2935: HTML typo.

commit eee5cf8f64f7dc634c29142b48176b48ad065456
Author: defacer <defacer>
Date:   Tue, 19 Apr 2005 20:40:15 +0800
Tag:    v1.6.0

Removing the "dirty compatibility hack", it surely has done what it was meant to do all this time (keep Moodle working for people who had already upgraded to early versions of 1.5).

commit d1b68cec76ab9d89e2594ab8c77777ff1cde764e
Author: defacer <defacer>
Date:   Fri, 15 Apr 2005 21:55:57 +0800
Tag:    v1.6.0

Removing obsolete strings.

commit 9f3c3f1218ad83597cfd04c8c0692f6ffa9af6fa
Author: defacer <defacer>
Date:   Fri, 15 Apr 2005 21:54:24 +0800
Tag:    v1.6.0

Removing obsolete strings that confuse translators (my fault, sorry).

commit 4f2dbde9f8e86c3ece32cd933dda57d676815225
Author: defacer <defacer>
Date:   Thu, 14 Apr 2005 20:20:09 +0800
Tag:    v1.6.0

Fix for bug 2916, silly silly named constant mistake.

commit 257e3f4c61a0e9b2da11aeb85e2ac8ee13fd2b73
Author: defacer <defacer>
Date:   Tue, 12 Apr 2005 09:09:31 +0800
Tag:    v1.6.0

Utilize $CFG->calendar_adminseesall and part of Penny's patches (for bug 2804) to improve performance: if the admin wants to see all events, there's no need to make even one query for course groupmode.

commit b53f385b2c89947b01467c2b447ac0c0ef707e33
Author: defacer <defacer>
Date:   Tue, 12 Apr 2005 08:12:05 +0800
Tag:    v1.6.0

More cleanups, some useless code thrown out and simplified.

commit 39f899cd1c481fb9424c8062132a4d0dc696177e
Author: defacer <defacer>
Date:   Tue, 12 Apr 2005 08:05:06 +0800
Tag:    v1.6.0

More required_param and optional_param goodness.

commit 3b723f3b1dbf07f80d18c115522568a35d8ec938
Author: defacer <defacer>
Date:   Tue, 12 Apr 2005 07:54:20 +0800
Tag:    v1.6.0

Simplify the code, use optional_param, fixed one more instance of literal 1 = SITEID

commit 0ad072dea5088eb22643c69730765221e0e17c05
Author: defacer <defacer>
Date:   Tue, 12 Apr 2005 07:24:23 +0800
Tag:    v1.6.0

Simplify the code a bit and move the visible = 1 SQL check out of the main part of the WHERE statement. This might be actually fixing an operator precedence logic bug.

commit 6e957c415c687cddf8e0a5c1484d7bb1efc49ee0
Author: defacer <defacer>
Date:   Tue, 12 Apr 2005 07:21:29 +0800
Tag:    v1.6.0

Better bracketing for event-selecting SQL (see bug 2804)

commit 55d9c93a11ec85ff65fb3fe3946883a260da875c
Author: defacer <defacer>
Date:   Tue, 12 Apr 2005 07:13:41 +0800
Tag:    v1.6.0

Reading some code carefully...

commit e2aa618b773db2f083b4c4475b733f6efcb00205
Author: defacer <defacer>
Date:   Tue, 12 Apr 2005 06:58:10 +0800
Tag:    v1.6.0

Fix for bug 2821. I 'm not sure if it makes any difference, but it cannot hurt.

commit ec6dc7035341541af9a866c005fa2c1be64c506d
Author: defacer <defacer>
Date:   Mon, 11 Apr 2005 18:49:17 +0800
Tag:    v1.6.0

Removing obsolete language strings.

commit a03d61346e3d939c4730967e7d1605366708498d
Author: defacer <defacer>
Date:   Mon, 11 Apr 2005 04:28:48 +0800
Tag:    v1.6.0

1. get_records_csv also needs a table name in addition to file name. 2. is_readable() check before trying to fopen() http://, if you happen to not have    an internet connection this prevents ugly failures.

commit 6571aa7cbd6c4c5b39e9a8a47d0e7307e5beb46f
Author: defacer <defacer>
Date:   Mon, 11 Apr 2005 04:25:41 +0800
Tag:    v1.6.0

Timezones always exist (the trivial ones, at least).

commit dddb014acf263d0fb3844953e74ccc8c795f5b5a
Author: defacer <defacer>
Date:   Sun, 10 Apr 2005 17:41:46 +0800
Tag:    v1.6.0

1. make_timestamp: It's easy to be a fool, but to do it like me requires innate talent.

commit c9e55a2583c0295ac9d352f1481b8e9b68f729f7
Author: defacer <defacer>
Date:   Sun, 10 Apr 2005 17:31:21 +0800
Tag:    v1.6.0

LIMIT 1 was already being introduced by get_record_sql, and GMT offsets weren't working due to the bad query.

commit fdae5b1314fc57e88d84a93f6b9ad96d1621a97d
Author: defacer <defacer>
Date:   Sun, 10 Apr 2005 17:19:28 +0800
Tag:    v1.6.0

The strict type checking was causing trouble. In any case, forcing arrays to NOT mix integer and string keys is a good workaround.

commit ce9707f5aac26698c17b373decdcbc31d89d65cd
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 18:20:53 +0800
Tag:    v1.6.0

As there was no armageddon since I commented out the "old" timezone setting HTML yesterday, I 'm now completely removing it.

commit 88c39f4a91f3691f1368a8c8635e495be93a30e5
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 18:19:09 +0800
Tag:    v1.6.0

Update variables configuration to allow setting non-trivial timezones for the server as well.

commit 989585e9336b5dcd7caca6178566afe96be7b592
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 18:12:30 +0800
Tag:    v1.6.0

Major step forward once more: calculate_user_dst_table() now always sees the user's effective timezone correctly using get_user_timezone(). It also remembers which timezone was in effect when it cached its calculations, so if the user's effective timezone changes for any reason the table is automatically re-computed.

commit 6dc8dddc62673162a92dc79c1554d59f7524b318
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 17:50:08 +0800
Tag:    v1.6.0

Removed another unnecessary get_user_timezone_offset() call.

commit 13e5588de8a444442b64ef1524192c3c861beeee
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 17:47:01 +0800
Tag:    v1.6.0

Removed unneeded get_user_timezone_offset() call; usertime() does it anyway.

commit 02a53094399ef2c470adfe8d1edbcb727fd60c44
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 17:36:47 +0800
Tag:    v1.6.0

If $CFG->forcetimezone is not empty, don't allow users to change the timezone from their profiles, and instead show a disabled menu with the forced timezone selected.

commit e8904995f012febdbaa6ce9b9b380d5234fae86b
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 04:32:40 +0800
Tag:    v1.6.0

Introduce the "new" get_user_timezone, and implement get_user_timezone_offset in terms of it.

commit 02c2881b40f02287d4c5977188f01b20eb275353
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 04:28:19 +0800
Tag:    v1.6.0

The user Timezone setting now allows both trivial and non-trivial timezones.

commit 256ab4c54ad9d7f951ee481c8c524030d4470b33
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 04:26:36 +0800
Tag:    v1.6.0

Correct handling of integer keys in the presets array.

commit b529815b9ce47d2b562130465a067b4fccea6b75
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 04:24:20 +0800
Tag:    v1.6.0

Remove some useless strings.

commit 68c0264e1bd3b22bd771b7e5228c0a192ccc1fa3
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 03:50:01 +0800
Tag:    v1.6.0

Changes to mdl_user:

commit f3729a941dea87c93197e59396ed95a7154d64f9
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 03:37:15 +0800
Tag:    v1.6.0

New lang file, we 're going to internationalize all the timezone names in it.

commit 9fb7ea024ded52ecf52d7de25b0228aaa4bbd372
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 03:36:15 +0800
Tag:    v1.6.0

get_string() should read stuff from timezones.php

commit 9a382a5c5eb57977bcb86808f617d26f10770e69
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 03:35:05 +0800
Tag:    v1.6.0

Setting $CFG->forcetimezone now fully works. One more item crossed out from the TODO list.

commit ffc141e4bee0a7ae005ada157ff7cff121e0b1d9
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 03:34:19 +0800
Tag:    v1.6.0

Don't add trivial timezone records in the db, we 're going to handle them manually.

commit 97e28cc66d72d6e344ffc525ff0a92659e275497
Author: defacer <defacer>
Date:   Sat, 09 Apr 2005 03:32:31 +0800
Tag:    v1.6.0

Make choose_from_menu behave correctly in the obscure case where an array contains a zero key and the "selected" variable is a string. Argh.

commit 2665e47afcf94538ee06ce5f6e1302bf2bdcf9f8
Author: defacer <defacer>
Date:   Fri, 08 Apr 2005 13:39:53 +0800
Tag:    v1.6.0

usertime() now compensates for DST.

commit 43b59916f67f840bafa28f696fe277e5aac2b973
Author: defacer <defacer>
Date:   Fri, 08 Apr 2005 13:28:39 +0800
Tag:    v1.6.0

get_user_timezone() should now be working for users with new-style timezone settings.

commit b86e6ba91832ab8e82c6ce68f95cb3edd9dc7e5d
Author: defacer <defacer>
Date:   Fri, 08 Apr 2005 13:01:09 +0800
Tag:    v1.6.0

is_executable() doesn't exist in PHP/Win < 5.0.0