Git commits in Moodle 1.6.x by mark-nielsen

commit f9fbfb4659a5809e76173635beebdbd41816236e
Author: mark-nielsen <mark-nielsen>
Date:   Wed, 06 Dec 2006 10:45:31 +0900
Tag:    v1.6.4

Changed the fix to match what is in HEAD

commit 9b00e4cf7298a2fef0506281120f045399205b26
Author: mark-nielsen <mark-nielsen>
Date:   Wed, 06 Dec 2006 10:35:11 +0900
Tag:    v1.6.4

Bug fix: student response was not displaying for numerical questions, this bug does not exist in 1.7

commit c630b0ba8681e79e35adb068b58b57db915c8f45
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 24 Sep 2006 14:03:18 +0800
Tag:    v1.6.3

MDL-6628 bug fix

commit e2eb5063711ed18c6c6e033652e38dee2bbd13e8
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 10 Sep 2006 01:25:21 +0800
Tag:    v1.6.2

MDL-5430 - branch table redirect problem

commit 9f811896b829e0f171e5537ab018e6ceff6f9736
Author: mark-nielsen <mark-nielsen>
Date:   Sat, 09 Sep 2006 02:01:12 +0800
Tag:    v1.6.2

Security fix for grading Essays.  Mentioned in MDL-6477

commit 4e2cbb28e57f8f79cf4379f26b18ae4d76e533be
Author: mark-nielsen <mark-nielsen>
Date:   Tue, 29 Aug 2006 04:01:13 +0800
Tag:    v1.6.2

MDL-6325 Bug Fix

commit 91bfeb65ea73036beb15f0ec9c0d87b8903e5bbf
Author: mark-nielsen <mark-nielsen>
Date:   Sat, 26 Aug 2006 06:51:24 +0800
Tag:    v1.6.2

MDL-6323 - Fixed - changed feedback to response

commit 16ae471c30f13be49127e5f6a729357ffa991b45
Author: mark-nielsen <mark-nielsen>
Date:   Sat, 26 Aug 2006 02:27:12 +0800
Tag:    v1.6.2

Removed undefined index notices by using empty to make sure the index exists

commit 09447862c0f34c442d06f92c54a797d4f48bcabb
Author: mark-nielsen <mark-nielsen>
Date:   Thu, 13 Jul 2006 08:34:20 +0800
Tag:    v1.6.1

[BugFix] Bug #5466 - Cluster and End of Cluster pages no longer display scores in extended editing view.  Also added page type display for cluster and end of cluster pages in the extended editing view (which is displayed for all other pages as well).

commit 2711fbb039783e8a7e36905deb4df518b6dd35ed
Author: mark-nielsen <mark-nielsen>
Date:   Fri, 19 May 2006 08:59:22 +0800
Tag:    v1.6.0

[BugFix] Bug #5405 - made a new function that grades a lesson for a specific user's attempt.  This is then used for grad ing lessons at the end of a lesson, for ongoing score feature and for updating the grade for essay question grading.

commit d226adef8b223e6f6b8d82752d03ecfc2475df6f
Author: mark-nielsen <mark-nielsen>
Date:   Fri, 19 May 2006 08:54:15 +0800
Tag:    v1.6.0

[BugFix] Bug #5405 - made a new function that grades a lesson for a specific user's attempt.  This is then used for grad ing lessons at the end of a lesson, for ongoing score feature and for updating the grade for essay question grading.

commit 13f944bc559da9f5b457ff79f0c39939bc19d3dc
Author: mark-nielsen <mark-nielsen>
Date:   Tue, 16 May 2006 11:04:44 +0800
Tag:    v1.6.0

[BugFix] Bug 5485 - problem with regular expressions with simple analysis

commit 3f566d8f2ecceb5be1701d4a81d6824f22628a6b
Author: mark-nielsen <mark-nielsen>
Date:   Tue, 16 May 2006 03:05:58 +0800
Tag:    v1.6.0

[BugFix] Bug 5505 - function lesson_print_tree now checks for teacher editing priv before printing editing icons.  Had to change arguments for this function as well which is the edit in view.php.

commit 432c2219f51d410363488bb35d6ab1c07350ac78
Author: mark-nielsen <mark-nielsen>
Date:   Wed, 03 May 2006 01:05:29 +0800
Tag:    v1.6.0

[BugFix] Bug #5396 - Found that the css float was causing the odd problem.  Removed extra styles for the button layout and changed the divs around the buttons to spans

commit 53354ec03c170b87d745adaf518ed96543f4cb65
Author: mark-nielsen <mark-nielsen>
Date:   Mon, 01 May 2006 10:56:06 +0800
Tag:    v1.6.0

Due to changes in Quiz which allows commenting and manual grading of all question types, essay no longer needs its two tables: question_essay and question_essay_states

commit be1af5b770fa1f053e51c9d292edcc450bf0f02c
Author: mark-nielsen <mark-nielsen>
Date:   Sat, 29 Apr 2006 15:37:52 +0800
Tag:    v1.6.0

Moved the require login and isteacher checks to infront of the form data processing

commit 6cd88ca593db05309133da4bba699eafd5fde503
Author: mark-nielsen <mark-nielsen>
Date:   Sat, 29 Apr 2006 09:42:28 +0800
Tag:    v1.6.0

REMOVED: This feature is no longer in the lesson settings screen.  This functionality has moved to report.php

commit fe9588b97132d218b70d47d5acc9b3113fcc54db
Author: mark-nielsen <mark-nielsen>
Date:   Sat, 29 Apr 2006 09:40:18 +0800
Tag:    v1.6.0

Deleted lang entry for Deleting student attempts in the lesson settings page.  This functionality has been moved to report.php

commit 31eb5b53357e99873f7dc1dfcac511b322c8e06e
Author: mark-nielsen <mark-nielsen>
Date:   Sat, 29 Apr 2006 09:37:50 +0800
Tag:    v1.6.0

[Removed] the Delete user attempts option in the Lesson settings (changes to mod and lib) [Added] new functionality to report.php to delete individual student attempts [Fixed] High scores text in view.php when no high scores were recorded needed to be centered

commit 718dbada67e47b7eff9de3969b96f24bfb09d3a8
Author: mark-nielsen <mark-nielsen>
Date:   Fri, 28 Apr 2006 00:48:38 +0800
Tag:    v1.6.0

[Fix] Notices were being printed in PHP5 for NULL objects.  Checking for NULL now before using in multichoice and truefalse questions

commit 066c0af9bf669c4f02f7c41ce5c94b6b4c7880c9
Author: mark-nielsen <mark-nielsen>
Date:   Fri, 28 Apr 2006 00:20:55 +0800
Tag:    v1.6.0

[Fix] Error with PHP5.  Needed to clone the lesson object before saving the $default object

commit 804d664acfa676a9d3f9709a01ee691ada531d12
Author: mark-nielsen <mark-nielsen>
Date:   Tue, 11 Apr 2006 10:20:58 +0800
Tag:    v1.6.0

[BugFix] Bug #5072: user name now links to user profile, Attempts column changed to Completed On, new column with link Grade to grade all attempts.  Other table changes include collapsible columns and its id has been changed to attempts to reuse styles for the attempts table.

commit 6e63c77795f41bc59ad23f188bb4764d08ce5238
Author: mark-nielsen <mark-nielsen>
Date:   Tue, 11 Apr 2006 10:02:44 +0800
Tag:    v1.6.0

[Fix] question_process_comment now processes the correct form values [Fix] changed the print_string to get_string so it may be passed to notify [Change] The close window button is now centered [Change] Refreshes the parent window when the close window button is pushed

commit a472184c7b54272bf78c59a8b43bc6516f3db379
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 09 Apr 2006 05:51:29 +0800
Tag:    v1.6.0

Updated questiontype.php to make essay compatible with manual grading (aka removed a lot of code).

commit dbb3c4c6eaf19e0ea378466ecd2520f3569f3c76
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 09 Apr 2006 05:48:31 +0800
Tag:    v1.6.0

Added $prefix to form fields so that this code could be used with manual grading

commit caca24d5d3c9d2884acfa0bb232bd81b2ee64b27
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 09 Apr 2006 05:46:59 +0800
Tag:    v1.6.0

Minor updates:   comments no longer print inside the question (only in the textfield)   fixed problem with quotes by adding addslashes

commit e99b375972bc0420786b90bd5c75cd3b942c98ce
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 09 Apr 2006 04:55:03 +0800
Tag:    v1.6.0

Updated the form handling code.  This report is now functional again.

commit fbe4d5ce51ead1e6833fa564b2eb3c10b1911306
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 09 Apr 2006 02:56:39 +0800
Tag:    v1.6.0

Updated viewquestion to be more generic and moved it to its own function

commit 0a5252112260b1b81fe6646b9b8399209793123d
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 09 Apr 2006 02:24:49 +0800
Tag:    v1.6.0

Updated the viewquestions action to be more generic so that any manually graded question type would be compatible. Moved viewquestions code to function view_questions.  This is an attempt to make the code much more readable.  All action code will eventually be moved to its own function.

commit 6e49714287d61c1c6a6978393acda90e6aeac74e
Author: mark-nielsen <mark-nielsen>
Date:   Sat, 08 Apr 2006 18:29:25 +0800
Tag:    v1.6.0

Changed the Make comment or override grade link display the comment field and grade field in review.php instead of popup

commit 42b245d1ca03dd21d1559e73454fc912b69067a7
Author: mark-nielsen <mark-nielsen>
Date:   Sat, 08 Apr 2006 16:16:04 +0800
Tag:    v1.6.0

Moved the submit button to question_print_comment_box in lib/questionlib.php

commit 31f6b26d4ff2ce7b67e53c017a91e5b78285904e
Author: mark-nielsen <mark-nielsen>
Date:   Fri, 07 Apr 2006 07:03:08 +0800
Tag:    v1.6.0

[BugFix] Action was using global variables - now is fetched with optional_param

commit 07de03b06af24c8787cb03b8da253bcefb8f0ec8
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 26 Mar 2006 08:13:37 +0800
Tag:    v1.6.0

[Added] two new lang entries for import.php

commit 90455bb3abd5900c7479087f356d1533de7e241f
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 26 Mar 2006 08:10:39 +0800
Tag:    v1.6.0

[Fixed] Import.  Updated code to work with /question instead of /mod/quiz.  Lead to a few interal bug fixes.  Also moved two hard coded strings to the lang file.

commit 69baf10f7457db4a3dfffee33b62cc6a7b14d5ac
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 26 Mar 2006 05:43:10 +0800
Tag:    v1.6.0

[Removed] Tree view setting has been removed.  Its functionality has been replaced with the tabs.

commit 97d2756c65f516ab75e3801e5d9d0c4269266968
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 26 Mar 2006 05:38:57 +0800
Tag:    v1.6.0

[New Feature] Tabbed navigation added to lesson (similar to quiz) [Added] Graceful fails added to view.php, essay grading, and reports [Changed] got rid of a lot of references to $_POST/GET/REQUEST [Fixed] In reports, it required teacheredit, should only be teacher [Changed] High scores - teachers can actually see them!  Also, improved output by using print_table and print_heading [Changed] Grade essays now uses fullname() to print user names

commit b59c1d77e941d9f19860091a131c67755bb0946d
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 26 Mar 2006 05:29:20 +0800
Tag:    v1.6.0

[New] lang entries for tabs [Changed] old lang entries to help bring consistancy and unity to the different lesson pages

commit 8bd7bacd1479eb68009e38ea816b1b30bd7b748a
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 19 Mar 2006 10:16:00 +0800
Tag:    v1.6.0

[Fixed] this page was shooting of warnings for unset variable score.  Now checks to make sure score is set before using it.

commit aeade7e2271945f20e0c1191188a83603b3ac39f
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 19 Mar 2006 10:08:37 +0800
Tag:    v1.6.0

cleaned up the left menu feature output by removing an unused form and several unnecessary string concatenations

commit 289218844a493721c629cb9f192040c08c57a6e5
Author: mark-nielsen <mark-nielsen>
Date:   Sun, 19 Mar 2006 09:53:50 +0800
Tag:    v1.6.0

[Changed] The print_simple_box_start/stop changes conflicted greatly with the display of branch table buttons (the box printed above the buttons some how sad )  To fix this, the tables were taken out and divs were used instead to display and arrange the buttons.  This turns out to be a good thing because now the user has more control over the buttons via style sheet.  Also did some extra clean up in the section of code printing the branch table. [Added] new styles to styles.php to help display the buttons correctly.

commit 0646963948a887e36972127fefc919b7831a2de6
Author: mark-nielsen <mark-nielsen>
Date:   Fri, 17 Mar 2006 11:37:31 +0800
Tag:    v1.6.0

[Changed] function execute_teacherwarning to function lesson_display_teacher_warning because it was violating the function naming policy

commit 4b55d2aff2a46856a6976e9318bc78d6cacb7398
Author: mark-nielsen <mark-nielsen>
Date:   Fri, 17 Mar 2006 11:31:19 +0800
Tag:    v1.6.0

[Added] added phpdoc comments to locallib.php