Git commits in Moodle 1.5.3 by mjollnir_

commit 25c741d659b1b017c5fa71b72585d75fe937d8be
Author: mjollnir_ <mjollnir_>
Date:   Thu, 17 Nov 2005 10:30:17 +0800
Tag:    v1.5.3

Fixing misnamed variable in forgot password link in login block

commit 50d7a3a52e74354b5033b4411a455b077f8d1927
Author: mjollnir_ <mjollnir_>
Date:   Thu, 17 Nov 2005 10:26:49 +0800
Tag:    v1.5.3

Pulling in a missing global CFG in datalib:execute_sql (affects CFG->dblogerror)

commit 56094311819a00430f6e52e9c741425330e5d36e
Author: mjollnir_ <mjollnir_>
Date:   Wed, 16 Nov 2005 10:11:52 +0800
Tag:    v1.5.3

Another fix to the perf printing patch from earlier. I didn't realise that 'no' in the context of perf means 7 ;)

commit 9661a67c6654e66581dd7545dabc9edc21a11247
Author: mjollnir_ <mjollnir_>
Date:   Wed, 16 Nov 2005 09:37:08 +0800
Tag:    v1.5.3

Fixing merging problem in the quiz report fix ealier - disabling wrong checkbox for site course quizes

commit d50bb6869211ba52e32b234ad1ce711ddc0e6b4d
Author: mjollnir_ <mjollnir_>
Date:   Wed, 16 Nov 2005 06:07:39 +0800
Tag:    v1.5.3

Fixing bug 4303 - quiz reports dying on large enrolments - getting all users into an array and imploding it into an IN() replaced with joins. This changes the functionality SLIGHTLY in two ways - 1. show students with no attempts now JUST shows students with no attempts, rather than both.  Show students with no attempts is now disabled for the site course as is not really relevant and could be ridiculously large

commit 9c9d5ae18f8db1cf96e1ca64981132652c23f806
Author: mjollnir_ <mjollnir_>
Date:   Wed, 16 Nov 2005 05:32:30 +0800
Tag:    v1.5.3

Better logic for printing perf info in the footer - should be distinct from the validation stuff

commit 8df570f284b31f95006f58a1b8e54e7fd2636ea9
Author: mjollnir_ <mjollnir_>
Date:   Wed, 16 Nov 2005 05:21:53 +0800
Tag:    v1.5.3

Fixing up the missing perfdebug string in admin, turning perf on in the default footer using $CFG->perfdebug

commit 23eb2bbc57e554b80b16e3008306f0368b838721
Author: mjollnir_ <mjollnir_>
Date:   Wed, 16 Nov 2005 05:19:11 +0800
Tag:    v1.5.3

Fixing typo in 1.5.3 release notes s/plugi/plugin/

commit a7db9eb28eb3621a7cd1d813eab53ee8cb0e3bb7
Author: mjollnir_ <mjollnir_>
Date:   Mon, 14 Nov 2005 10:35:56 +0800
Tag:    v1.5.3

Merged from HEAD: fixing bug 4244: rss client block long titles and broken editing link. Partly backporting daryls fix, part my own fix

commit ed2de86926ca0ff8ccd05921af945a2258d4649c
Author: mjollnir_ <mjollnir_>
Date:   Mon, 14 Nov 2005 10:30:49 +0800
Tag:    v1.5.3

(delayed) merge from HEAD: fixing bug#4199

commit 122b18f02f5bbb1c6df90cd568e7762b1a5880f3
Author: mjollnir_ <mjollnir_>
Date:   Mon, 14 Nov 2005 05:19:05 +0800
Tag:    v1.5.3

Getting directory sizes with du - use escapeshellarg on the file/directory as unzipping files on the server can result in filenames that need escaping

commit f253e2575f67647e141ebfee21f1ccc09e48cf95
Author: mjollnir_ <mjollnir_>
Date:   Wed, 02 Nov 2005 10:25:45 +0800
Tag:    v1.5.3

Fixing warning in course import (part of bug 4199)

commit 5ed1a6d692749bc6deee904f41e18e33c8e1eaa4
Author: mjollnir_ <mjollnir_>
Date:   Thu, 27 Oct 2005 05:18:41 +0800
Tag:    v1.5.3

Now the login block uses the same logic for forgot password as the login page does

commit 96bf2d385fb503b72d317bcb22057a858faf2d04
Author: mjollnir_ <mjollnir_>
Date:   Thu, 20 Oct 2005 08:19:24 +0800
Tag:    v1.5.3

Fixing bug 4199: import course data should only allow you to import from a course that you're already a teacher in, unless you're at least a creator

commit 04c9c465f95cf448deb4e78652524d47589e4f21
Author: mjollnir_ <mjollnir_>
Date:   Wed, 12 Oct 2005 10:15:23 +0800
Tag:    v1.5.3

Execute some updates silently (dropping non existent columns in workshop) bug 2964

commit dde5cbbdfda1be200c925be5b64e5e4a56d81d70
Author: mjollnir_ <mjollnir_>
Date:   Wed, 05 Oct 2005 09:35:14 +0800
Tag:    v1.5.3

Fixing the mass migrate postgres upgrade to be silent in quiz. Added a fix to a previous rename table that breaks pg_dump & pg_restore (incorrectly named sequence)

commit 38f78e158c053b1f81724ebd7d099f0a2d996166
Author: mjollnir_ <mjollnir_>
Date:   Wed, 05 Oct 2005 05:26:01 +0800
Tag:    v1.5.3

Fixing sortorder typo

commit 70f6f8b7084bc934af7fdba0ba44bedc44fbccd6
Author: mjollnir_ <mjollnir_>
Date:   Fri, 30 Sep 2005 07:39:52 +0800
Tag:    v1.5.3

Much better namespace collision fix to apacheloguser thing

commit 98f052303f8f3fed8eb061c013411f1f662b9fc2
Author: mjollnir_ <mjollnir_>
Date:   Fri, 30 Sep 2005 05:53:48 +0800
Tag:    v1.5.3

Fixing up the log apache user patch from the otherday - problem with variable scope

commit 85508791a6e49b76b9e2a03b1972b5ecdde28950
Author: mjollnir_ <mjollnir_>
Date:   Thu, 29 Sep 2005 08:34:25 +0800
Tag:    v1.5.3

Adding default for  new config option pathtodu. Related to bug 4107

commit 73ec9fb26eaf444677aded8fc48d193709bcc823
Author: mjollnir_ <mjollnir_>
Date:   Tue, 27 Sep 2005 13:24:43 +0800
Tag:    v1.5.3

Logging apache user now takes into account loginas

commit 681d95c495c8191a87c7a60b1bc316cc8a2195ac
Author: mjollnir_ <mjollnir_>
Date:   Fri, 23 Sep 2005 12:33:47 +0800
Tag:    v1.5.3

Backported Martin's sortorder fix from HEAD. Apparently this is a better fix than the one from a few days ago

commit 5d8323d57c9cc5cb321496787293cb6f5d56c624
Author: mjollnir_ <mjollnir_>
Date:   Wed, 14 Sep 2005 06:21:20 +0800
Tag:    v1.5.3

Login block should be more discerning about offering signup link. Fixed to be more in line with the login page

commit 1068ba8d27053db2a11bcd4cde0a17c0ae52e2ba
Author: mjollnir_ <mjollnir_>
Date:   Fri, 09 Sep 2005 07:04:10 +0800
Tag:    v1.5.3

Much more sophisticated IP address cleansing

commit d9ab06ca32d0b907165da7b4f66a02c1a40a7892
Author: mjollnir_ <mjollnir_>
Date:   Fri, 09 Sep 2005 05:31:41 +0800
Tag:    v1.5.3

Merged from HEAD: Fix to bug 4026 and 3913. Credit: jjg7 at humboldt dot edu

commit 4e9cc4842f796c88009f84c83adf95ddcb474f5c
Author: mjollnir_ <mjollnir_>
Date:   Thu, 08 Sep 2005 06:00:16 +0800
Tag:    v1.5.3

Performance fix: in postgres, sometimes indexes are not used because of type casting. block_instance.pageid is a big int field so the index wasn't being used. Wrapping in '' prevents the typecast. See http://www.postgresql.org/docs/7.4/interactive/datatype.html#DATATYPE-INT for more information

commit 72ed1089dd108f548e6b90c8422c985cd3b0f470
Author: mjollnir_ <mjollnir_>
Date:   Wed, 07 Sep 2005 12:45:52 +0800
Tag:    v1.5.3

Further tidyup to the cleanremoteaddr function I added - some thing were getting through

commit e1fede4e6326e40f6bf14cd9d8ec0e0805e874b0
Author: mjollnir_ <mjollnir_>
Date:   Wed, 07 Sep 2005 12:43:05 +0800
Tag:    v1.5.3

Better fix to the messaging problem. Will make mysql <4 users happy too. Credit for php workaround:Eloy

commit fa1ce50ec831b19f8a4c81d81d61044e17764c4c
Author: mjollnir_ <mjollnir_>
Date:   Wed, 07 Sep 2005 05:23:09 +0800
Tag:    v1.5.3

Backing out a previous patch of mine - bad merge with our local copy

commit 926a759c7105e43ffa23eadf24d64e1e89f135e0
Author: mjollnir_ <mjollnir_>
Date:   Mon, 05 Sep 2005 13:30:53 +0800
Tag:    v1.5.3

Performance fix for get_directory_size: new config option for path to du - if we have it, use that instead. MUCH faster on directories with a lot of files

commit c11d468cc123354106c9a183dca917fd32f126ec
Author: mjollnir_ <mjollnir_>
Date:   Mon, 05 Sep 2005 05:07:23 +0800
Tag:    v1.5.3

Fixing up a bug in the log selector to do with optionally showing all users in the dropdown when over COURSE_MAX_USERS_PER_DROPDOWN

commit c6a37a3185aad6359ed2f1cc7aab0327721e4614
Author: mjollnir_ <mjollnir_>
Date:   Fri, 02 Sep 2005 12:58:57 +0800
Tag:    v1.5.3

Add an index where we really need it - block_instance.pagetype

commit 18c26f97efb5d576433108645647d8b54a7e901e
Author: mjollnir_ <mjollnir_>
Date:   Thu, 01 Sep 2005 07:57:37 +0800
Tag:    v1.5.3

Fixing bug 3977: sort of. Check for mysql >= 4 or postgres, do a smarter query with a UNION. Otherwise, do the same old query. This is not very good for mysql 3.23 users with large datasets, but not much else I can do.

commit e2629fc12d93ddc2ee6e2c96beb39feabe3f1efd
Author: mjollnir_ <mjollnir_>
Date:   Wed, 31 Aug 2005 14:13:13 +0800
Tag:    v1.5.3

Preventing another warning.  In some cases in the  calendar blocks, resource filtering gets called with no courseid

commit c3a70f83b181e1186be903dab1c41e7fa30f9ea5
Author: mjollnir_ <mjollnir_>
Date:   Wed, 31 Aug 2005 13:24:17 +0800
Tag:    v1.5.3

Avoid a warning when displaying multichoice quiz questions

commit f2179d4688f8ebaad8e393fb8b6d51ea2ecec46c
Author: mjollnir_ <mjollnir_>
Date:   Wed, 31 Aug 2005 10:29:52 +0800
Tag:    v1.5.3

prevent stuff being sent to the browser before config.php being included

commit 8ba12d576a0bacad2a08825d62fea60b3a6c6707
Author: mjollnir_ <mjollnir_>
Date:   Fri, 26 Aug 2005 13:28:55 +0800
Tag:    v1.5.3

Escape strings for database. SC # 145

commit 9f65fc2b2760dacf49722e768f6679c51a92ff00
Author: mjollnir_ <mjollnir_>
Date:   Fri, 26 Aug 2005 12:53:24 +0800
Tag:    v1.5.3

Fixing typo in call to get_record that was causing a lot of noise in the db error log

commit 12c40a2f66d4c3bca194c81362890a23d9e892c1
Author: mjollnir_ <mjollnir_>
Date:   Fri, 26 Aug 2005 12:41:33 +0800
Tag:    v1.5.3

Backticks are not postgres friendly! sad

commit 289cf90737736d5befcc6e22c1371b1f4c6d6663
Author: mjollnir_ <mjollnir_>
Date:   Thu, 25 Aug 2005 08:02:49 +0800
Tag:    v1.5.3

Fixing another postgres problem. With distinct, you can't order by a field not in the select field list

commit cef4a0e828600e056ebe381851b62e835c77a3ac
Author: mjollnir_ <mjollnir_>
Date:   Thu, 25 Aug 2005 07:47:51 +0800
Tag:    v1.5.3

Fixing typo in postgres-fixing patch from a couple days ago

commit 65ebc47636489a93403df4c1b7bfe948e101e86a
Author: mjollnir_ <mjollnir_>
Date:   Tue, 23 Aug 2005 14:46:35 +0800
Tag:    v1.5.3

Backticks are NOT ALLOWED in postgres!

commit 5747bf91e53f7b0a5a3da2d1bb657c132697c66f
Author: mjollnir_ <mjollnir_>
Date:   Tue, 23 Aug 2005 13:33:12 +0800
Tag:    v1.5.3

Fixing metacourses to work in mysql 3.23 series. At same time, set enrolment type to 'metacourse' so as not to break some external enrolment (eg ldap) plugins

commit 7e61008580af29cab862fb9400502a2fb4e69d88
Author: mjollnir_ <mjollnir_>
Date:   Thu, 18 Aug 2005 09:44:10 +0800
Tag:    v1.5.3

Clean up IP addresses from getremoteaddr. Otherwise we sometimes get weird results from proxies and inserts into mdl_log and mdl_user fail

commit 05746e64f2e1250e4cce2052d601739028fc6f2e
Author: mjollnir_ <mjollnir_>
Date:   Thu, 18 Aug 2005 07:16:34 +0800
Tag:    v1.5.3

Fixing a postgres error. You can't sort by a field that isn't in the select list when you have distinct

commit 04f1658794a54677746e4e0f302e5433ced5814e
Author: mjollnir_ <mjollnir_>
Date:   Thu, 11 Aug 2005 12:24:15 +0800
Tag:    v1.5.3

When fetching child courses for a metacourse, order by shortname (unless just counting)

commit e14b9cd27cf1909397e0cac16ae3746e876cb091
Author: mjollnir_ <mjollnir_>
Date:   Thu, 11 Aug 2005 11:38:08 +0800
Tag:    v1.5.3

Changing the js timer in quiz to call the form by name rather than index. People who have forms in the headers (ie logout buttons) run into problems otherwise

commit 4eb27d4a74f51ed1922369de47f4e3a03e1aee04
Author: mjollnir_ <mjollnir_>
Date:   Tue, 09 Aug 2005 12:50:02 +0800
Tag:    v1.5.3

Fixing another group by postgres error. You can't put fields into the select that aren't in the group by unless they're functions like max

commit 14f872baecc3fc998057d404fa4a73d8078745c5
Author: mjollnir_ <mjollnir_>
Date:   Wed, 03 Aug 2005 06:47:57 +0800
Tag:    v1.5.3

Postgres doesn't happily convert NULL to 0 for int fields, so we set it manually. Credit: Patrick Li

commit 84325f54bd04add61d96a1039ed0c89126adcdba
Author: mjollnir_ <mjollnir_>
Date:   Wed, 03 Aug 2005 06:39:49 +0800
Tag:    v1.5.3

Adding a length limit to input field in line with db field size