General developer forum

Re: id to full name

Tim Hunt — Sat, 04 Jul 2009 14:47:04 GMT

by Tim Hunt.

First, you concatenation won't work very well without spaces (at least in European languages).

Then there is the fact that some institution have rules about who is allowed to see the full names of students, and the fullname function, in combination with some administrator settings, correctly implements the necessary rules.

Finally, a JOIN is always better for performance than get_records_list.

Re: Add more parameters to Resource Link to a file

Ben Watson — Sat, 04 Jul 2009 13:08:23 GMT

by Ben Watson.

I've answered my own question. By deleting the &user=2 and entering $user in the parameters section of advanced options, I was able to show reports for only the current use.

I had a great deal of difficulty finding/figuring out this information, and don't think it should be so. I don't know how to contribute to Moodledocs yet, but will keep in mind as I do more.

Re: Add more parameters to Resource Link to a file

Subodh Iyengar — Sat, 04 Jul 2009 13:06:40 GMT

by Subodh Iyengar.

the $USER not $user variable is initialized in the setup.php file. It is just a renamed session variable so it is shared by all files that include config.php which includes setup.php.
If you need to use $USER outside a function youre good to go, but to use it within a function, you need to declare it as a global variable using

global $USER;
Then you can access the user id through the $USER->id field.

Re: id to full name

Subodh Iyengar — Sat, 04 Jul 2009 12:52:57 GMT

by Subodh Iyengar.

easier way..
be sure to include config.php

require_once("relative path to config.php");
$userid=id to be selected;
$userrec=get_record('user','id',$userid);
echo $userrec->firstname.$userrec->lastname; // concatenate firstname and lastname.

if you want to do it for a lot of ppl.. use this

$ids is a comma seperated value list of all the ids to be selected. eg "1,2,3". Im assuming you know how to do that.

$userrec=get_records_list('user','id',$ids);
foreach($userrec as $key=>$value){
echo $value->firstname.$value->lastname;
}

Re: Add more parameters to Resource Link to a file

Ben Watson — Sat, 04 Jul 2009 12:14:02 GMT

by Ben Watson.

I'm trying to display the results of a questionnaire for the current user by "Link to a File or Website" and using for my url

http://trainingweb.org/moodle/mod/questionnaire/myreport.php?instance=4&user=2&byresp=0&action=vresp

Which brings up the report for user=2

Is there a way to use a variable to get the current user only?

From what I can find, $user seems to be available somehow, but I don't know code and don't quite find what I'm searching for.

Re: intranet running

Mary Cooch — Sat, 04 Jul 2009 09:26:46 GMT

by Mary Cooch.

yes. It doesn't have to be online at all.

intranet running

vishakha kamble — Sat, 04 Jul 2009 09:02:32 GMT

by vishakha kamble.

can moodle run in intranet

Re: course schedule by date

defus defus — Sat, 04 Jul 2009 09:02:15 GMT

by defus defus.

You can copy this file in directory {moodledata}/1/ and name it enrolments.txt. You can also copy the full path of your file in the config page of flat admin. Dont forget to enable flat enrolment also.

To execute the file, lanch the URL {moodl_base_url}/admin/cron.php in the browser.

The cron ill automaticaly enrol students for you.

Here is an example of file with enrolment date :
opération, rôle, ID (utilisateur), ID (cours) , début, fin
add, student, 4, 20, 1246697016, 1247301944
add, teacher, 5, 20, 1246697016, 1247301944

Note that the ID number course 10 must exist and the users 4 and 5.

Re: id to full name

Tim Hunt — Sat, 04 Jul 2009 08:59:14 GMT

by Tim Hunt.

The fragment of code you need to get one user's name from their id is
$user = get_record('user', 'id', $userid);
$name = fullname($user);

However, if you are displaying a report with lots of teachers' names, doing that lots of times is really bad because each separate call to get_record does a separate database query, which is quite slow. You should really try to get all the data you need in one database query.

The data you need for the fullname function is firstname and lastname, so your code should look something like

$data = get_records_sql("
SELECT c.*, u.firstname, u.lastname
FROM {$CFG->prefix}credit c
JOIN {$CFG->prefix}user u ON u.id = c.giver
WHERE ...
");
foreach ($data as $record) {
$name = fullname($record);
// do more with $record.
}

id to full name

Fred Nevers — Sat, 04 Jul 2009 08:25:06 GMT

by Fred Nevers.

Hi all,

Is there a way to transform a user id number to their full name?

I am trying to create a 'report' that will show students which teacher gave them a 'credit'. I have successfully managed to show the teacher's id number but am stuck when transforming this id number to the teacher's real name.

So far, I have tried to use the fullname() function, that failed. I also tried this:

$teachername= $credit->giver; //////this is part of a foreach loop, other DB fields work fine
$teacher= fullname($teachername);

This failed too.

I must be overlooking something obvious (I am very new to PHP). Could anyone please point me to a function that would do what I want?

Cheers,
Fred

Re: Moodle 1.9 + TinyMCE - clean port

Mauno Korpelainen — Sat, 04 Jul 2009 05:32:43 GMT

by Mauno Korpelainen.

Well... I have some opinions:

- Hacks are always hacks and I don't believe that the patch that Bob mentioned could solve the original problem with "moodle modifications" - multilang, translations, administration of settings etc. With theme based integration it has been possible to use not only tinymce or latest CKEditor but also Xinha, FCKEDitor, YUI RTE and in practise any editor because most javascript based editors are ment to be used the same way - to render some init (configuration code) and then replace textareas/divs or some other elements with editors. The main problem has been upgrading and modified editor settings hardcoded in core code of moodle

- theme based integrations work as workarounds because standard code of editor (HTMLArea) of moodle has not been by default pluggable and changable. In moodle 2.0 this will change - Petr Skoda has rewritten editorlib.php and when version 2.0 is stable it will be possible to change both configurations and to create custom editor integrations easier than before.

- many sites allow students to upload files with editor and all students can upload attachments in core moodle as well. I don't think it is a problem if students can't freely upload all types of files and run any scripts they like. Files can include/inject viruses or hidden scripts even if your students don't know it and in some cases students know more about scripts/cracking than teachers but I suppose in 99.9% of cases allowing students to upload files is safe. You have been able to change role settings or override permissions (capabilities) in all versions of moodle since 1.7

- the clean port that Martin wrote was mostly based on code written by Mathieu and current moodle 2.0 is already using a very different code so I suppose Martin won't write a new version for awhile - maybe never. Many people would be happy to see similar changes in moodle 1.9 when 2.0 is stable but I don't believe it will never happen. Moodle 1.9 will stay the last single-default-editor-moodle forever and moodle 2.0 will be using totally different system.

Re: tracker "permission violation" and security patches

Penny Leach — Sat, 04 Jul 2009 05:25:19 GMT

by Penny Leach.

I also wrote a perl script, to which you give a bug number, or series of bug numbers and it writes out formatted patches for you:

http://docs.moodle.org/en/Development:Git_tips#Backporting_stuff_from_cvshead_to_stable_git_branches

It says, "backporting stuff from cvshead" but really it's just a general script that searches the logs and writes you out git-format-patch formatted patches

Re: Moodle 1.9 + TinyMCE - clean port

matt greenwolfe — Sat, 04 Jul 2009 03:02:47 GMT

by matt greenwolfe.

I successfully installed tinymce using this theme-based installation. The other method wasn't working for me, I think because of moodle version issues. I'm using 1.9.4.

I modified three files to allow student uploading of images into directories moddata/images/$USER->id. The uploader no longer requires moodle/course:managefiles, but instead checks for has_capability at all the key spots and denies students to: move up to a level in the directory tree, move files, or create new directories. So each student has access only to their own file area.

I have a few questions if anyone can help.

Does this method leave me open to security problems? I'm not overly concerned about this in my situation, but want to be aware of what might happen and how.

Does the implementation of tinymce for moodle 2.0 include student image file uploads? Does the backport for moodle 1.95 include this feature? I'm trying to figure out whether it will be worth my while to upgrade to 1.95 if/when Bob's backport patch comes out for that version.

Thanks for everyone's work and the informative discussion here. Tinymce is a very nice upgrade, and I'm glad to have it now and not have to wait.

Matt

Re: new $DB->get_existing_record() DML method

Petr Škoda (skodak) — Fri, 03 Jul 2009 22:42:56 GMT

by Petr Škoda (skodak).

I have added new $strictness parameter to get_record() and get_filed() family of methods, adding new methods with different prefix would require at least 6 new methods - thus making the API significantly larger.

The code is in cvs MDL-19689, unittests included. It is not yet used anywhere, so there is still possibility to revert it or change implementation. Any more thought and ideas are welcome.

Thanks everybody!

PS: please have a look at the code/ in-line docs and test if possible

Re: Implications of video-tag in Firefox 3.5

Alan Trick — Fri, 03 Jul 2009 21:16:51 GMT

by Alan Trick.

On top of that, there's legal problems involving transcoding to many formats. Moodle can't ship with codecs that require end-users to pay royalties, it's against our license.

Re: Implications of video-tag in Firefox 3.5

Alan Trick — Fri, 03 Jul 2009 21:11:20 GMT

by Alan Trick.

I think you missed the point. The javascript applet is the fallback (the thing you would embed inside the video element). It would be ignored by any browser sensible enough to support HTML 5 and theora.

The advantage of using Java here is that you can stick the theora codecs into your applet. As such, there's no need to provide two different file formats.

Re: tracker "permission violation" and security patches

Hubert Chathi — Fri, 03 Jul 2009 20:23:02 GMT

by Hubert Chathi.

By the way, you could also use cvsps, or something similar, to get something similar to git's log for CVS. (In fact, git's CVS import uses cvsps.)

Re: tracker "permission violation" and security patches

Hubert Chathi — Fri, 03 Jul 2009 20:15:19 GMT

by Hubert Chathi.

The search on git.moodle.org doesn't seem to be working very well, but searching through the logs in my local copy yields:

MDL-18058:

http://git.moodle.org/gw?p=moodle.git;a=commit;h=696018df63e4b682ddcc4e1ec57f81924947b38a

MDL-18059:

http://git.moodle.org/gw?p=moodle.git;a=commit;h=8d73532067fe5f0848d843ea70eefb9e5f7abe24

MDL-17365:

http://git.moodle.org/gw?p=moodle.git;a=commit;h=eada690a18f017eb747ccfd8fb50d502740a2463
http://git.moodle.org/gw?p=moodle.git;a=commit;h=cc84c1aba05c254a4ef2a45eb838bdd84f5b635b
http://git.moodle.org/gw?p=moodle.git;a=commit;h=62c7a8c799c23c8604b6e045c2ffd23f5dd40e54
http://git.moodle.org/gw?p=moodle.git;a=commit;h=0b174abec7d561f77ca14db4dff619776d9f081a

Re: tracker "permission violation" and security patches

Brian Jorgensen — Fri, 03 Jul 2009 20:05:34 GMT

by Brian Jorgensen.

Petr responded to the original post by suggesting that following the point releases really is the best idea, but generating patches should be possible:

"search for MDL-xx numbers in moodle git repository somehow"

Having very little git experience, I would appreciate any advice from git users on how to use git to generate these patch files?

Thanks,

Brian

tracker "permission violation" and security patches

Brian Jorgensen — Fri, 03 Jul 2009 19:22:13 GMT

by Brian Jorgensen.

(Sorry for cross-posting from Security and Privacy, but it's nearly the weekend here and there were no responses over there so I thought I would try in the dev forum).

I'm curious how everyone grabs security patches if JIRA returns PERMISSION VIOLATION messages for security tickets (which means the handy "version control" tab with links off to viewvc are not available).

For example, what CVS commands would I use to grab the three distinct patches for MSA-09-011?

Unfortunately, upgrading to the latest point release is not an option where I work.

Thanks,

Brian