Quiz

No, I do not use function anonymous for my negative marks hack so I do not know whether it would be interfering with yours.

Here are the 2 files and functions I use:

File: moodle\lib\questionlib.php
function question_apply_penalty_and_timelimit(&$question, &$state, $attempt, $cmoptions) {
    // deal with penalty
    if ($cmoptions->penaltyscheme) {
            $state->grade = $state->raw_grade - $state->sumpenalty;
            $state->sumpenalty += (float) $state->penalty;
    } else {
        $state->grade = $state->raw_grade;
    }

    // deal with timelimit
    if ($cmoptions->timelimit) {
        // We allow for 5% uncertainty in the following test
        if (($state->timestamp - $attempt->timestart) > ($cmoptions->timelimit * 63)) {
            $state->grade = 0;
        }
    }

    // deal with closing time
    if ($cmoptions->timeclose and $state->timestamp > ($cmoptions->timeclose + 60) // allowing 1 minute lateness
             and !$attempt->preview) { // ignore closing time for previews
        $state->grade = 0;
    }

    /* negative marks hack start: commented the line below 
    // Ensure that the grade does not go down
    $state->grade = max($state->grade, $state->last_graded->grade);
    negative marks hack stop */
}


File: moodle\question\type\multichoice\questiontype.php
    function grade_responses(&$question, &$state, $cmoptions) {
        $answers      = $question->options->answers;
        $testedstate = clone($state);
        $teststate    = clone($state);
        $state->raw_grade = 0;
        foreach($answers as $answer) {
            $teststate->responses = array('' => $answer->id);
            if($question->options->single) {
                if($this->compare_responses($question, $testedstate,
                 $teststate)) {
                    $state->raw_grade = $answer->fraction;
                    break;
                }
            } else {
                foreach($state->responses as $response) {
                    $testedstate->responses = array('' => $response);
                    if($this->compare_responses($question, $testedstate,
                     $teststate)) {
                        $state->raw_grade += $answer->fraction;
                         break;
                    }
                }
            }
        }
        if (empty($state->raw_grade)) {
            $state->raw_grade = 0;
        }

        /*  negative marks hack start
        // Make sure we don't assign negative or too high marks
        $state->raw_grade = min(max((float) $state->raw_grade,
                            0.0), 1.0) * $question->maxgrade; */
        $state->raw_grade = min((float) $state->raw_grade, 1.0) * $question->maxgrade;
        // Negative marks hack stop
       
        // Apply the penalty for this attempt
        $state->penalty = $question->penalty * $question->maxgrade;

        // mark the state as graded
        $state->event = ($state->event ==  QUESTION_EVENTCLOSE) ? QUESTION_EVENTCLOSEANDGRADE : QUESTION_EVENTGRADE;

        return true;
    }

I am the one Itamar helped to get this done. Here is the link:

http://moodle.org/mod/forum/discuss.php?d=96915

There is a lot of information there. So if you tell me specifically what your are trying to achieve, i might be able to help you since it has worked for me.

Tieku

Pierre,

I downloaded 1.9.3+ (Build: 20081119) yesterday with the updated MCH. Looks very good without the auto-numbering. Looking forward to the other changes just mentioned. Thanks.

Tieku