-- James Dugal
Thanks for the mod!
Re: Batched upload of assignment grades - need testers
Re: Batched upload of assignment grades - need testers
clicking on "View submitted assignments" (after having clicked on Assignments)
--James
Re: Batched upload of assignment grades - need testers
Feel free to check out Assignment 1 in the course called "Testing" on http://en411.com (the username and password are the same as the course name, but in lowercase).
I'll admit I haven't actually looked through the PHP code (not that I would know what to look for) -- is there something that needs to be de-commented, perhaps?
Re: Batched upload of assignment grades - need testers
Pardon my ignorance, but how do teachers download the list of usernames from the server? Especially if the admin (another person) changed the username of a student for whatever reason.
Would it possible to make use of firstname+lastname combination in the future?
-- James
Thanks for the response. I will test this patch on my dev and production server and will report back the results.
If all goes well, this will be very handy for teachers whose users are allowed to create their own accounts with email notification.
Roel
Hi James,
Here is my initial test result.
for participants.zip
I patched ./user/index.php version 1.88.2.3, 2005/06/20. This one comes from my fantastico installed Moodle 1.5.2 on tagalog.ws.
It worked fine. I got the username without a hitch. Although I am not in a position to evaluate this, I was wondering if this tool will cause any security problems.
Anyway, I pasted the usernames on a textfile and imported that in excel, then added my grades.
for uploadgrades
I am actually trying to use uploadgrades to post my final grades to my students. It is sort of a workaround to gradebook. Because of our different grading system and the fact that I am not a programmer, and can barely read PHP so it will take me some time before I can make gradebook do my bidding.
So before, I manually give the grades in an offline assignment, using a customized scale which you can find on the image attached. It has the following values 1.0, 1.25, 1.5, 1.75, 2.0, 2.25, 2.5, 2.75, 3.0, 4.0, 5.0, INC, DRP, and WF.
When i uploaded the file containing these grades I got the ff. error message. I replaced the real usernames with username in this example.
Invalid grade: WF ... line 1 ignored: username,WF,Failed. Repeat the course.
Invalid grade: 3.0 ... line 2 ignored: username,3.0,Passed
Invalid grade: 3.0 ... line 3 ignored: username,3.0,Passed
Invalid grade: 3.0 ... line 4 ignored: username,3.0,Passed
Invalid grade: 5.0 ... line 5 ignored: username,5.0,Failed. Repeat the course.
Invalid grade: WF ... line 6 ignored: username,WF,Failed. Repeat the course.
Invalid grade: 5.0 ... line 7 ignored: username,5.0,Failed. Repeat the course.
Invalid grade: 5.0 ... line 8 ignored: username,5.0,Failed. Repeat the course.
Invalid grade: 2.75 ... line 9 ignored: username,2.75,Passed
Invalid grade: 5.0 ... line 10 ignored: username,5.0,Failed. Repeat the course.
Invalid grade: WF ... line 11 ignored: username,WF,Failed. Repeat the course.
Invalid grade: 5.0 ... line 12 ignored: username,5.0,Failed. Repeat the course.
Invalid grade: WF ... line 13 ignored: username,WF,Failed. Repeat the course.
Invalid grade: WF ... line 14 ignored: username,WF,Failed. Repeat the course.
Invalid grade: 3.0 ... line 15 ignored: username,3.0,Passed
Invalid grade: 5.0 ... line 16 ignored: username,5.0,Failed. Repeat the course. Final grade is 65.3177. Unfortunately Even if you were able to change your final paper-it is only 40% of the final grade and is not enough to pass.
Invalid grade: 2.0 ... line 17 ignored: username,2.0,Passed
Invalid grade: 2.5 ... line 18 ignored: username,2.5,Passed
Invalid grade: 2.0 ... line 19 ignored: username,2.0,Passed
<snip...>
Manually I can select the grades and it displayed correctly. I don't know if this is somekind of type mismatch with the db field; gradebook has a problem with it too. Is it a problem with scales, db, uploadgrades or am I misusing these tools?
The help file of uploadgrades say:
"Grade is the student's assignment grade, negative if a non-numeric scale is used"
so I tried putting negative signs before the grades but I still get the same error. I guess its back to manual grading for me .
This is a minor suggestion. The button Upload Grades seems to be using two strings from the existing en strings. It would probably be a good idea later on to have its own string entry in /lang/en/assignment.php so that we can translate it better. In tl lang pack it resulted in an ungrammatical translation.
--James
Hi James,
I've tested your fix on the same Moodle server I mentioned earlier and with the same data. I am happy to announce that it worked well .
Just some additional minor observations. After the grades are uploaded, the gridlines of the page of students grades dissappear, and the browser is reporting some error on the page. Sorry I failed to dig deeper.
Aside from this, when I made a user mistake and loaded my earlier data using scale 100 I got the invalid grade error message. Would it not be more helpful to have an error message like "Wrong Assignment Scale. Please correct the scale option in the Assignment settings page."
I really like this patch , and I hope it gets into the standard Assignment module. Is it already in contrib CVS?
Great work James,
Roel
I haven't seen any browser strangeness (I am using Mozilla) but if you find something I should know, do pass it on!
As to putting this patch into the CVS/contrib, I don't have a CVS account. I'll
ask Martin D. (but I bet he's pretty busy these days)!
Enjoy!
-- James
I did not actually make any mistake in the scaled grade value but in the selected scale. In other words I was putting non-numerical grades in a numerical 100 points scale---human error. But I already had a rethink on my suggestion because it would probably be difficult for the software to determine if the scale was wrong or the data was wrong, at least in my example since the integers 1.0 etc. was accepted. At any rate just ignore my earlier suggestion.
As for the cell gridlines or borders problem I have attached an image. The absence of the borders occur immediately after upload, and refreshing or viewing the page again returns it to normal. This occured with a Firefox version 1 and IE.
I thought it was just a table style problem and compared the html source for this page with the normal. All I saw was that this page output does not use <tbody> tags. But the tbody tags in the normal did not have attributes so I'm still looking for the cause.
Personally I don't think it is a big deal since the code functions, but it is somewhat disconcerting.
Roel
This forum post has been removed
What do you think about adding a 'download grade sheet' button that gave the teacher a csv w/ all the partipants in the course? (and column headings, etc?
You can already do that from the gradebook.
This forum post has been removed
By the way, I have a new version of uploadgrades.zip that integrates with the quickgrade changes applied to the Assignment module. However, I want to download the very latest 1.5.2+ tarball and resync my changes with the very latest code. Should have a new uploadgrades.zip in a day or so.
This forum post has been removed
after quickgrades stabilised. Enjoy!
--James
ps - Randy, I'll download your changes today!
This forum post has been removed
This forum post has been removed
Thanks.
--James Dugal
it does not work with Moodle1.8, we are using MySQL 5.0.41, PHP 4.4.7 and
APC 3.0.14.
James had created uploadgrades.php for instructors who have big classes., but unfortunately he is no longer with us.
Any suggestion will be appreciated.
Thank you.
-Kin
Re: Batched upload of assignment grades - need testers
I really hope that if somebody has some patch to fix this problem can delivered and share it with us.
Re: Batched upload of assignment grades - need testers
I would also need this features for our teachers.
Thanks, Kasia