Forgive me for butting in here - but I'm the PostgreSQL user whose plea for help Petr linked to above. Stumbled into this forum purely by accident...
I have a development box running PostgreSQL 7.4.5 as well as my production box running 7.4. Can I be of any help in testing?
Thanks,
Worth
Index: lib.php =================================================================== RCS file: /cvsroot/moodle/moodle/mod/assignment/lib.php,v retrieving revision 1.118.2.5 diff -u -r1.118.2.5 lib.php --- lib.php 5 Jul 2005 06:28:53 -0000 1.118.2.5 +++ lib.php 7 Jul 2005 21:43:14 -0000 @@ -757,7 +757,7 @@ } - $select = 'SELECT u.id, u.id, u.firstname, u.lastname, u.picture, s.id AS submissionid, s.grade, s.comment, s.timemodified, s.timemarked, ((s.timemarked > 0) && (s.timemarked >= s.timemodified)) AS status '; + $select = 'SELECT u.id, u.id, u.firstname, u.lastname, u.picture, s.id AS submissionid, s.grade, s.comment, s.timemodified, s.timemarked, ((s.timemarked > 0) AND (s.timemarked >= s.timemodified)) AS status '; $sql = 'FROM '.$CFG->prefix.'user u '. 'LEFT JOIN '.$CFG->prefix.'assignment_submissions s ON u.id = s.userid AND s.assignment = '.$this->assignment->id.' '. 'WHERE '.$where.'u.id IN ('.implode(',', array_keys($users)).') ';
This change allowed me to view submitted assignments without throwing the error. Success.
However - while working through this process and testing, I tried to modify some of the existing assignments. Each attempt yielded the following error:
ERROR: invalid input syntax for integer: ""
UPDATE mdl_assignment SET course = '9', name = 'Assignment One', description = 'Assignment decription', format = '1', assignmenttype = 'offline', resubmit = '', preventlate = '0', emailteachers = '', var1 = '', var2 = '', var3 = '', var4 = '', var5 = '', maxbytes = '5242880', timedue = '1286979300', timeavailable = '0', grade = '', timemodified = '1120780256' WHERE id = '4'
| Could not update the assignment |
This error was the same regardless of whether the code above was "&&" or "AND" so it looks to be unrelated.
I could create a new assignment, but got the same error if I tried to modify it after submitting it.
I'm bailing now, but will have a few hours in the morning (~12 hours from now - I'm in US Eastern time zone) and would like to help. After about 14:00 EDT tomorrow, I'll be out-of-pocket for much of the following week.
Thanks, Petr, and I hope this helps.
Index: weblib.php
===================================================================
RCS file: /cvsroot/moodle/moodle/lib/weblib.php,v
retrieving revision 1.469.2.13
diff -u -r1.469.2.13 weblib.php --- weblib.php 6 Jul 2005 06:54:58 -0000 1.469.2.13 +++ weblib.php 8 Jul 2005 12:48:36 -0000 @@ -98,9 +98,11 @@ * @return string */ function s($var) { - - if (empty($var)) { - return ''; + if (!isset($var)) { // TODO: temporary hack to make it more + return ''; // compatible with 1.5, removed in 1.6 + } + if ($var == '0') { // for integer 0, boolean false, string '0' + return '0'; } return htmlSpecialChars(stripslashes_safe($var)); } @@ -115,9 +117,11 @@ * @return string */ function p($var) { - - if (empty($var)) { - echo ''; + if (!isset($var)) { // TODO: temporary hack to make it more + echo ''; // compatible with 1.5, removed in 1.6 + } + if ($var == '0') { // for integer 0, boolean false, string '0' + echo '0'; } echo htmlSpecialChars(stripslashes_safe($var)); }
Index: weblib.php
===================================================================
RCS file: /cvsroot/moodle/moodle/lib/weblib.php,v
retrieving revision 1.469.2.13
diff -u -r1.469.2.13 weblib.php --- weblib.php 6 Jul 2005 06:54:58 -0000 1.469.2.13 +++ weblib.php 8 Jul 2005 13:40:11 -0000 @@ -98,9 +98,11 @@ * @return string */ function s($var) { - - if (empty($var)) { - return ''; + if (!isset($var)) { // TODO: temporary hack to make it more + return ''; // compatible with 1.5, removed in 1.6 + } + if ($var == '0') { // for integer 0, boolean false, string '0' + return '0'; } return htmlSpecialChars(stripslashes_safe($var)); } @@ -115,11 +117,11 @@ * @return string */ function p($var) { - - if (empty($var)) { - echo ''; + if ($var == '0') { // for integer 0, boolean false, string '0' + echo '0'; + } else { + echo htmlSpecialChars(stripslashes_safe($var)); } - echo htmlSpecialChars(stripslashes_safe($var)); }
Ok, Petr, I have this in weblib.php:
function s($var){
if (!isset ($var)) { // TODO: temporary hack to make it more
return ''; // compatible with 1.5, removed in 1.6
}
if ($var == '0') { // for interger 0, boolean false, string '0'
return '0';
}
return htmlSpecialChars(stripslashes_safe($var));
}
/**
* Add quotes to HTML characters...
* ...@return string
*/
function p($var) {
if ($var == '0') { // for integer 0, boolean false, string '0'
echo '0';
} else {
echo htmlSpecialChars(stripslashes_safe($var));
}
}
I try an update to a course and again get: ERROR: invalid input syntax for integer: ""
Have I flubbed it?
Thanks,
Worth
Index: mod.html =================================================================== RCS file: /cvsroot/moodle/moodle/mod/assignment/mod.html,v retrieving revision 1.36 diff -u -r1.36 mod.html --- mod.html 19 May 2005 14:13:21 -0000 1.36 +++ mod.html 8 Jul 2005 14:29:06 -0000 @@ -13,9 +13,6 @@ if (empty($form->assignmenttype)) { $form->assignmenttype = "uploadsingle"; } - if (empty($form->resubmit)) { - $form->resubmit = ""; - } if (!isset($form->grade)) { $form->grade = 100; }
Just confirming:
With 3 changes above re: weblib.php (2) and mod.html, the assignments are updating cheerfully...
Thanks!
Worth
Hey, Martin!
I have use Moodle (Moodle 1.5.1 (2005060210)) with PG and I can report some bugs. For example:
(...)I have also a problem with the Assignment module after this installation. Some strange... see http://moodle.org/mod/forum/discuss.php?d=27513 (...)
But nobody give me a response...
