Yes...you need to add some php code into the layout files...general.php and frontpage.php which I think are present in base theme's layout files but not canvas, from memory.
$showsidepre = ($hassidepre && !$PAGE->blocks->region_completely_docked('side-pre', $OUTPUT));
$showsidepost = ($hassidepost && !$PAGE->blocks->region_completely_docked('side-post', $OUTPUT));
and
$bodyclasses = array();
if ($showsidepre && !$showsidepost) {
$bodyclasses[] = 'side-pre-only';
} else if ($showsidepost && !$showsidepre) {
$bodyclasses[] = 'side-post-only';
} else if (!$showsidepost && !$showsidepre) {
$bodyclasses[] = 'content-only';
}
Checkout Standard theme as this uses no layouts of its own, but uses base theme's layouts. If you want a copy of a new theme based on standard which I have just made, and which has a nice looking 'dock' send me your email in a PM....and I'll email you a copy.
Cheers
Mary
You'll also (I think) need to add the block-region class to the region # like:
<div id="region-pre" class="block-region">
That should keep the other blocks from disappearing as well.
Howard,
Using general.php from base is OK that's what I do. But if you want canvase to style some of your new theme as you had Canvas as a parent, then make sure you have both Canvas & Base as your parent themes this is what you should have done. So DO NOT take Canvas OFF as this will style your theme as you had it as it was relying on Canvas in the first place.
So to recap.
Parent themes should be as described in my other post of yesterday.
parent = array('canvas', 'base') and you should be good to go.
Sorry can't remember the correct code! I only logged in because I needed to see if BT tinternet was working as am setting up BT Vision but could not bear to think you were in dire straights over this theme business! LOL
Cheers
Mary
lol Howard - sounds like my situation too Live on the outskirts of a town in S.Wales that's supposed to have good broadband, but half way up a mountain and right at the outer limits of the phoneline which means I get about .5 of my 'upto 20Mb'!!!
In terms of the layout, I generally use standard (and base) as my main parent as that uses the dock, and build things off that. But I've also built themes that start from scratch and do their own thing with headers - and a couple that used a separate php include to call a different header file entirely (mostly these were for my own learning and trying things out rather than for practical use though), including one I'm working on at the minute in work because the current 1.9 moodle is integrated with lots of other pieces of the intranet and currently has a separate header html file. So it can be done, you don't have to use the complete base layout file instead of the complete canvas one - You could think about taking the header part of the layout of the one file which you've already adapted to replace the header part of the one that has the dock functions in on the one you want to use. It might mean fewer changes to the css you've developed?
Just a thought
Richard
That's .5Mb not .5 of 20Mb (ie 10Mb)!!! lol!!!
Hi Howard,
Dietmar and I are working on the pagelayouts for all the themes, and finding more problems as we mine the code. The idea is to try and simplyify report layout so that all themes use base theme.
However, base theme has got a zero page height, which can be fixed by adding <div class="clearfix"></div> just before the last </div> in both frontpage.php and general.php in your theme.
I'll send you a link to download the theme I made recently it's very basic. It uses standard and base as parents.
As for Canvas, well that theme needs updating as it should have the dock adding just in case people want to clone it to use as a base for a custom theme.
Cheers
Mary
I use canvas, and docking, every day and have never had an issue with docking. I'm not sure where the issue might be for you, but I don't see it.
-edit-
Attached is a simple canvas based theme with docking enabled. All you needed to do was add the block-region class as I noted above.
Personally I think Canvas needs updating as I mentioned to Howard. The dock elements should be in the layout files. They don;t need to be activated in Canvas but would have been better had they were.
I think that when Patrick built this theme in the first place he was just learning how it worked. Now we know more there are elements like the dock which were in the early stages of Moodle 2.0 themes, not available and to tell you the truth, few people knew how thay work.
There are still lots of errors in these themes and the more you fix the more you uncover. In short some are a bit of a mine field.
Cheers
Mary
You sound like a Scotsman when you talk like that!
and I am tempted to reply...
Ayeee...!
