Does Moodle 2.0 P4 seem slow?

Re: Does Moodle 2.0 P4 seem slow?

by Mauno Korpelainen -
Number of replies: 3

One single note about current editor init code in lib/editor/tinymce/lib.php:

'plugins' => "{$xmedia}advimage,safari,table,style,layer,advhr,advlink,emotions,inlinepopups,searchreplace,paste,directionality,fullscreen,moodlenolink,{$xdragmath}nonbreaking,contextmenu,insertdatetime,save,iespell,preview,print,noneditable,visualchars,xhtmlxtras,template,pagebreak,spellchecker",
            
These red plugins are useless - safari plugin has been needless since tinymce Version 3.3b1 (2010-01-25) when safari code was moved to core code of tinymce and loading these other plugins is waste of time because these plugins are otherwise useless and could be removed from default init code smile

Theme designer mode (enabled) makes loading separate css files and javascripts a little slower than the case when theme designer mode is disabled - particularly in IE - but sometimes it looks like also Apache had some problems with loading various files (Apache stops responding occasionally when there are lots of files to be loaded?)

Regarding the usability of editor we discussed about number of buttons and plugins in http://moodle.org/mod/forum/discuss.php?d=130470 and I tested yesterday using userpreferences with editorswitcher the same way as Sam added style body class changes to Splash theme and I tested also a jQuery plugin for changing visible rows of toolbar (the famous WP 'kitchen sink button'). I know what people say about jQuery but... the growth of rows of yui code is remarkable...

Attachment toolbars.gif
In reply to Mauno Korpelainen

Re: Does Moodle 2.0 P4 seem slow?

by sam marshall -
Picture of Core developers Picture of Peer reviewers Picture of Plugin developers
Did you file a bug about the extra plugins?

--sam
In reply to sam marshall

Re: Does Moodle 2.0 P4 seem slow?

by Mauno Korpelainen -

Olli filed http://tracker.moodle.org/browse/MDL-20139 last year - but this editor configuration issue (which buttons and plugins should be loaded by default) plays only a very small part in performance problems. And editor user preferences and administration of buttons and plugins is obviously one of those things that are moved to coming versions. Petr has written nice code for using parallel editors and it is possible to change whole editors with $CFG->texteditors or even user based settings with these new yui things M.util.set_user_preference... so there is only a small step missing from fully functional administration of buttons and plugins of editors...

After my last post I actually tested how changing the init code affects loading times both theme designer mode enabled and disabled and the effect of taking away half of those plugins can't be seconds - not even in IE7. On slow connections it still causes more http requests if each plugin is loaded separately. Designer mode disabled & cache made loading editor page a couple seconds faster even in Chrome and like you said before IE9 all versions of IE have been slower than other browsers.

http://qa.moodle.net/ had some strange yui and css errors/notes in IE8 developer tools console - particularly when blocks were moved to dock and back - maybe that test site has some non core code settings or non upgraded code that slow down IE even more. But I did not get even close to 15 seconds loading times - it took maybe 2-3 seconds to load single editing page...

In reply to Mauno Korpelainen

Re: Does Moodle 2.0 P4 seem slow?

by Mauno Korpelainen -
( Off the original topic - but in fact this toolbar switcher plugin does not require jQuery at all - it's a tiny plugin that simply toggles visible toolbars in advanced theme. So if default value is set to show only first row of toolbar only the first row of buttons is loaded and you can toggle button to see the other rows of toolbar. In WordPress switching is done with jQuery but the version with "normal javascript" works as well... )